mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Jason Wessel <jason.wessel@windriver.com>
To: torvalds@linux-foundation.org
Cc: linux-kernel@vger.kernel.org,
	kgdb-bugreport@lists.sourceforge.net,
	Dongdong Deng <dongdong.deng@windriver.com>,
	Jason Wessel <jason.wessel@windriver.com>
Subject: [PATCH 16/17] kgdb,x86: use macro HBP_NUM to replace magic number 4
Date: Thu,  5 Aug 2010 09:37:57 -0500	[thread overview]
Message-ID: <1281019078-6636-17-git-send-email-jason.wessel@windriver.com> (raw)
In-Reply-To: <1281019078-6636-16-git-send-email-jason.wessel@windriver.com>

From: Dongdong Deng <dongdong.deng@windriver.com>

Use the macros provided by the HW breakpoint API.

Signed-off-by: Dongdong Deng <dongdong.deng@windriver.com>
Signed-off-by: Jason Wessel <jason.wessel@windriver.com>
---
 arch/x86/kernel/kgdb.c |   18 +++++++++---------
 1 files changed, 9 insertions(+), 9 deletions(-)

diff --git a/arch/x86/kernel/kgdb.c b/arch/x86/kernel/kgdb.c
index a8b8097..ef10940 100644
--- a/arch/x86/kernel/kgdb.c
+++ b/arch/x86/kernel/kgdb.c
@@ -195,7 +195,7 @@ static struct hw_breakpoint {
 	int			len;
 	int			type;
 	struct perf_event	**pev;
-} breakinfo[4];
+} breakinfo[HBP_NUM];
 
 static unsigned long early_dr7;
 
@@ -203,7 +203,7 @@ static void kgdb_correct_hw_break(void)
 {
 	int breakno;
 
-	for (breakno = 0; breakno < 4; breakno++) {
+	for (breakno = 0; breakno < HBP_NUM; breakno++) {
 		struct perf_event *bp;
 		struct arch_hw_breakpoint *info;
 		int val;
@@ -290,10 +290,10 @@ kgdb_remove_hw_break(unsigned long addr, int len, enum kgdb_bptype bptype)
 {
 	int i;
 
-	for (i = 0; i < 4; i++)
+	for (i = 0; i < HBP_NUM; i++)
 		if (breakinfo[i].addr == addr && breakinfo[i].enabled)
 			break;
-	if (i == 4)
+	if (i == HBP_NUM)
 		return -1;
 
 	if (hw_break_release_slot(i)) {
@@ -311,7 +311,7 @@ static void kgdb_remove_all_hw_break(void)
 	int cpu = raw_smp_processor_id();
 	struct perf_event *bp;
 
-	for (i = 0; i < 4; i++) {
+	for (i = 0; i < HBP_NUM; i++) {
 		if (!breakinfo[i].enabled)
 			continue;
 		bp = *per_cpu_ptr(breakinfo[i].pev, cpu);
@@ -331,10 +331,10 @@ kgdb_set_hw_break(unsigned long addr, int len, enum kgdb_bptype bptype)
 {
 	int i;
 
-	for (i = 0; i < 4; i++)
+	for (i = 0; i < HBP_NUM; i++)
 		if (!breakinfo[i].enabled)
 			break;
-	if (i == 4)
+	if (i == HBP_NUM)
 		return -1;
 
 	switch (bptype) {
@@ -395,7 +395,7 @@ void kgdb_disable_hw_debug(struct pt_regs *regs)
 
 	/* Disable hardware debugging while we are in kgdb: */
 	set_debugreg(0UL, 7);
-	for (i = 0; i < 4; i++) {
+	for (i = 0; i < HBP_NUM; i++) {
 		if (!breakinfo[i].enabled)
 			continue;
 		if (dbg_is_early) {
@@ -640,7 +640,7 @@ void kgdb_arch_late(void)
 	attr.bp_len = HW_BREAKPOINT_LEN_1;
 	attr.bp_type = HW_BREAKPOINT_W;
 	attr.disabled = 1;
-	for (i = 0; i < 4; i++) {
+	for (i = 0; i < HBP_NUM; i++) {
 		if (breakinfo[i].pev)
 			continue;
 		breakinfo[i].pev = register_wide_hw_breakpoint(&attr, NULL);
-- 
1.6.3.3


  reply	other threads:[~2010-08-05 14:39 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-08-05 14:37 [GIT PULL] kgdb,kdb for 2.6.36 (1 of 2) Jason Wessel
2010-08-05 14:37 ` [PATCH 01/17] kgdb: remove custom hex_to_bin()implementation Jason Wessel
2010-08-05 14:37   ` [PATCH 02/17] gdbstub: Optimize kgdb's "thread:" response for the gdb serial protocol Jason Wessel
2010-08-05 14:37     ` [PATCH 03/17] kgdb,kdb: individual register set and and get API Jason Wessel
2010-08-05 14:37       ` [PATCH 04/17] kgdb,x86: Individual register get/set for x86 Jason Wessel
2010-08-05 14:37         ` [PATCH 05/17] kgdb,mips: Individual register get/set for mips Jason Wessel
2010-08-05 14:37           ` [PATCH 06/17] kgdb,arm: Individual register get/set for arm Jason Wessel
2010-08-05 14:37             ` [PATCH 07/17] gdbstub: Implement gdbserial 'p' and 'P' packets Jason Wessel
2010-08-05 14:37               ` [PATCH 08/17] gdbstub: do not directly use dbg_reg_def[] in gdb_cmd_reg_set() Jason Wessel
2010-08-05 14:37                 ` [PATCH 09/17] arm,kgdb: Add ability to trap into debugger on notify_die Jason Wessel
2010-08-05 14:37                   ` [PATCH 10/17] kgdb,powerpc: Replace hardcoded offset by BREAK_INSTR_SIZE Jason Wessel
2010-08-05 14:37                     ` [PATCH 11/17] ftrace,kdb: Extend kdb to be able to dump the ftrace buffer Jason Wessel
2010-08-05 14:37                       ` [PATCH 12/17] ftrace,kdb: Allow dumping a specific cpu's buffer with ftdump Jason Wessel
2010-08-05 14:37                         ` [PATCH 13/17] KGDB: Remove set but unused newPC Jason Wessel
2010-08-05 14:37                           ` [PATCH 14/17] mm,kdb,kgdb: Add a debug reference for the kdb kmap usage Jason Wessel
2010-08-05 14:37                             ` [PATCH 15/17] kgdb,mips: remove unused kgdb_cpu_doing_single_step operations Jason Wessel
2010-08-05 14:37                               ` Jason Wessel [this message]
2010-08-05 14:37                                 ` [PATCH 17/17] debug_core,kdb: fix crash when arch does not have single step Jason Wessel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1281019078-6636-17-git-send-email-jason.wessel@windriver.com \
    --to=jason.wessel@windriver.com \
    --cc=dongdong.deng@windriver.com \
    --cc=kgdb-bugreport@lists.sourceforge.net \
    --cc=linux-kernel@vger.kernel.org \
    --cc=torvalds@linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®