mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Peter Zijlstra <a.p.zijlstra@chello.nl>
To: "H. Peter Anvin" <hpa@zytor.com>
Cc: Thomas Gleixner <tglx@linutronix.de>, Ingo Molnar <mingo@elte.hu>,
	Arnaldo Carvalho de Melo <acme@redhat.com>,
	Steven Rostedt <rostedt@goodmis.org>,
	LKML <linux-kernel@vger.kernel.org>
Subject: Re: tip: New "Link:" tag to replace "LKML-Reference:"
Date: Thu, 07 Apr 2011 16:08:32 +0200	[thread overview]
Message-ID: <1302185312.3329.1240.camel@twins> (raw)
In-Reply-To: <4D9CE4AE.4090303@zytor.com>

On Wed, 2011-04-06 at 15:09 -0700, H. Peter Anvin wrote:
> Hi all,
> 
> At Linus' request, I have modified the tip-bot to recognize a new form
> of email archive references, which should work as clickable links.
> Instead of:
> 
> LKML-Reference: <message-id>
> 
> use, instead:
> 
> Link: http://lkml.kernel.org/r/message-id
> 
> The entire bit "Link: http://lkml.kernel.org/r/" is a literal; the rest
> is the message-id from the original message, *without* angle brackets.
> This points to a redirection service on kernel.org, which currently
> bounces to marc.info, but which we can redirect in the future.
> 
> I changed the name from LKML-Reference: to Link: to make the width of
> the string tolerable, and since the link itself contains an explicit
> reference to the specific archive used.
> 
> Please note that message-ids sometimes contain characters which have to
> be escaped to fit in valid URI syntax!  The characters @ and $ which are
> very common in message-ids do not, however, need to be escaped in this
> particular context (even though they are not part of the URI safe
> character set, and so most library functions will escape them.)  The
> characters # ; & % as well as whitespace are definitely unsafe either
> for use in an URI or for programs to recognize them as part of one, and
> should definitely be escaped.
> 
> The tip-bot will recognize the *exact* form above (including URI
> escaping) and should do the message threading correctly.  To keep people
> from injecting malicious links, however, there is sanity filtering on
> the unescaped content, so in theory a legal-but-weird message-id might
> be rejected.

OK, so I fixed my scripts to match this and it all seems to work, except
for the:

 LKML-Reference: <new-submission>

case, where the tip-bot would mail it out for me. While I try not to use
it too much its convenient for quick fixes etc. Will the absence of a
Link tag suffice or is there more to it?

  reply	other threads:[~2011-04-07 14:08 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-04-06 22:09 H. Peter Anvin
2011-04-07 14:08 ` Peter Zijlstra [this message]
2011-04-07 14:43   ` H. Peter Anvin
2011-04-07 14:54     ` Peter Zijlstra
2011-04-07 14:56       ` H. Peter Anvin
2011-04-07 15:03         ` Peter Zijlstra
2011-04-07 15:20           ` H. Peter Anvin
2011-04-07 15:26             ` Peter Zijlstra
2011-04-08 19:05             ` Link: tags for new submission -- UPDATE H. Peter Anvin
2011-04-07 15:03       ` tip: New "Link:" tag to replace "LKML-Reference:" H. Peter Anvin
2011-04-07 15:28 ` Sam Ravnborg
2011-04-07 15:58   ` H. Peter Anvin
2011-04-08 14:36 ` Bjorn Helgaas
2011-04-08 18:45   ` H. Peter Anvin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1302185312.3329.1240.camel@twins \
    --to=a.p.zijlstra@chello.nl \
    --cc=acme@redhat.com \
    --cc=hpa@zytor.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@elte.hu \
    --cc=rostedt@goodmis.org \
    --cc=tglx@linutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®