mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "H. Peter Anvin" <hpa@zytor.com>
To: Peter Zijlstra <a.p.zijlstra@chello.nl>
Cc: Thomas Gleixner <tglx@linutronix.de>, Ingo Molnar <mingo@elte.hu>,
	Arnaldo Carvalho de Melo <acme@redhat.com>,
	Steven Rostedt <rostedt@goodmis.org>,
	LKML <linux-kernel@vger.kernel.org>
Subject: Re: tip: New "Link:" tag to replace "LKML-Reference:"
Date: Thu, 07 Apr 2011 07:43:55 -0700	[thread overview]
Message-ID: <4D9DCDAB.9000707@zytor.com> (raw)
In-Reply-To: <1302185312.3329.1240.camel@twins>

On 04/07/2011 07:08 AM, Peter Zijlstra wrote:
> 
> OK, so I fixed my scripts to match this and it all seems to work, except
> for the:
> 
>  LKML-Reference: <new-submission>
> 
> case, where the tip-bot would mail it out for me. While I try not to use
> it too much its convenient for quick fixes etc. Will the absence of a
> Link tag suffice or is there more to it?
> 

OK, I have asked for a long time that we do not use <new-submission>.

The recommended pattern has been:

LKML-Reference: <tip-*@git.kernel.org>

... which at least indicates to the user how the message-ID is to be
generated (* being a placeholder for the commit SHA1).

The only think I can think of for how to make Link: work would be to
recognize a pattern that the tip-bot would use as its own Message-ID
*instead* of the commit SHA1 pattern that it would normally use.  There
are disadvantages to every approach, of course.

We have a couple of alternatives:

a) Continue to use "LKML-Reference: <tip-*@git.kernel.org>"
   + At least gives a hint how to find the newly-formed LKML thread
   - Not a clickable link
   - Somewhat noisy
b) Just Cc: everything to LKML regardless of tag
   + Easy
   - No way to *not* post everything to LKML
   - No way to locate the thread without knowing the magic
c) A recognizable pattern with a unique pattern *generated by the
   committer*, something like:
   Link: http://lkml.kernel.org/r/tip-`uuidgen -r`@git.kernel.org
   + Clickable link
   - Long (the above is 86 characters wide)
   - Message-IDs of a nonstandard form
   - Bad things will happen if someone re-uses an identifier
   - String has to be generated by machine at commit time

[Using ranpwd instead of uuidgen allows for a more compact random string
by using a wider character set.  For example:

Link: http://lkml.kernel.org/r/tip-`ranpwd -l 24`@git.kernel.org

... has the same entropy but is 74 characters wide.]

Thoughts?

	-hpa

-- 
H. Peter Anvin, Intel Open Source Technology Center
I work for Intel.  I don't speak on their behalf.


  reply	other threads:[~2011-04-07 14:44 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-04-06 22:09 H. Peter Anvin
2011-04-07 14:08 ` Peter Zijlstra
2011-04-07 14:43   ` H. Peter Anvin [this message]
2011-04-07 14:54     ` Peter Zijlstra
2011-04-07 14:56       ` H. Peter Anvin
2011-04-07 15:03         ` Peter Zijlstra
2011-04-07 15:20           ` H. Peter Anvin
2011-04-07 15:26             ` Peter Zijlstra
2011-04-08 19:05             ` Link: tags for new submission -- UPDATE H. Peter Anvin
2011-04-07 15:03       ` tip: New "Link:" tag to replace "LKML-Reference:" H. Peter Anvin
2011-04-07 15:28 ` Sam Ravnborg
2011-04-07 15:58   ` H. Peter Anvin
2011-04-08 14:36 ` Bjorn Helgaas
2011-04-08 18:45   ` H. Peter Anvin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4D9DCDAB.9000707@zytor.com \
    --to=hpa@zytor.com \
    --cc=a.p.zijlstra@chello.nl \
    --cc=acme@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@elte.hu \
    --cc=rostedt@goodmis.org \
    --cc=tglx@linutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

Powered by JetHome