mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "H. Peter Anvin" <hpa@zytor.com>
To: Peter Zijlstra <a.p.zijlstra@chello.nl>
Cc: Thomas Gleixner <tglx@linutronix.de>, Ingo Molnar <mingo@elte.hu>,
	Arnaldo Carvalho de Melo <acme@redhat.com>,
	Steven Rostedt <rostedt@goodmis.org>,
	LKML <linux-kernel@vger.kernel.org>
Subject: Link: tags for new submission -- UPDATE
Date: Fri, 08 Apr 2011 12:05:35 -0700	[thread overview]
Message-ID: <4D9F5C7F.6020001@zytor.com> (raw)
In-Reply-To: <4D9DD62E.2050308@zytor.com>

On 04/07/2011 08:20 AM, H. Peter Anvin wrote:
> On 04/07/2011 08:03 AM, Peter Zijlstra wrote:
>>
>> D'0h ok.. but the scheme would work with any generated msgid, all we
>> need is to generate one for commits that lack a Link tag and insert it
>> using the prepare-commit-msg/commit-msg hooks and for the post-commit
>> hook to recognize it and use that actual msgid.
>>
>> The only thing to avoid is msgid collision, but given that MUAs already
>> have this problem all we need to do is borrow some of their logic.
>>
> 
> OK, this doesn't really need any hooks at all (the tip-bot is not a
> hook).  The committer is, and *has to be* responsible for getting the
> unique string into the Link: tag, through whatever means they feel is
> appropriate.
> 
> Based on the previous message, I'm going to modify the bot to recognize
> the pattern:
> 
> Link: http://lkml.kernel.org/r/tip-`ranpwd -l 24`@git.kernel.org
> 
> ... to override the Message-ID.  It seems like the least ugly of a lot
> of ugly options.
> 

<<<< IMPORTANT CHANGE >>>>

Please use the format:

Link: http://lkml.kernel.org/n/tip-`ranpwd -l 24`@git.kernel.org
                             ^

... with an "n" for "new" instead of "r" for "reference" instead.

This allows the bot to distinguish a "new submission" link from a
*reference* to a message that was created as a result of a new submission!

	-hpa



  parent reply	other threads:[~2011-04-08 19:05 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-04-06 22:09 tip: New "Link:" tag to replace "LKML-Reference:" H. Peter Anvin
2011-04-07 14:08 ` Peter Zijlstra
2011-04-07 14:43   ` H. Peter Anvin
2011-04-07 14:54     ` Peter Zijlstra
2011-04-07 14:56       ` H. Peter Anvin
2011-04-07 15:03         ` Peter Zijlstra
2011-04-07 15:20           ` H. Peter Anvin
2011-04-07 15:26             ` Peter Zijlstra
2011-04-08 19:05             ` H. Peter Anvin [this message]
2011-04-07 15:03       ` H. Peter Anvin
2011-04-07 15:28 ` Sam Ravnborg
2011-04-07 15:58   ` H. Peter Anvin
2011-04-08 14:36 ` Bjorn Helgaas
2011-04-08 18:45   ` H. Peter Anvin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4D9F5C7F.6020001@zytor.com \
    --to=hpa@zytor.com \
    --cc=a.p.zijlstra@chello.nl \
    --cc=acme@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@elte.hu \
    --cc=rostedt@goodmis.org \
    --cc=tglx@linutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

Powered by JetHome