mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Don Zickus <dzickus@redhat.com>
To: <x86@kernel.org>
Cc: LKML <linux-kernel@vger.kernel.org>,
	Cyrill Gorcunov <gorcunov@gmail.com>,
	Cyrill Gorcunov <gorcunov@openvz.org>,
	Don Zickus <dzickus@redhat.com>
Subject: [PATCH 2/4] perf, x86: P4 PMU - Don't forget to clear cpuc->active_mask on overflow
Date: Thu, 21 Apr 2011 11:03:21 -0400	[thread overview]
Message-ID: <1303398203-2918-3-git-send-email-dzickus@redhat.com> (raw)
In-Reply-To: <1303398203-2918-1-git-send-email-dzickus@redhat.com>

From: Cyrill Gorcunov <gorcunov@gmail.com>

It's not enough to simply disable event on overflow the cpuc->active_mask
should be cleared as well otherwise counter may stall in "active" even
in real being already disabled (which potentially may lead to the situation
that user may not use this counter further).

Don pointed "I also noticed this patch fixed some unknown NMIs on a P4 when
I stressed the box".

Tested-by: Lin Ming <ming.m.lin@intel.com>
Signed-off-by: Cyrill Gorcunov <gorcunov@openvz.org>
Acked-by: Don Zickus <dzickus@redhat.com>
Signed-off-by: Don Zickus <dzickus@redhat.com>
---
 arch/x86/kernel/cpu/perf_event_p4.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/arch/x86/kernel/cpu/perf_event_p4.c b/arch/x86/kernel/cpu/perf_event_p4.c
index 6f2bd89..56ba449 100644
--- a/arch/x86/kernel/cpu/perf_event_p4.c
+++ b/arch/x86/kernel/cpu/perf_event_p4.c
@@ -946,7 +946,7 @@ static int p4_pmu_handle_irq(struct pt_regs *regs)
 		if (!x86_perf_event_set_period(event))
 			continue;
 		if (perf_event_overflow(event, 1, &data, regs))
-			p4_pmu_disable_event(event);
+			x86_pmu_stop(event, 0);
 	}
 
 	if (handled) {
-- 
1.7.4.2


  parent reply	other threads:[~2011-04-21 20:04 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-04-21 15:03 [PATCH 0/4] perf, x86: collection of pentium 4 fixes Don Zickus
2011-04-21 15:03 ` [PATCH 1/4] perf, x86: P4 PMU -- Use perf_sample_data_init helper Don Zickus
2011-04-22  8:20   ` Ingo Molnar
2011-04-22  8:35     ` Cyrill Gorcunov
2011-04-22 12:18   ` [tip:perf/core] " tip-bot for Cyrill Gorcunov
2011-04-21 15:03 ` Don Zickus [this message]
2011-04-22 12:19   ` [tip:perf/urgent] perf, x86: P4 PMU - Don't forget to clear cpuc->active_mask on overflow tip-bot for Cyrill Gorcunov
2011-04-21 15:03 ` [PATCH 3/4] perf, nmi: Move LVT un-masking into irq handlers Don Zickus
2011-04-22  8:26   ` Ingo Molnar
2011-04-25 13:39     ` Don Zickus
2011-04-25 14:15       ` Cyrill Gorcunov
     [not found]         ` <BANLkTi=t7bZ0sFRvUt=a=_54fhXtccPYnQ@mail.gmail.com>
2011-04-25 14:28           ` Cyrill Gorcunov
2011-04-25 14:50         ` Don Zickus
2011-04-25 14:51           ` Cyrill Gorcunov
2011-04-21 15:03 ` [PATCH 4/4] perf, x86: Add PERF_COUNT_HW_NMI_WATCHDOG event Don Zickus
2011-04-22  8:18   ` Ingo Molnar
2011-04-22  8:43     ` Cyrill Gorcunov
2011-04-22  8:54       ` Peter Zijlstra
2011-04-22  9:24         ` Cyrill Gorcunov
2011-04-22  9:45           ` Peter Zijlstra
2011-04-22 10:02             ` Cyrill Gorcunov
2011-04-22 15:15             ` Cyrill Gorcunov
2011-04-25 13:41               ` Don Zickus
2011-04-25 14:05                 ` Cyrill Gorcunov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1303398203-2918-3-git-send-email-dzickus@redhat.com \
    --to=dzickus@redhat.com \
    --cc=gorcunov@gmail.com \
    --cc=gorcunov@openvz.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

Powered by JetHome