From: Cyrill Gorcunov <gorcunov@gmail.com>
To: Ingo Molnar <mingo@elte.hu>
Cc: Don Zickus <dzickus@redhat.com>,
"x86@kernel.org" <x86@kernel.org>,
LKML <linux-kernel@vger.kernel.org>,
Cyrill Gorcunov <gorcunov@openvz.org>,
Peter Zijlstra <a.p.zijlstra@chello.nl>
Subject: Re: [PATCH 4/4] perf, x86: Add PERF_COUNT_HW_NMI_WATCHDOG event
Date: Fri, 22 Apr 2011 12:43:38 +0400 [thread overview]
Message-ID: <BANLkTimh80LorfC8O-HOPAAWK9BLYNjcXA@mail.gmail.com> (raw)
In-Reply-To: <20110422081838.GA24011@elte.hu>
P4 cant move events between counters in compare with architectural
event so when nmi-watchdog is used perf top is blocked because it
needs same counters but the counters already borrowed for watchdog. as
result we need a different event and counters for watchdog.
Ingo, nonsleeping cycles is from intel sdm, so when someone start
reading this code in future will find this term in sdm fast. or i
could put the reference from sdm itself here, hm?
On Friday, April 22, 2011, Ingo Molnar <mingo@elte.hu> wrote:
>
> * Don Zickus <dzickus@redhat.com> wrote:
>
>> From: Cyrill Gorcunov <gorcunov@gmail.com>
>>
>> Due to restriction and specifics of Netburst PMU we need
>> a separated event for NMI watchdog. Note that on all other
>> than P4 PMU cpus this event is a simple alias for PERF_COUNT_HW_CPU_CYCLES.
>>
>> This event is only used by x86 for now so no other archs involved.
>
> hm, there's no explanation exactly why this is needed and what the alternatives
> are.
>
> This sentence:
>
>> + /* we use that named non-sleeping calls */
>
> does not parse for me.
>
> Thanks,
>
> Ingo
>
next prev parent reply other threads:[~2011-04-22 8:43 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-04-21 15:03 [PATCH 0/4] perf, x86: collection of pentium 4 fixes Don Zickus
2011-04-21 15:03 ` [PATCH 1/4] perf, x86: P4 PMU -- Use perf_sample_data_init helper Don Zickus
2011-04-22 8:20 ` Ingo Molnar
2011-04-22 8:35 ` Cyrill Gorcunov
2011-04-22 12:18 ` [tip:perf/core] " tip-bot for Cyrill Gorcunov
2011-04-21 15:03 ` [PATCH 2/4] perf, x86: P4 PMU - Don't forget to clear cpuc->active_mask on overflow Don Zickus
2011-04-22 12:19 ` [tip:perf/urgent] " tip-bot for Cyrill Gorcunov
2011-04-21 15:03 ` [PATCH 3/4] perf, nmi: Move LVT un-masking into irq handlers Don Zickus
2011-04-22 8:26 ` Ingo Molnar
2011-04-25 13:39 ` Don Zickus
2011-04-25 14:15 ` Cyrill Gorcunov
[not found] ` <BANLkTi=t7bZ0sFRvUt=a=_54fhXtccPYnQ@mail.gmail.com>
2011-04-25 14:28 ` Cyrill Gorcunov
2011-04-25 14:50 ` Don Zickus
2011-04-25 14:51 ` Cyrill Gorcunov
2011-04-21 15:03 ` [PATCH 4/4] perf, x86: Add PERF_COUNT_HW_NMI_WATCHDOG event Don Zickus
2011-04-22 8:18 ` Ingo Molnar
2011-04-22 8:43 ` Cyrill Gorcunov [this message]
2011-04-22 8:54 ` Peter Zijlstra
2011-04-22 9:24 ` Cyrill Gorcunov
2011-04-22 9:45 ` Peter Zijlstra
2011-04-22 10:02 ` Cyrill Gorcunov
2011-04-22 15:15 ` Cyrill Gorcunov
2011-04-25 13:41 ` Don Zickus
2011-04-25 14:05 ` Cyrill Gorcunov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=BANLkTimh80LorfC8O-HOPAAWK9BLYNjcXA@mail.gmail.com \
--to=gorcunov@gmail.com \
--cc=a.p.zijlstra@chello.nl \
--cc=dzickus@redhat.com \
--cc=gorcunov@openvz.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®