From: Ingo Molnar <mingo@elte.hu>
To: Don Zickus <dzickus@redhat.com>
Cc: x86@kernel.org, LKML <linux-kernel@vger.kernel.org>,
Cyrill Gorcunov <gorcunov@gmail.com>,
Cyrill Gorcunov <gorcunov@openvz.org>
Subject: Re: [PATCH 1/4] perf, x86: P4 PMU -- Use perf_sample_data_init helper
Date: Fri, 22 Apr 2011 10:20:48 +0200 [thread overview]
Message-ID: <20110422082048.GB24011@elte.hu> (raw)
In-Reply-To: <1303398203-2918-2-git-send-email-dzickus@redhat.com>
* Don Zickus <dzickus@redhat.com> wrote:
> From: Cyrill Gorcunov <gorcunov@gmail.com>
>
> Instead of opencoded assignments better to use
> perf_sample_data_init helper.
>
> Tested-by: Lin Ming <ming.m.lin@intel.com>
> Signed-off-by: Cyrill Gorcunov <gorcunov@openvz.org>
> Signed-off-by: Don Zickus <dzickus@redhat.com>
> ---
> arch/x86/kernel/cpu/perf_event_p4.c | 3 +--
> 1 files changed, 1 insertions(+), 2 deletions(-)
>
> diff --git a/arch/x86/kernel/cpu/perf_event_p4.c b/arch/x86/kernel/cpu/perf_event_p4.c
> index c2520e1..6f2bd89 100644
> --- a/arch/x86/kernel/cpu/perf_event_p4.c
> +++ b/arch/x86/kernel/cpu/perf_event_p4.c
> @@ -912,8 +912,7 @@ static int p4_pmu_handle_irq(struct pt_regs *regs)
> int idx, handled = 0;
> u64 val;
>
> - data.addr = 0;
> - data.raw = NULL;
> + perf_sample_data_init(&data, 0);
This one sure can wait for v2.6.40, right?
Thanks,
Ingo
next prev parent reply other threads:[~2011-04-22 8:21 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-04-21 15:03 [PATCH 0/4] perf, x86: collection of pentium 4 fixes Don Zickus
2011-04-21 15:03 ` [PATCH 1/4] perf, x86: P4 PMU -- Use perf_sample_data_init helper Don Zickus
2011-04-22 8:20 ` Ingo Molnar [this message]
2011-04-22 8:35 ` Cyrill Gorcunov
2011-04-22 12:18 ` [tip:perf/core] " tip-bot for Cyrill Gorcunov
2011-04-21 15:03 ` [PATCH 2/4] perf, x86: P4 PMU - Don't forget to clear cpuc->active_mask on overflow Don Zickus
2011-04-22 12:19 ` [tip:perf/urgent] " tip-bot for Cyrill Gorcunov
2011-04-21 15:03 ` [PATCH 3/4] perf, nmi: Move LVT un-masking into irq handlers Don Zickus
2011-04-22 8:26 ` Ingo Molnar
2011-04-25 13:39 ` Don Zickus
2011-04-25 14:15 ` Cyrill Gorcunov
[not found] ` <BANLkTi=t7bZ0sFRvUt=a=_54fhXtccPYnQ@mail.gmail.com>
2011-04-25 14:28 ` Cyrill Gorcunov
2011-04-25 14:50 ` Don Zickus
2011-04-25 14:51 ` Cyrill Gorcunov
2011-04-21 15:03 ` [PATCH 4/4] perf, x86: Add PERF_COUNT_HW_NMI_WATCHDOG event Don Zickus
2011-04-22 8:18 ` Ingo Molnar
2011-04-22 8:43 ` Cyrill Gorcunov
2011-04-22 8:54 ` Peter Zijlstra
2011-04-22 9:24 ` Cyrill Gorcunov
2011-04-22 9:45 ` Peter Zijlstra
2011-04-22 10:02 ` Cyrill Gorcunov
2011-04-22 15:15 ` Cyrill Gorcunov
2011-04-25 13:41 ` Don Zickus
2011-04-25 14:05 ` Cyrill Gorcunov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110422082048.GB24011@elte.hu \
--to=mingo@elte.hu \
--cc=dzickus@redhat.com \
--cc=gorcunov@gmail.com \
--cc=gorcunov@openvz.org \
--cc=linux-kernel@vger.kernel.org \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®