mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: David Jander <david@protonic.nl>
To: Grant Likely <grant.likely@secretlab.ca>
Cc: Thomas Gleixner <tglx@linutronix.de>,
	linux-kernel@vger.kernel.org, David Jander <david@protonic.nl>
Subject: [PATCH v4 0/6] [PATCH v4 0/6] GPIO: pca953x.c: Fix IRQ support and OF device-tree bindings
Date: Wed,  8 Jun 2011 14:48:28 +0200	[thread overview]
Message-ID: <1307537314-4345-1-git-send-email-david@protonic.nl> (raw)

This patch series fixes IRQ support and cleans up OF device-tree support for
the PCA953X gpio driver.
This is version 4 of the patch series, after receiving feedback from
Grant Likely and Thomas Gleixner.

Changes in this version:
 - Call irq_alloc_descs unconditionally to allocate IRQ descriptors.
 - Instead of adding linux,irq-base to OF bindings, remove all of them, since
   they are not needed. IRQ's are allocated dynamically by irq_alloc_descs
   (pdata->irq_base may still be specified by platform setup code, to set a
   base for searching).
 - For CONFIG_OF_GPIO, pdata->irq_base is set to -1 to disable GPIO-interrupt
   support, if the "interrupts" property is not specified in the I2C
   device-node.
 - On suggestion from Grant Likely, changed IRQF_TRIGGER_FALLING to
   IRQF_TRIGGER_LOW to enable the driver to share the physical interrupt line,
   and better reflect the actual working of the pin (active-low interrupt).
 - Split-out the patches a bit more.

David Jander (6):
  GPIO: pca953x.c: Fix IRQ support.
  GPIO: pca953x.c: Set device platform_data pointer after allocating it
  GPIO: pca953x.c: Remove meaningless device-tree bindings
  GPIO: pca953x.c: Interrupt pin is active-low
  GPIO: pca953x.c: Fix warning of enabled interrupts in handler
  GPIO: pca953x.c: Add missing irq_mask_ack handler in struct irq_chip

 drivers/gpio/pca953x.c |   79 +++++++++++++----------------------------------
 1 files changed, 22 insertions(+), 57 deletions(-)

-- 
1.7.4.1


             reply	other threads:[~2011-06-08 13:21 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-06-08 12:48 David Jander [this message]
2011-06-08 12:48 ` [PATCH v4 1/6] GPIO: pca953x.c: Fix IRQ support David Jander
2011-06-08 17:27   ` Grant Likely
2011-06-08 12:48 ` [PATCH v4 2/6] GPIO: pca953x.c: Set device platform_data pointer after allocating it David Jander
2011-06-08 17:30   ` Grant Likely
2011-06-08 12:48 ` [PATCH v4 3/6] GPIO: pca953x.c: Remove meaningless device-tree bindings David Jander
2011-06-08 17:08   ` Grant Likely
2011-06-09  9:05     ` David Jander
2011-06-08 12:48 ` [PATCH v4 4/6] GPIO: pca953x.c: Interrupt pin is active-low David Jander
2011-06-08 17:32   ` Grant Likely
2011-06-08 12:48 ` [PATCH v4 5/6] GPIO: pca953x.c: Fix warning of enabled interrupts in handler David Jander
2011-06-08 17:32   ` Grant Likely
2011-06-08 12:48 ` [PATCH v4 6/6] GPIO: pca953x.c: Add missing irq_mask_ack handler in struct irq_chip David Jander
2011-06-08 17:01   ` Grant Likely

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1307537314-4345-1-git-send-email-david@protonic.nl \
    --to=david@protonic.nl \
    --cc=grant.likely@secretlab.ca \
    --cc=linux-kernel@vger.kernel.org \
    --cc=tglx@linutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®