From: Grant Likely <grant.likely@secretlab.ca>
To: David Jander <david@protonic.nl>
Cc: Thomas Gleixner <tglx@linutronix.de>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v4 5/6] GPIO: pca953x.c: Fix warning of enabled interrupts in handler
Date: Wed, 8 Jun 2011 11:32:53 -0600 [thread overview]
Message-ID: <20110608173253.GM8499@ponder.secretlab.ca> (raw)
In-Reply-To: <1307537314-4345-6-git-send-email-david@protonic.nl>
On Wed, Jun 08, 2011 at 02:48:33PM +0200, David Jander wrote:
> When using nested threaded irqs, use handle_nested_irq(). This function
> does not call the chip handler, so no handler is set.
>
> Signed-off-by: David Jander <david@protonic.nl>
Merged, thanks.
g.
> ---
> drivers/gpio/pca953x.c | 6 +++---
> 1 files changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/gpio/pca953x.c b/drivers/gpio/pca953x.c
> index 97e0d32..dfed81f 100644
> --- a/drivers/gpio/pca953x.c
> +++ b/drivers/gpio/pca953x.c
> @@ -436,7 +436,7 @@ static irqreturn_t pca953x_irq_handler(int irq, void *devid)
>
> do {
> level = __ffs(pending);
> - generic_handle_irq(level + chip->irq_base);
> + handle_nested_irq(level + chip->irq_base);
>
> pending &= ~(1 << level);
> } while (pending);
> @@ -484,8 +484,8 @@ static int pca953x_irq_setup(struct pca953x_chip *chip,
>
> irq_clear_status_flags(irq, IRQ_NOREQUEST);
> irq_set_chip_data(irq, chip);
> - irq_set_chip_and_handler(irq, &pca953x_irq_chip,
> - handle_simple_irq);
> + irq_set_chip(irq, &pca953x_irq_chip);
> + irq_set_nested_thread(irq, true);
> #ifdef CONFIG_ARM
> set_irq_flags(irq, IRQF_VALID);
> #else
> --
> 1.7.4.1
>
next prev parent reply other threads:[~2011-06-08 17:32 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-06-08 12:48 [PATCH v4 0/6] [PATCH v4 0/6] GPIO: pca953x.c: Fix IRQ support and OF device-tree bindings David Jander
2011-06-08 12:48 ` [PATCH v4 1/6] GPIO: pca953x.c: Fix IRQ support David Jander
2011-06-08 17:27 ` Grant Likely
2011-06-08 12:48 ` [PATCH v4 2/6] GPIO: pca953x.c: Set device platform_data pointer after allocating it David Jander
2011-06-08 17:30 ` Grant Likely
2011-06-08 12:48 ` [PATCH v4 3/6] GPIO: pca953x.c: Remove meaningless device-tree bindings David Jander
2011-06-08 17:08 ` Grant Likely
2011-06-09 9:05 ` David Jander
2011-06-08 12:48 ` [PATCH v4 4/6] GPIO: pca953x.c: Interrupt pin is active-low David Jander
2011-06-08 17:32 ` Grant Likely
2011-06-08 12:48 ` [PATCH v4 5/6] GPIO: pca953x.c: Fix warning of enabled interrupts in handler David Jander
2011-06-08 17:32 ` Grant Likely [this message]
2011-06-08 12:48 ` [PATCH v4 6/6] GPIO: pca953x.c: Add missing irq_mask_ack handler in struct irq_chip David Jander
2011-06-08 17:01 ` Grant Likely
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110608173253.GM8499@ponder.secretlab.ca \
--to=grant.likely@secretlab.ca \
--cc=david@protonic.nl \
--cc=linux-kernel@vger.kernel.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®