From: Grant Likely <grant.likely@secretlab.ca>
To: David Jander <david@protonic.nl>
Cc: Thomas Gleixner <tglx@linutronix.de>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v4 6/6] GPIO: pca953x.c: Add missing irq_mask_ack handler in struct irq_chip
Date: Wed, 8 Jun 2011 11:01:39 -0600 [thread overview]
Message-ID: <20110608170139.GH8499@ponder.secretlab.ca> (raw)
In-Reply-To: <1307537314-4345-7-git-send-email-david@protonic.nl>
On Wed, Jun 08, 2011 at 02:48:34PM +0200, David Jander wrote:
> Either .irq_mask_ack or .irq_ack need to be filled in, otherwise in
> kernel/irq/chip.c: mask_ack_irq() a non-initialized handler is called.
>
> Signed-off-by: David Jander <david@protonic.nl>
Does this matter anymore given that the driver no longer sets a handler?
g.
> ---
> drivers/gpio/pca953x.c | 1 +
> 1 files changed, 1 insertions(+), 0 deletions(-)
>
> diff --git a/drivers/gpio/pca953x.c b/drivers/gpio/pca953x.c
> index dfed81f..b476c1c 100644
> --- a/drivers/gpio/pca953x.c
> +++ b/drivers/gpio/pca953x.c
> @@ -379,6 +379,7 @@ static int pca953x_irq_set_type(struct irq_data *d, unsigned int type)
> static struct irq_chip pca953x_irq_chip = {
> .name = "pca953x",
> .irq_mask = pca953x_irq_mask,
> + .irq_mask_ack = pca953x_irq_mask,
> .irq_unmask = pca953x_irq_unmask,
> .irq_bus_lock = pca953x_irq_bus_lock,
> .irq_bus_sync_unlock = pca953x_irq_bus_sync_unlock,
> --
> 1.7.4.1
>
prev parent reply other threads:[~2011-06-08 17:01 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-06-08 12:48 [PATCH v4 0/6] [PATCH v4 0/6] GPIO: pca953x.c: Fix IRQ support and OF device-tree bindings David Jander
2011-06-08 12:48 ` [PATCH v4 1/6] GPIO: pca953x.c: Fix IRQ support David Jander
2011-06-08 17:27 ` Grant Likely
2011-06-08 12:48 ` [PATCH v4 2/6] GPIO: pca953x.c: Set device platform_data pointer after allocating it David Jander
2011-06-08 17:30 ` Grant Likely
2011-06-08 12:48 ` [PATCH v4 3/6] GPIO: pca953x.c: Remove meaningless device-tree bindings David Jander
2011-06-08 17:08 ` Grant Likely
2011-06-09 9:05 ` David Jander
2011-06-08 12:48 ` [PATCH v4 4/6] GPIO: pca953x.c: Interrupt pin is active-low David Jander
2011-06-08 17:32 ` Grant Likely
2011-06-08 12:48 ` [PATCH v4 5/6] GPIO: pca953x.c: Fix warning of enabled interrupts in handler David Jander
2011-06-08 17:32 ` Grant Likely
2011-06-08 12:48 ` [PATCH v4 6/6] GPIO: pca953x.c: Add missing irq_mask_ack handler in struct irq_chip David Jander
2011-06-08 17:01 ` Grant Likely [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110608170139.GH8499@ponder.secretlab.ca \
--to=grant.likely@secretlab.ca \
--cc=david@protonic.nl \
--cc=linux-kernel@vger.kernel.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®