From: David Jander <david@protonic.nl>
To: Grant Likely <grant.likely@secretlab.ca>
Cc: Thomas Gleixner <tglx@linutronix.de>,
linux-kernel@vger.kernel.org, David Jander <david@protonic.nl>
Subject: [PATCH v4 4/6] GPIO: pca953x.c: Interrupt pin is active-low
Date: Wed, 8 Jun 2011 14:48:32 +0200 [thread overview]
Message-ID: <1307537314-4345-5-git-send-email-david@protonic.nl> (raw)
In-Reply-To: <1307537314-4345-1-git-send-email-david@protonic.nl>
The interrupt pin of the PCA953x is active low, and on the rising edge
no interrupt should be produced.
Signed-off-by: David Jander <david@protonic.nl>
---
drivers/gpio/pca953x.c | 3 +--
1 files changed, 1 insertions(+), 2 deletions(-)
diff --git a/drivers/gpio/pca953x.c b/drivers/gpio/pca953x.c
index ae9fe61..97e0d32 100644
--- a/drivers/gpio/pca953x.c
+++ b/drivers/gpio/pca953x.c
@@ -496,8 +496,7 @@ static int pca953x_irq_setup(struct pca953x_chip *chip,
ret = request_threaded_irq(client->irq,
NULL,
pca953x_irq_handler,
- IRQF_TRIGGER_RISING |
- IRQF_TRIGGER_FALLING | IRQF_ONESHOT,
+ IRQF_TRIGGER_LOW | IRQF_ONESHOT,
dev_name(&client->dev), chip);
if (ret) {
dev_err(&client->dev, "failed to request irq %d\n",
--
1.7.4.1
next prev parent reply other threads:[~2011-06-08 13:21 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-06-08 12:48 [PATCH v4 0/6] [PATCH v4 0/6] GPIO: pca953x.c: Fix IRQ support and OF device-tree bindings David Jander
2011-06-08 12:48 ` [PATCH v4 1/6] GPIO: pca953x.c: Fix IRQ support David Jander
2011-06-08 17:27 ` Grant Likely
2011-06-08 12:48 ` [PATCH v4 2/6] GPIO: pca953x.c: Set device platform_data pointer after allocating it David Jander
2011-06-08 17:30 ` Grant Likely
2011-06-08 12:48 ` [PATCH v4 3/6] GPIO: pca953x.c: Remove meaningless device-tree bindings David Jander
2011-06-08 17:08 ` Grant Likely
2011-06-09 9:05 ` David Jander
2011-06-08 12:48 ` David Jander [this message]
2011-06-08 17:32 ` [PATCH v4 4/6] GPIO: pca953x.c: Interrupt pin is active-low Grant Likely
2011-06-08 12:48 ` [PATCH v4 5/6] GPIO: pca953x.c: Fix warning of enabled interrupts in handler David Jander
2011-06-08 17:32 ` Grant Likely
2011-06-08 12:48 ` [PATCH v4 6/6] GPIO: pca953x.c: Add missing irq_mask_ack handler in struct irq_chip David Jander
2011-06-08 17:01 ` Grant Likely
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1307537314-4345-5-git-send-email-david@protonic.nl \
--to=david@protonic.nl \
--cc=grant.likely@secretlab.ca \
--cc=linux-kernel@vger.kernel.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®