From: Jim Cromie <jim.cromie@gmail.com>
To: linux-kernel@vger.kernel.org
Cc: gnb@fmeh.org, jbaron@redhat.com, bvanassche@acm.org,
gregkh@suse.de, Jim Cromie <jim.cromie@gmail.com>
Subject: [PATCH 10/11] dynamic_debug: call apply_pending_queries from ddebug_add_module
Date: Tue, 28 Jun 2011 01:09:51 -0600 [thread overview]
Message-ID: <1309244992-2305-11-git-send-email-jim.cromie@gmail.com> (raw)
In-Reply-To: <1309244992-2305-1-git-send-email-jim.cromie@gmail.com>
When a module is loaded, ddebug_add_module calls apply_pending_queries
to scan pending_queries list and call ddebug_change to apply them.
Matching rules are removed from pending_queries.
With this change, the loaded module's pr_debugs are enabled when
its module_init is invoked, which is not possible otherwize.
With verbose=1, kernel logs look like:
apply_pending_queries: check: pc8736x_gpio <-> q->function="(null)" q->filename="(null)" q->module="pc8736x_gpio" q->format="(null)" q->lineno=0-0 q->flags=0x1 q->mask=0xffffffff
ddebug_change: changed /home/jimc/projects/lx/linux-2.6/drivers/char/pc8736x_gpio.c:342 [pc8736x_gpio]pc8736x_gpio_cleanup p
ddebug_change: changed /home/jimc/projects/lx/linux-2.6/drivers/char/pc8736x_gpio.c:319 [pc8736x_gpio]pc8736x_gpio_init p
...
platform pc8736x_gpio.0: NatSemi pc8736x GPIO Driver Initializing
platform pc8736x_gpio.0: GPIO ioport 6600 reserved
Signed-off-by: Jim Cromie <jim.cromie@gmail.com>
---
lib/dynamic_debug.c | 50 ++++++++++++++++++++++++++++++++++++++++++++++++--
1 files changed, 48 insertions(+), 2 deletions(-)
diff --git a/lib/dynamic_debug.c b/lib/dynamic_debug.c
index 37d0275..252888a 100644
--- a/lib/dynamic_debug.c
+++ b/lib/dynamic_debug.c
@@ -126,8 +126,8 @@ static char *show_ddebug_query(const struct ddebug_query *q)
}
/* copy query off stack, save flags & mask, and store in pending-list */
-static void add_to_pending(const struct ddebug_query *query,
- unsigned int flags, unsigned int mask)
+static void ddebug_add_to_pending(struct ddebug_query *query,
+ unsigned int flags, unsigned int mask)
{
struct pending_query *pq;
@@ -351,6 +351,20 @@ static char *unescape(char *str)
return str;
}
+static char *show_pending_query(struct pending_query *pq)
+{
+ struct ddebug_query *dq = &pq->query;
+ sprintf(prbuf_query,
+ "q->function=\"%s\" q->filename=\"%s\" "
+ "q->module=\"%s\" q->format=\"%s\" q->lineno=%u-%u "
+ "q->flags=0x%x q->mask=0x%x\n",
+ dq->function, dq->filename, dq->module, dq->format,
+ dq->first_lineno, dq->last_lineno,
+ pq->flags, pq->mask);
+
+ return prbuf_query;
+}
+
static inline void check_set(const char **dest, char *src, char *name)
{
if (*dest)
@@ -786,6 +800,35 @@ static const struct file_operations ddebug_proc_fops = {
.write = ddebug_proc_write
};
+/* apply matching queries in pending-queries list */
+static void apply_pending_queries(struct ddebug_table *dt)
+{
+ struct pending_query *pq, *pqnext;
+ int nfound;
+
+ if (verbose)
+ pr_info("pending_ct: %d\n", pending_ct);
+
+ list_for_each_entry_safe(pq, pqnext, &pending_queries, link) {
+
+ if (verbose)
+ pr_info("check: %s <-> %s\n",
+ dt->mod_name, show_pending_query(pq));
+
+ nfound = ddebug_change(&pq->query, pq->flags, pq->mask);
+
+ if (nfound) {
+ mutex_lock(&ddebug_lock);
+ list_del(&pq->link);
+ mutex_unlock(&ddebug_lock);
+ kfree(pq);
+ pending_ct--;
+ }
+ else if (verbose)
+ pr_info("no-match: %s\n", show_pending_query(pq));
+ }
+
+}
/*
* Allocate a new ddebug_table for the given module
* and add it to the global list.
@@ -815,6 +858,9 @@ int ddebug_add_module(struct _ddebug *tab, unsigned int n,
if (verbose)
pr_info("%u debug prints in module %s\n", n, dt->mod_name);
+
+ apply_pending_queries(dt);
+
return 0;
}
EXPORT_SYMBOL_GPL(ddebug_add_module);
--
1.7.4.1
next prev parent reply other threads:[~2011-06-28 7:12 UTC|newest]
Thread overview: 72+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-06-28 7:09 [PATCH 0/11] dynamic_debug: allow multiple pending queries on boot-line Jim Cromie
2011-06-28 7:09 ` [PATCH 01/11] dynamic_debug: allow changing of dynamic_debug verbosity any time Jim Cromie
2011-06-29 10:41 ` Bart Van Assche
2011-07-01 21:57 ` Greg KH
2011-07-02 8:39 ` Jim Cromie
2011-06-28 7:09 ` [PATCH 02/11] dynamic_debug: trim source-path prefix from dynamic_debug/control Jim Cromie
2011-06-28 10:08 ` Bart Van Assche
2011-06-28 18:29 ` Jim Cromie
2011-06-28 7:09 ` [PATCH 03/11] dynamic_debug: process multiple commands on a line Jim Cromie
2011-06-29 10:50 ` Bart Van Assche
2011-07-05 16:12 ` Jim Cromie
2011-06-28 7:09 ` [PATCH 04/11] dynamic_debug: warn when >1 of each type of match-spec is given Jim Cromie
2011-06-28 10:17 ` Bart Van Assche
2011-06-28 15:21 ` Jim Cromie
2011-06-28 7:09 ` [PATCH 05/11] dynamic_debug: use pr_info instead of printk(KERN_INFO Jim Cromie
2011-06-28 7:09 ` [PATCH 06/11] dynamic_debug: KERN_ERR should not depend upon verbosity Jim Cromie
2011-06-28 7:09 ` [PATCH 07/11] dynamic_debug: dont kill entire facility on error parsing ddebug_query Jim Cromie
2011-06-28 7:09 ` [PATCH 08/11] dynamic_debug: return int from ddebug_change Jim Cromie
2011-06-28 10:24 ` Bart Van Assche
2011-06-28 14:54 ` Jason Baron
2011-06-28 17:48 ` Bart Van Assche
2011-06-28 18:24 ` Jim Cromie
2011-06-28 7:09 ` [PATCH 09/11] dynamic_debug: add_to_pending() saves non-matching queries for later Jim Cromie
2011-06-28 14:48 ` Jason Baron
2011-07-03 8:27 ` Bart Van Assche
2011-06-28 19:17 ` Jim Cromie
2011-07-03 8:24 ` Bart Van Assche
2011-07-03 8:32 ` Bart Van Assche
2011-06-28 7:09 ` Jim Cromie [this message]
2011-07-03 8:37 ` [PATCH 10/11] dynamic_debug: call apply_pending_queries from ddebug_add_module Bart Van Assche
2011-06-28 7:09 ` [PATCH 11/11] dynamic_debug: document use of pendinq queries at boot-time Jim Cromie
2011-07-03 8:19 ` [PATCH 0/11] dynamic_debug: allow multiple pending queries on boot-line Bart Van Assche
2011-07-11 7:46 ` Jim Cromie
2011-07-11 7:46 ` [PATCH 01/21] dynamic_debug: add pending flag 'a' to make pending queries explicit Jim Cromie
2011-07-11 7:46 ` [PATCH 02/21] dynamic_debug: allow changing of dynamic_debug verbosity any time Jim Cromie
2011-07-11 7:46 ` [PATCH 03/21] dynamic_debug: process multiple commands on a line Jim Cromie
2011-07-12 5:54 ` Bart Van Assche
2011-07-13 7:25 ` Jim Cromie
2011-07-13 17:44 ` Bart Van Assche
2011-07-11 7:46 ` [PATCH 04/21] dynamic_debug: warn when >1 of each type of match-spec is given Jim Cromie
2011-07-11 7:46 ` [PATCH 05/21] dynamic_debug: pr_err() call should not depend upon verbosity Jim Cromie
2011-07-11 7:46 ` [PATCH 06/21] dynamic_debug: dont kill entire facility on error parsing ddebug_query Jim Cromie
2011-07-11 7:46 ` [PATCH 07/21] dynamic_debug: return int from ddebug_change Jim Cromie
2011-07-11 18:39 ` Bart Van Assche
2011-07-11 7:46 ` [PATCH 08/21] dynamic_debug: factor show_ddebug_query out of ddebug_parse_query Jim Cromie
2011-07-11 18:36 ` Bart Van Assche
2011-07-16 21:32 ` Jim Cromie
2011-07-25 11:10 ` Bart Van Assche
2011-07-25 13:56 ` Jim Cromie
2011-07-11 7:46 ` [PATCH 09/21] dynamic_debug: save_pending() saves non-matching queries for later Jim Cromie
2011-07-11 18:32 ` Bart Van Assche
2011-07-12 5:55 ` Bart Van Assche
2011-07-11 7:46 ` [PATCH 10/21] dynamic_debug: call apply_pending_queries from ddebug_add_module Jim Cromie
2011-07-11 7:46 ` [PATCH 11/21] dynamic_debug: refactor query_matches_callsite out of ddebug_change Jim Cromie
2011-07-11 7:46 ` [PATCH 12/21] dynamic_debug: document use of pending queries at boot-time Jim Cromie
2011-07-11 7:46 ` [PATCH 13/21] dynamic_debug: require 'a' flag to explicitly mark pending queries Jim Cromie
2011-07-12 9:20 ` Bart Van Assche
2011-07-11 7:46 ` [PATCH 14/21] dynamic_debug: hoist locking in ddebug_change to callers Jim Cromie
2011-07-11 7:46 ` [PATCH 15/21] dynamic_debug: describe_flags with '=[ptmfl]*' Jim Cromie
2011-07-11 7:46 ` [PATCH 16/21] dynamic_debug: define several levels of verbosity Jim Cromie
2011-07-11 7:46 ` [PATCH 17/21] dynamic_debug: non-optimization - remove != NULL Jim Cromie
2011-07-11 7:46 ` [PATCH 18/21] dynamic_debug: trim source-path prefix from dynamic_debug/control Jim Cromie
2011-07-11 7:46 ` [PATCH 19/21] dynamic_debug: add flags filtering to flags spec handling Jim Cromie
2011-07-11 7:46 ` [PATCH 20/21] dynamic_debug: clear pending_queries list in remove_all_tables Jim Cromie
2011-07-11 7:46 ` [PATCH 21/21] dynamic_debug: delete pending queries Jim Cromie
2011-07-11 10:49 ` Bart Van Assche
2011-07-11 13:43 ` Jim Cromie
2011-07-12 0:25 ` Joe Perches
2011-07-12 20:50 ` Jason Baron
2011-07-20 5:39 ` Jim Cromie
2011-07-20 17:43 ` Jim Cromie
2011-07-20 22:08 ` Joe Perches
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1309244992-2305-11-git-send-email-jim.cromie@gmail.com \
--to=jim.cromie@gmail.com \
--cc=bvanassche@acm.org \
--cc=gnb@fmeh.org \
--cc=gregkh@suse.de \
--cc=jbaron@redhat.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®