From: Danny Kukawka <danny.kukawka@bisect.de>
To: Henk de Groot <pe1dnn@amsat.org>
Cc: Danny Kukawka <dkukawka@suse.de>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org
Subject: [PATCH 11/11] Staging: wlags49_h2: print MAC via printk format specifier
Date: Fri, 24 Feb 2012 14:46:02 +0100 [thread overview]
Message-ID: <1330091162-8141-12-git-send-email-danny.kukawka@bisect.de> (raw)
In-Reply-To: <1330091162-8141-1-git-send-email-danny.kukawka@bisect.de>
Print MAC/dev_addr via printk extended format specifier %pM
instead of custom code.
Signed-off-by: Danny Kukawka <danny.kukawka@bisect.de>
---
drivers/staging/wlags49_h2/wl_cs.c | 7 ++-----
1 files changed, 2 insertions(+), 5 deletions(-)
diff --git a/drivers/staging/wlags49_h2/wl_cs.c b/drivers/staging/wlags49_h2/wl_cs.c
index 2faee2d..a2cbb29 100644
--- a/drivers/staging/wlags49_h2/wl_cs.c
+++ b/drivers/staging/wlags49_h2/wl_cs.c
@@ -229,7 +229,6 @@ static int wl_adapter_resume(struct pcmcia_device *link)
void wl_adapter_insert(struct pcmcia_device *link)
{
struct net_device *dev;
- int i;
int ret;
/*--------------------------------------------------------------------*/
@@ -266,10 +265,8 @@ void wl_adapter_insert(struct pcmcia_device *link)
register_wlags_sysfs(dev);
- printk(KERN_INFO "%s: Wireless, io_addr %#03lx, irq %d, ""mac_address ",
- dev->name, dev->base_addr, dev->irq);
- for (i = 0; i < ETH_ALEN; i++)
- printk("%02X%c", dev->dev_addr[i], ((i < (ETH_ALEN-1)) ? ':' : '\n'));
+ printk(KERN_INFO "%s: Wireless, io_addr %#03lx, irq %d, mac_address"
+ " %pM\n", dev->name, dev->base_addr, dev->irq, dev->dev_addr);
DBG_LEAVE(DbgInfo);
return;
--
1.7.8.3
next prev parent reply other threads:[~2012-02-24 13:47 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-02-24 13:45 [PATCH 00/11] " Danny Kukawka
2012-02-24 13:45 ` [PATCH 01/11] arch/ia64/hp/sim/simeth.c: " Danny Kukawka
2012-02-24 13:45 ` [PATCH 02/11] amd/hplance.c: " Danny Kukawka
2012-02-24 13:45 ` [PATCH 03/11] cirrus/mac89x0: " Danny Kukawka
2012-02-25 10:15 ` Geert Uytterhoeven
2012-02-28 20:45 ` Geert Uytterhoeven
2012-02-28 20:49 ` David Miller
2012-02-28 21:00 ` Geert Uytterhoeven
2012-02-28 21:06 ` David Miller
2012-02-29 7:22 ` Danny Kukawka
2012-02-24 13:45 ` [PATCH 04/11] dec/tulip/de4x5: " Danny Kukawka
2012-02-24 13:45 ` [PATCH 05/11] ixgbevf: " Danny Kukawka
2012-02-24 13:45 ` [PATCH 06/11] sun/sunqe: " Danny Kukawka
2012-02-24 13:45 ` [PATCH 07/11] xscale/ixp2000/ixpdev: " Danny Kukawka
2012-02-24 14:00 ` Lennert Buytenhek
2012-02-24 13:45 ` [PATCH 08/11] usb/cdc_ncm: " Danny Kukawka
2012-02-24 13:46 ` [PATCH 09/11] usb/kaweth: " Danny Kukawka
2012-02-24 13:56 ` Oliver Neukum
2012-02-24 13:46 ` [PATCH 10/11] Staging: ft1000-pcmcia: " Danny Kukawka
2012-02-24 19:53 ` David Miller
2012-02-25 9:02 ` Danny Kukawka
2012-02-24 13:46 ` Danny Kukawka [this message]
2012-02-24 20:42 ` [PATCH 00/11] " David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1330091162-8141-12-git-send-email-danny.kukawka@bisect.de \
--to=danny.kukawka@bisect.de \
--cc=devel@driverdev.osuosl.org \
--cc=dkukawka@suse.de \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pe1dnn@amsat.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®