From: Danny Kukawka <danny.kukawka@bisect.de>
To: "David S. Miller" <davem@davemloft.net>
Cc: Danny Kukawka <dkukawka@suse.de>,
Jeff Kirsher <jeffrey.t.kirsher@intel.com>,
Jiri Pirko <jpirko@redhat.com>,
Geert Uytterhoeven <geert@linux-m68k.org>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: [PATCH 02/11] amd/hplance.c: print MAC via printk format specifier
Date: Fri, 24 Feb 2012 14:45:53 +0100 [thread overview]
Message-ID: <1330091162-8141-3-git-send-email-danny.kukawka@bisect.de> (raw)
In-Reply-To: <1330091162-8141-1-git-send-email-danny.kukawka@bisect.de>
Print MAC/dev_addr via printk extended format specifier %pM
instead of custom code.
Signed-off-by: Danny Kukawka <danny.kukawka@bisect.de>
---
drivers/net/ethernet/amd/hplance.c | 10 ++--------
1 files changed, 2 insertions(+), 8 deletions(-)
diff --git a/drivers/net/ethernet/amd/hplance.c b/drivers/net/ethernet/amd/hplance.c
index 86aa0d5..40f62e8 100644
--- a/drivers/net/ethernet/amd/hplance.c
+++ b/drivers/net/ethernet/amd/hplance.c
@@ -89,7 +89,6 @@ static int __devinit hplance_init_one(struct dio_dev *d,
{
struct net_device *dev;
int err = -ENOMEM;
- int i;
dev = alloc_etherdev(sizeof(struct hplance_private));
if (!dev)
@@ -107,13 +106,8 @@ static int __devinit hplance_init_one(struct dio_dev *d,
dio_set_drvdata(d, dev);
- printk(KERN_INFO "%s: %s; select code %d, addr %2.2x", dev->name, d->name, d->scode, dev->dev_addr[0]);
-
- for (i=1; i<6; i++) {
- printk(":%2.2x", dev->dev_addr[i]);
- }
-
- printk(", irq %d\n", d->ipl);
+ printk(KERN_INFO "%s: %s; select code %d, addr %pM, irq %d\n",
+ dev->name, d->name, d->scode, dev->dev_addr, d->ipl);
return 0;
--
1.7.8.3
next prev parent reply other threads:[~2012-02-24 13:47 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-02-24 13:45 [PATCH 00/11] " Danny Kukawka
2012-02-24 13:45 ` [PATCH 01/11] arch/ia64/hp/sim/simeth.c: " Danny Kukawka
2012-02-24 13:45 ` Danny Kukawka [this message]
2012-02-24 13:45 ` [PATCH 03/11] cirrus/mac89x0: " Danny Kukawka
2012-02-25 10:15 ` Geert Uytterhoeven
2012-02-28 20:45 ` Geert Uytterhoeven
2012-02-28 20:49 ` David Miller
2012-02-28 21:00 ` Geert Uytterhoeven
2012-02-28 21:06 ` David Miller
2012-02-29 7:22 ` Danny Kukawka
2012-02-24 13:45 ` [PATCH 04/11] dec/tulip/de4x5: " Danny Kukawka
2012-02-24 13:45 ` [PATCH 05/11] ixgbevf: " Danny Kukawka
2012-02-24 13:45 ` [PATCH 06/11] sun/sunqe: " Danny Kukawka
2012-02-24 13:45 ` [PATCH 07/11] xscale/ixp2000/ixpdev: " Danny Kukawka
2012-02-24 14:00 ` Lennert Buytenhek
2012-02-24 13:45 ` [PATCH 08/11] usb/cdc_ncm: " Danny Kukawka
2012-02-24 13:46 ` [PATCH 09/11] usb/kaweth: " Danny Kukawka
2012-02-24 13:56 ` Oliver Neukum
2012-02-24 13:46 ` [PATCH 10/11] Staging: ft1000-pcmcia: " Danny Kukawka
2012-02-24 19:53 ` David Miller
2012-02-25 9:02 ` Danny Kukawka
2012-02-24 13:46 ` [PATCH 11/11] Staging: wlags49_h2: " Danny Kukawka
2012-02-24 20:42 ` [PATCH 00/11] " David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1330091162-8141-3-git-send-email-danny.kukawka@bisect.de \
--to=danny.kukawka@bisect.de \
--cc=davem@davemloft.net \
--cc=dkukawka@suse.de \
--cc=geert@linux-m68k.org \
--cc=jeffrey.t.kirsher@intel.com \
--cc=jpirko@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®