mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Danny Kukawka <danny.kukawka@bisect.de>
To: Tony Luck <tony.luck@intel.com>, Fenghua Yu <fenghua.yu@intel.com>
Cc: Danny Kukawka <dkukawka@suse.de>,
	"David S. Miller" <davem@davemloft.net>,
	Jiri Pirko <jpirko@redhat.com>,
	linux-ia64@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: [PATCH 01/11] arch/ia64/hp/sim/simeth.c: print MAC via printk format specifier
Date: Fri, 24 Feb 2012 14:45:52 +0100	[thread overview]
Message-ID: <1330091162-8141-2-git-send-email-danny.kukawka@bisect.de> (raw)
In-Reply-To: <1330091162-8141-1-git-send-email-danny.kukawka@bisect.de>

Print MAC/dev_addr via printk extended format specifier %pm
instead of custom code.

Signed-off-by: Danny Kukawka <danny.kukawka@bisect.de>
---
 arch/ia64/hp/sim/simeth.c |   10 +++-------
 1 files changed, 3 insertions(+), 7 deletions(-)

diff --git a/arch/ia64/hp/sim/simeth.c b/arch/ia64/hp/sim/simeth.c
index 47afcc6..440001e 100644
--- a/arch/ia64/hp/sim/simeth.c
+++ b/arch/ia64/hp/sim/simeth.c
@@ -193,7 +193,7 @@ simeth_probe1(void)
 	unsigned char mac_addr[ETH_ALEN];
 	struct simeth_local *local;
 	struct net_device *dev;
-	int fd, i, err, rc;
+	int fd, err, rc;
 
 	/*
 	 * XXX Fix me
@@ -236,12 +236,8 @@ simeth_probe1(void)
 	 */
 	netdev_connect(dev->irq);
 
-	printk(KERN_INFO "%s: hosteth=%s simfd=%d, HwAddr",
-	       dev->name, simeth_device, local->simfd);
-	for(i = 0; i < ETH_ALEN; i++) {
-		printk(" %2.2x", dev->dev_addr[i]);
-	}
-	printk(", IRQ %d\n", dev->irq);
+	printk(KERN_INFO "%s: hosteth=%s simfd=%d, HwAddr=%pm, IRQ %d\n",
+	       dev->name, simeth_device, local->simfd, dev->dev_addr, dev->irq);
 
 	return 0;
 }
-- 
1.7.8.3


  reply	other threads:[~2012-02-24 13:48 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-02-24 13:45 [PATCH 00/11] " Danny Kukawka
2012-02-24 13:45 ` Danny Kukawka [this message]
2012-02-24 13:45 ` [PATCH 02/11] amd/hplance.c: " Danny Kukawka
2012-02-24 13:45 ` [PATCH 03/11] cirrus/mac89x0: " Danny Kukawka
2012-02-25 10:15   ` Geert Uytterhoeven
2012-02-28 20:45     ` Geert Uytterhoeven
2012-02-28 20:49       ` David Miller
2012-02-28 21:00         ` Geert Uytterhoeven
2012-02-28 21:06           ` David Miller
2012-02-29  7:22           ` Danny Kukawka
2012-02-24 13:45 ` [PATCH 04/11] dec/tulip/de4x5: " Danny Kukawka
2012-02-24 13:45 ` [PATCH 05/11] ixgbevf: " Danny Kukawka
2012-02-24 13:45 ` [PATCH 06/11] sun/sunqe: " Danny Kukawka
2012-02-24 13:45 ` [PATCH 07/11] xscale/ixp2000/ixpdev: " Danny Kukawka
2012-02-24 14:00   ` Lennert Buytenhek
2012-02-24 13:45 ` [PATCH 08/11] usb/cdc_ncm: " Danny Kukawka
2012-02-24 13:46 ` [PATCH 09/11] usb/kaweth: " Danny Kukawka
2012-02-24 13:56   ` Oliver Neukum
2012-02-24 13:46 ` [PATCH 10/11] Staging: ft1000-pcmcia: " Danny Kukawka
2012-02-24 19:53   ` David Miller
2012-02-25  9:02     ` Danny Kukawka
2012-02-24 13:46 ` [PATCH 11/11] Staging: wlags49_h2: " Danny Kukawka
2012-02-24 20:42 ` [PATCH 00/11] " David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1330091162-8141-2-git-send-email-danny.kukawka@bisect.de \
    --to=danny.kukawka@bisect.de \
    --cc=davem@davemloft.net \
    --cc=dkukawka@suse.de \
    --cc=fenghua.yu@intel.com \
    --cc=jpirko@redhat.com \
    --cc=linux-ia64@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=tony.luck@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®