mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: David Miller <davem@davemloft.net>
To: geert@linux-m68k.org
Cc: danny.kukawka@bisect.de, dkukawka@suse.de,
	jeffrey.t.kirsher@intel.com, jpirko@redhat.com,
	netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 03/11] cirrus/mac89x0: print MAC via printk format specifier
Date: Tue, 28 Feb 2012 15:49:14 -0500 (EST)	[thread overview]
Message-ID: <20120228.154914.662485432055205683.davem@davemloft.net> (raw)
In-Reply-To: <CAMuHMdW0Oh7h8tv85ScgHB50vMaZSU7S3cPJRsChnRe2sNL_kA@mail.gmail.com>

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1: Type: Text/Plain; charset=iso-8859-7, Size: 1962 bytes --]

From: Geert Uytterhoeven <geert@linux-m68k.org>
Date: Tue, 28 Feb 2012 21:45:30 +0100

> drivers/net/ethernet/cirrus/mac89x0.c: In function ¡set_mac_address¢:
> drivers/net/ethernet/cirrus/mac89x0.c:597: warning: dereferencing
> ¡void *¢ pointer
> drivers/net/ethernet/cirrus/mac89x0.c:597: error: request for member
> ¡sa_data¢ in something not a structure or union
> drivers/net/ethernet/cirrus/mac89x0.c:600: warning: dereferencing
> ¡void *¢ pointer
> drivers/net/ethernet/cirrus/mac89x0.c:600: error: request for member
> ¡sa_data¢ in something not a structure or union
> drivers/net/ethernet/cirrus/mac89x0.c:595: warning: unused variable ¡saddr¢

Thanks, I've fixed this as follows and pushed to net-next:

--------------------
mac89x0: Fix build error.

Need to use the new 'saddr' variable not the void 'addr' in
set_mac_address().

Reported-by: Geert Uytterhoeven <geert@linux-m68k.org>
Signed-off-by: David S. Miller <davem@davemloft.net>
---
 drivers/net/ethernet/cirrus/mac89x0.c |    6 +++---
 1 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/drivers/net/ethernet/cirrus/mac89x0.c b/drivers/net/ethernet/cirrus/mac89x0.c
index 419825c..932fdcc 100644
--- a/drivers/net/ethernet/cirrus/mac89x0.c
+++ b/drivers/net/ethernet/cirrus/mac89x0.c
@@ -591,13 +591,13 @@ static void set_multicast_list(struct net_device *dev)
 
 static int set_mac_address(struct net_device *dev, void *addr)
 {
-	int i;
 	struct sockaddr *saddr = addr;
+	int i;
 
-	if (!is_valid_ether_addr(addr->sa_data))
+	if (!is_valid_ether_addr(saddr->sa_data))
 		return -EADDRNOTAVAIL;
 
-	memcpy(dev->dev_addr, addr->sa_data, ETH_ALEN);
+	memcpy(dev->dev_addr, saddr->sa_data, ETH_ALEN);
 	printk("%s: Setting MAC address to %pM\n", dev->name, dev->dev_addr);
 
 	/* set the Ethernet address */
-- 
1.7.7.6

ÿôèº{.nÇ+‰·Ÿ®‰­†+%ŠËÿ±éݶ\x17¥Šwÿº{.nÇ+‰·¥Š{±þG«éÿŠ{ayº\x1dʇڙë,j\a­¢f£¢·hšïêÿ‘êçz_è®\x03(­éšŽŠÝ¢j"ú\x1a¶^[m§ÿÿ¾\a«þG«éÿ¢¸?™¨è­Ú&£ø§~á¶iO•æ¬z·švØ^\x14\x04\x1a¶^[m§ÿÿÃ\fÿ¶ìÿ¢¸?–I¥

  reply	other threads:[~2012-02-28 20:52 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-02-24 13:45 [PATCH 00/11] " Danny Kukawka
2012-02-24 13:45 ` [PATCH 01/11] arch/ia64/hp/sim/simeth.c: " Danny Kukawka
2012-02-24 13:45 ` [PATCH 02/11] amd/hplance.c: " Danny Kukawka
2012-02-24 13:45 ` [PATCH 03/11] cirrus/mac89x0: " Danny Kukawka
2012-02-25 10:15   ` Geert Uytterhoeven
2012-02-28 20:45     ` Geert Uytterhoeven
2012-02-28 20:49       ` David Miller [this message]
2012-02-28 21:00         ` Geert Uytterhoeven
2012-02-28 21:06           ` David Miller
2012-02-29  7:22           ` Danny Kukawka
2012-02-24 13:45 ` [PATCH 04/11] dec/tulip/de4x5: " Danny Kukawka
2012-02-24 13:45 ` [PATCH 05/11] ixgbevf: " Danny Kukawka
2012-02-24 13:45 ` [PATCH 06/11] sun/sunqe: " Danny Kukawka
2012-02-24 13:45 ` [PATCH 07/11] xscale/ixp2000/ixpdev: " Danny Kukawka
2012-02-24 14:00   ` Lennert Buytenhek
2012-02-24 13:45 ` [PATCH 08/11] usb/cdc_ncm: " Danny Kukawka
2012-02-24 13:46 ` [PATCH 09/11] usb/kaweth: " Danny Kukawka
2012-02-24 13:56   ` Oliver Neukum
2012-02-24 13:46 ` [PATCH 10/11] Staging: ft1000-pcmcia: " Danny Kukawka
2012-02-24 19:53   ` David Miller
2012-02-25  9:02     ` Danny Kukawka
2012-02-24 13:46 ` [PATCH 11/11] Staging: wlags49_h2: " Danny Kukawka
2012-02-24 20:42 ` [PATCH 00/11] " David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120228.154914.662485432055205683.davem@davemloft.net \
    --to=davem@davemloft.net \
    --cc=danny.kukawka@bisect.de \
    --cc=dkukawka@suse.de \
    --cc=geert@linux-m68k.org \
    --cc=jeffrey.t.kirsher@intel.com \
    --cc=jpirko@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®