[PATCH] ramster: depend on CONFIG_NET for sock_* functions

[PATCH] ramster: depend on CONFIG_NET for sock_* functions

[Sasha Levin]

Building ramster without CONFIG_NET would cause linkage issue due to missing
sock_*() functions in cluster/tcp.c

Signed-off-by: Sasha Levin <levinsasha928@gmail.com>
---
 drivers/staging/ramster/Kconfig |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/drivers/staging/ramster/Kconfig b/drivers/staging/ramster/Kconfig
index 4af1f8d..8e334cb 100644
--- a/drivers/staging/ramster/Kconfig
+++ b/drivers/staging/ramster/Kconfig
@@ -1,6 +1,6 @@
 config RAMSTER
 	bool "Cross-machine RAM capacity sharing, aka peer-to-peer tmem"
-	depends on (CLEANCACHE || FRONTSWAP) && CONFIGFS_FS=y && !ZCACHE && !XVMALLOC && !HIGHMEM
+	depends on (CLEANCACHE || FRONTSWAP) && CONFIGFS_FS=y && !ZCACHE && !XVMALLOC && !HIGHMEM && CONFIG_NET
 	select LZO_COMPRESS
 	select LZO_DECOMPRESS
 	default n
-- 
1.7.8.5

Re: [PATCH] ramster: depend on CONFIG_NET for sock_* functions

[Paul Bolle]

On Mon, 2012-05-07 at 10:02 +0200, Sasha Levin wrote:
> Building ramster without CONFIG_NET would cause linkage issue due to missing

I'd say s/CONFIG_NET/NET/ 

> sock_*() functions in cluster/tcp.c
> 
> Signed-off-by: Sasha Levin <levinsasha928@gmail.com>
> ---
>  drivers/staging/ramster/Kconfig |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/drivers/staging/ramster/Kconfig b/drivers/staging/ramster/Kconfig
> index 4af1f8d..8e334cb 100644
> --- a/drivers/staging/ramster/Kconfig
> +++ b/drivers/staging/ramster/Kconfig
> @@ -1,6 +1,6 @@
>  config RAMSTER
>  	bool "Cross-machine RAM capacity sharing, aka peer-to-peer tmem"
> -	depends on (CLEANCACHE || FRONTSWAP) && CONFIGFS_FS=y && !ZCACHE && !XVMALLOC && !HIGHMEM
> +	depends on (CLEANCACHE || FRONTSWAP) && CONFIGFS_FS=y && !ZCACHE && !XVMALLOC && !HIGHMEM && CONFIG_NET

s/CONFIG_NET/NET/ again, I'd say. How was this tested?

>  	select LZO_COMPRESS
>  	select LZO_DECOMPRESS
>  	default n


Paul Bolle

Re: [PATCH] ramster: depend on CONFIG_NET for sock_* functions

[Sasha Levin]

On Mon, May 7, 2012 at 10:10 AM, Paul Bolle <pebolle@tiscali.nl> wrote:
> On Mon, 2012-05-07 at 10:02 +0200, Sasha Levin wrote:
>> Building ramster without CONFIG_NET would cause linkage issue due to missing
>
> I'd say s/CONFIG_NET/NET/
>
>> sock_*() functions in cluster/tcp.c
>>
>> Signed-off-by: Sasha Levin <levinsasha928@gmail.com>
>> ---
>>  drivers/staging/ramster/Kconfig |    2 +-
>>  1 files changed, 1 insertions(+), 1 deletions(-)
>>
>> diff --git a/drivers/staging/ramster/Kconfig b/drivers/staging/ramster/Kconfig
>> index 4af1f8d..8e334cb 100644
>> --- a/drivers/staging/ramster/Kconfig
>> +++ b/drivers/staging/ramster/Kconfig
>> @@ -1,6 +1,6 @@
>>  config RAMSTER
>>       bool "Cross-machine RAM capacity sharing, aka peer-to-peer tmem"
>> -     depends on (CLEANCACHE || FRONTSWAP) && CONFIGFS_FS=y && !ZCACHE && !XVMALLOC && !HIGHMEM
>> +     depends on (CLEANCACHE || FRONTSWAP) && CONFIGFS_FS=y && !ZCACHE && !XVMALLOC && !HIGHMEM && CONFIG_NET
>
> s/CONFIG_NET/NET/ again, I'd say. How was this tested?

Hm... ran the build again with the patch and noticed it stopped
complaining, but apparently it wasn't enough.

Re: [PATCH] ramster: depend on CONFIG_NET for sock_* functions

[Paul Bolle]

On Mon, 2012-05-07 at 10:29 +0200, Sasha Levin wrote:
> On Mon, May 7, 2012 at 10:10 AM, Paul Bolle <pebolle@tiscali.nl> wrote:
> > On Mon, 2012-05-07 at 10:02 +0200, Sasha Levin wrote:
> >> --- a/drivers/staging/ramster/Kconfig
> >> +++ b/drivers/staging/ramster/Kconfig
> >> @@ -1,6 +1,6 @@
> >>  config RAMSTER
> >>       bool "Cross-machine RAM capacity sharing, aka peer-to-peer tmem"
> >> -     depends on (CLEANCACHE || FRONTSWAP) && CONFIGFS_FS=y && !ZCACHE && !XVMALLOC && !HIGHMEM
> >> +     depends on (CLEANCACHE || FRONTSWAP) && CONFIGFS_FS=y && !ZCACHE && !XVMALLOC && !HIGHMEM && CONFIG_NET
> >
> > s/CONFIG_NET/NET/ again, I'd say. How was this tested?
> 
> Hm... ran the build again with the patch and noticed it stopped
> complaining, but apparently it wasn't enough.

Well, my guess is that the errors you ran into weren't displayed because
a dependency on an undefined Kconfig symbol (like CONFIG_NET is) will
always fail. Ie, your patch made "RAM capacity sharing" simply disappear
from the build.


Paul Bolle

Re: [PATCH] ramster: depend on CONFIG_NET for sock_* functions

[Sasha Levin]

On Mon, May 7, 2012 at 10:43 AM, Paul Bolle <pebolle@tiscali.nl> wrote:
> On Mon, 2012-05-07 at 10:29 +0200, Sasha Levin wrote:
>> On Mon, May 7, 2012 at 10:10 AM, Paul Bolle <pebolle@tiscali.nl> wrote:
>> > On Mon, 2012-05-07 at 10:02 +0200, Sasha Levin wrote:
>> >> --- a/drivers/staging/ramster/Kconfig
>> >> +++ b/drivers/staging/ramster/Kconfig
>> >> @@ -1,6 +1,6 @@
>> >>  config RAMSTER
>> >>       bool "Cross-machine RAM capacity sharing, aka peer-to-peer tmem"
>> >> -     depends on (CLEANCACHE || FRONTSWAP) && CONFIGFS_FS=y && !ZCACHE && !XVMALLOC && !HIGHMEM
>> >> +     depends on (CLEANCACHE || FRONTSWAP) && CONFIGFS_FS=y && !ZCACHE && !XVMALLOC && !HIGHMEM && CONFIG_NET
>> >
>> > s/CONFIG_NET/NET/ again, I'd say. How was this tested?
>>
>> Hm... ran the build again with the patch and noticed it stopped
>> complaining, but apparently it wasn't enough.
>
> Well, my guess is that the errors you ran into weren't displayed because
> a dependency on an undefined Kconfig symbol (like CONFIG_NET is) will
> always fail. Ie, your patch made "RAM capacity sharing" simply disappear
> from the build.

Yup, which is not what I meant to do :)

Sorry about that.