* [PATCH] ramster: depend on CONFIG_NET for sock_* functions
@ 2012-05-07 8:02 Sasha Levin
2012-05-07 8:10 ` Paul Bolle
0 siblings, 1 reply; 5+ messages in thread
From: Sasha Levin @ 2012-05-07 8:02 UTC (permalink / raw)
To: gregkh, dan.magenheimer, sjenning; +Cc: linux-kernel, Sasha Levin
Building ramster without CONFIG_NET would cause linkage issue due to missing
sock_*() functions in cluster/tcp.c
Signed-off-by: Sasha Levin <levinsasha928@gmail.com>
---
drivers/staging/ramster/Kconfig | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/staging/ramster/Kconfig b/drivers/staging/ramster/Kconfig
index 4af1f8d..8e334cb 100644
--- a/drivers/staging/ramster/Kconfig
+++ b/drivers/staging/ramster/Kconfig
@@ -1,6 +1,6 @@
config RAMSTER
bool "Cross-machine RAM capacity sharing, aka peer-to-peer tmem"
- depends on (CLEANCACHE || FRONTSWAP) && CONFIGFS_FS=y && !ZCACHE && !XVMALLOC && !HIGHMEM
+ depends on (CLEANCACHE || FRONTSWAP) && CONFIGFS_FS=y && !ZCACHE && !XVMALLOC && !HIGHMEM && CONFIG_NET
select LZO_COMPRESS
select LZO_DECOMPRESS
default n
--
1.7.8.5
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] ramster: depend on CONFIG_NET for sock_* functions
2012-05-07 8:02 [PATCH] ramster: depend on CONFIG_NET for sock_* functions Sasha Levin
@ 2012-05-07 8:10 ` Paul Bolle
2012-05-07 8:29 ` Sasha Levin
0 siblings, 1 reply; 5+ messages in thread
From: Paul Bolle @ 2012-05-07 8:10 UTC (permalink / raw)
To: Sasha Levin; +Cc: gregkh, dan.magenheimer, sjenning, linux-kernel
On Mon, 2012-05-07 at 10:02 +0200, Sasha Levin wrote:
> Building ramster without CONFIG_NET would cause linkage issue due to missing
I'd say s/CONFIG_NET/NET/
> sock_*() functions in cluster/tcp.c
>
> Signed-off-by: Sasha Levin <levinsasha928@gmail.com>
> ---
> drivers/staging/ramster/Kconfig | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/staging/ramster/Kconfig b/drivers/staging/ramster/Kconfig
> index 4af1f8d..8e334cb 100644
> --- a/drivers/staging/ramster/Kconfig
> +++ b/drivers/staging/ramster/Kconfig
> @@ -1,6 +1,6 @@
> config RAMSTER
> bool "Cross-machine RAM capacity sharing, aka peer-to-peer tmem"
> - depends on (CLEANCACHE || FRONTSWAP) && CONFIGFS_FS=y && !ZCACHE && !XVMALLOC && !HIGHMEM
> + depends on (CLEANCACHE || FRONTSWAP) && CONFIGFS_FS=y && !ZCACHE && !XVMALLOC && !HIGHMEM && CONFIG_NET
s/CONFIG_NET/NET/ again, I'd say. How was this tested?
> select LZO_COMPRESS
> select LZO_DECOMPRESS
> default n
Paul Bolle
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] ramster: depend on CONFIG_NET for sock_* functions
2012-05-07 8:10 ` Paul Bolle
@ 2012-05-07 8:29 ` Sasha Levin
2012-05-07 8:43 ` Paul Bolle
0 siblings, 1 reply; 5+ messages in thread
From: Sasha Levin @ 2012-05-07 8:29 UTC (permalink / raw)
To: Paul Bolle; +Cc: gregkh, dan.magenheimer, sjenning, linux-kernel
On Mon, May 7, 2012 at 10:10 AM, Paul Bolle <pebolle@tiscali.nl> wrote:
> On Mon, 2012-05-07 at 10:02 +0200, Sasha Levin wrote:
>> Building ramster without CONFIG_NET would cause linkage issue due to missing
>
> I'd say s/CONFIG_NET/NET/
>
>> sock_*() functions in cluster/tcp.c
>>
>> Signed-off-by: Sasha Levin <levinsasha928@gmail.com>
>> ---
>> drivers/staging/ramster/Kconfig | 2 +-
>> 1 files changed, 1 insertions(+), 1 deletions(-)
>>
>> diff --git a/drivers/staging/ramster/Kconfig b/drivers/staging/ramster/Kconfig
>> index 4af1f8d..8e334cb 100644
>> --- a/drivers/staging/ramster/Kconfig
>> +++ b/drivers/staging/ramster/Kconfig
>> @@ -1,6 +1,6 @@
>> config RAMSTER
>> bool "Cross-machine RAM capacity sharing, aka peer-to-peer tmem"
>> - depends on (CLEANCACHE || FRONTSWAP) && CONFIGFS_FS=y && !ZCACHE && !XVMALLOC && !HIGHMEM
>> + depends on (CLEANCACHE || FRONTSWAP) && CONFIGFS_FS=y && !ZCACHE && !XVMALLOC && !HIGHMEM && CONFIG_NET
>
> s/CONFIG_NET/NET/ again, I'd say. How was this tested?
Hm... ran the build again with the patch and noticed it stopped
complaining, but apparently it wasn't enough.
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] ramster: depend on CONFIG_NET for sock_* functions
2012-05-07 8:29 ` Sasha Levin
@ 2012-05-07 8:43 ` Paul Bolle
2012-05-07 8:47 ` Sasha Levin
0 siblings, 1 reply; 5+ messages in thread
From: Paul Bolle @ 2012-05-07 8:43 UTC (permalink / raw)
To: Sasha Levin; +Cc: gregkh, dan.magenheimer, sjenning, linux-kernel
On Mon, 2012-05-07 at 10:29 +0200, Sasha Levin wrote:
> On Mon, May 7, 2012 at 10:10 AM, Paul Bolle <pebolle@tiscali.nl> wrote:
> > On Mon, 2012-05-07 at 10:02 +0200, Sasha Levin wrote:
> >> --- a/drivers/staging/ramster/Kconfig
> >> +++ b/drivers/staging/ramster/Kconfig
> >> @@ -1,6 +1,6 @@
> >> config RAMSTER
> >> bool "Cross-machine RAM capacity sharing, aka peer-to-peer tmem"
> >> - depends on (CLEANCACHE || FRONTSWAP) && CONFIGFS_FS=y && !ZCACHE && !XVMALLOC && !HIGHMEM
> >> + depends on (CLEANCACHE || FRONTSWAP) && CONFIGFS_FS=y && !ZCACHE && !XVMALLOC && !HIGHMEM && CONFIG_NET
> >
> > s/CONFIG_NET/NET/ again, I'd say. How was this tested?
>
> Hm... ran the build again with the patch and noticed it stopped
> complaining, but apparently it wasn't enough.
Well, my guess is that the errors you ran into weren't displayed because
a dependency on an undefined Kconfig symbol (like CONFIG_NET is) will
always fail. Ie, your patch made "RAM capacity sharing" simply disappear
from the build.
Paul Bolle
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] ramster: depend on CONFIG_NET for sock_* functions
2012-05-07 8:43 ` Paul Bolle
@ 2012-05-07 8:47 ` Sasha Levin
0 siblings, 0 replies; 5+ messages in thread
From: Sasha Levin @ 2012-05-07 8:47 UTC (permalink / raw)
To: Paul Bolle; +Cc: gregkh, dan.magenheimer, sjenning, linux-kernel
On Mon, May 7, 2012 at 10:43 AM, Paul Bolle <pebolle@tiscali.nl> wrote:
> On Mon, 2012-05-07 at 10:29 +0200, Sasha Levin wrote:
>> On Mon, May 7, 2012 at 10:10 AM, Paul Bolle <pebolle@tiscali.nl> wrote:
>> > On Mon, 2012-05-07 at 10:02 +0200, Sasha Levin wrote:
>> >> --- a/drivers/staging/ramster/Kconfig
>> >> +++ b/drivers/staging/ramster/Kconfig
>> >> @@ -1,6 +1,6 @@
>> >> config RAMSTER
>> >> bool "Cross-machine RAM capacity sharing, aka peer-to-peer tmem"
>> >> - depends on (CLEANCACHE || FRONTSWAP) && CONFIGFS_FS=y && !ZCACHE && !XVMALLOC && !HIGHMEM
>> >> + depends on (CLEANCACHE || FRONTSWAP) && CONFIGFS_FS=y && !ZCACHE && !XVMALLOC && !HIGHMEM && CONFIG_NET
>> >
>> > s/CONFIG_NET/NET/ again, I'd say. How was this tested?
>>
>> Hm... ran the build again with the patch and noticed it stopped
>> complaining, but apparently it wasn't enough.
>
> Well, my guess is that the errors you ran into weren't displayed because
> a dependency on an undefined Kconfig symbol (like CONFIG_NET is) will
> always fail. Ie, your patch made "RAM capacity sharing" simply disappear
> from the build.
Yup, which is not what I meant to do :)
Sorry about that.
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2012-05-07 8:48 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2012-05-07 8:02 [PATCH] ramster: depend on CONFIG_NET for sock_* functions Sasha Levin
2012-05-07 8:10 ` Paul Bolle
2012-05-07 8:29 ` Sasha Levin
2012-05-07 8:43 ` Paul Bolle
2012-05-07 8:47 ` Sasha Levin
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®