* [PATCH] ALSA: ali5451: remove irq enabling in pointer callback
@ 2013-02-11 15:49 Denis Efremov
2013-02-11 16:06 ` Takashi Iwai
0 siblings, 1 reply; 2+ messages in thread
From: Denis Efremov @ 2013-02-11 15:49 UTC (permalink / raw)
To: Takashi Iwai; +Cc: Denis Efremov, Bill Pemberton, linux-kernel
snd_ali_pointer function is called with local
interrupts disabled. However it seems very strange to
reenable them in such way.
Found by Linux Driver Verification project (linuxtesting.org).
Signed-off-by: Denis Efremov <yefremov.denis@gmail.com>
---
sound/pci/ali5451/ali5451.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/sound/pci/ali5451/ali5451.c b/sound/pci/ali5451/ali5451.c
index 136a393..e760af9 100644
--- a/sound/pci/ali5451/ali5451.c
+++ b/sound/pci/ali5451/ali5451.c
@@ -1435,7 +1435,7 @@ static snd_pcm_uframes_t snd_ali_pointer(struct snd_pcm_substream *substream)
spin_lock(&codec->reg_lock);
if (!pvoice->running) {
- spin_unlock_irq(&codec->reg_lock);
+ spin_unlock(&codec->reg_lock);
return 0;
}
outb(pvoice->number, ALI_REG(codec, ALI_GC_CIR));
--
1.8.1.2
^ permalink raw reply [flat|nested] 2+ messages in thread* Re: [PATCH] ALSA: ali5451: remove irq enabling in pointer callback
2013-02-11 15:49 [PATCH] ALSA: ali5451: remove irq enabling in pointer callback Denis Efremov
@ 2013-02-11 16:06 ` Takashi Iwai
0 siblings, 0 replies; 2+ messages in thread
From: Takashi Iwai @ 2013-02-11 16:06 UTC (permalink / raw)
To: Denis Efremov; +Cc: Bill Pemberton, linux-kernel
At Mon, 11 Feb 2013 19:49:48 +0400,
Denis Efremov wrote:
>
> snd_ali_pointer function is called with local
> interrupts disabled. However it seems very strange to
> reenable them in such way.
>
> Found by Linux Driver Verification project (linuxtesting.org).
>
> Signed-off-by: Denis Efremov <yefremov.denis@gmail.com>
Thanks, applied now.
Takashi
> ---
> sound/pci/ali5451/ali5451.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/sound/pci/ali5451/ali5451.c b/sound/pci/ali5451/ali5451.c
> index 136a393..e760af9 100644
> --- a/sound/pci/ali5451/ali5451.c
> +++ b/sound/pci/ali5451/ali5451.c
> @@ -1435,7 +1435,7 @@ static snd_pcm_uframes_t snd_ali_pointer(struct snd_pcm_substream *substream)
>
> spin_lock(&codec->reg_lock);
> if (!pvoice->running) {
> - spin_unlock_irq(&codec->reg_lock);
> + spin_unlock(&codec->reg_lock);
> return 0;
> }
> outb(pvoice->number, ALI_REG(codec, ALI_GC_CIR));
> --
> 1.8.1.2
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2013-02-11 16:06 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2013-02-11 15:49 [PATCH] ALSA: ali5451: remove irq enabling in pointer callback Denis Efremov
2013-02-11 16:06 ` Takashi Iwai
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®