From: Namhyung Kim <namhyung@kernel.org>
To: Arnaldo Carvalho de Melo <acme@ghostprotocols.net>
Cc: Peter Zijlstra <a.p.zijlstra@chello.nl>,
Paul Mackerras <paulus@samba.org>, Ingo Molnar <mingo@kernel.org>,
Namhyung Kim <namhyung.kim@lge.com>,
LKML <linux-kernel@vger.kernel.org>, Arun Sharma <asharma@fb.com>,
Frederic Weisbecker <fweisbec@gmail.com>,
Jiri Olsa <jolsa@redhat.com>,
Rodrigo Campos <rodrigo@sdfg.com.ar>
Subject: [PATCH 18/21] perf top: Support callchain accumulation
Date: Tue, 24 Dec 2013 17:22:24 +0900 [thread overview]
Message-ID: <1387873347-28838-19-git-send-email-namhyung@kernel.org> (raw)
In-Reply-To: <1387873347-28838-1-git-send-email-namhyung@kernel.org>
From: Namhyung Kim <namhyung.kim@lge.com>
Enable cumulation of callchain of children in perf top.
Cc: Arun Sharma <asharma@fb.com>
Cc: Frederic Weisbecker <fweisbec@gmail.com>
Signed-off-by: Namhyung Kim <namhyung@kernel.org>
---
tools/perf/builtin-top.c | 106 +++++++++++++++++++++++++++++++++++++++++++++--
1 file changed, 103 insertions(+), 3 deletions(-)
diff --git a/tools/perf/builtin-top.c b/tools/perf/builtin-top.c
index 48c527a0f4c8..6a7a76496c94 100644
--- a/tools/perf/builtin-top.c
+++ b/tools/perf/builtin-top.c
@@ -657,6 +657,99 @@ static int symbol_filter(struct map *map __maybe_unused, struct symbol *sym)
return 0;
}
+static int process_cumulative_entry(struct perf_top *top,
+ struct hist_entry *he,
+ struct perf_evsel *evsel,
+ struct addr_location *al,
+ struct perf_sample *sample,
+ struct symbol *parent)
+{
+ struct hist_entry **he_cache;
+ struct callchain_cursor_node *node;
+ int idx = 0, err;
+
+ he_cache = malloc(sizeof(*he_cache) * (PERF_MAX_STACK_DEPTH + 1));
+ if (he_cache == NULL)
+ return -ENOMEM;
+
+ pthread_mutex_lock(&evsel->hists.lock);
+
+ he_cache[idx++] = he;
+
+ /*
+ * This is for putting parents upward during output resort iff
+ * only a child gets sampled. See hist_entry__sort_on_period().
+ */
+ he->callchain->max_depth = PERF_MAX_STACK_DEPTH + 1;
+
+ callchain_cursor_commit(&callchain_cursor);
+
+ node = callchain_cursor_current(&callchain_cursor);
+ while (node) {
+ int i;
+ struct hist_entry he_tmp = {
+ .cpu = al->cpu,
+ .thread = al->thread,
+ .comm = thread__comm(al->thread),
+ .parent = parent,
+ };
+
+ fill_callchain_info(al, node, false);
+
+ he_tmp.ip = al->addr;
+ he_tmp.ms.map = al->map;
+ he_tmp.ms.sym = al->sym;
+
+ if (al->sym && al->sym->ignore)
+ goto next;
+
+ /*
+ * Check if there's duplicate entries in the callchain.
+ * It's possible that it has cycles or recursive calls.
+ */
+ for (i = 0; i < idx; i++) {
+ if (hist_entry__cmp(he_cache[i], &he_tmp) == 0)
+ goto next;
+ }
+
+ he = __hists__add_entry(&evsel->hists, al, parent, NULL, NULL,
+ sample->period, sample->weight,
+ sample->transaction, false);
+ if (he == NULL) {
+ err = -ENOMEM;
+ break;;
+ }
+
+ he_cache[idx++] = he;
+
+ /*
+ * This is for putting parents upward during output resort iff
+ * only a child gets sampled. See hist_entry__sort_on_period().
+ */
+ he->callchain->max_depth = callchain_cursor.nr - callchain_cursor.pos;
+
+ if (sort__has_sym) {
+ u64 ip;
+
+ if (al->map)
+ ip = al->map->unmap_ip(al->map, al->addr);
+ else
+ ip = al->addr;
+
+ perf_top__record_precise_ip(top, he, evsel->idx, ip);
+ }
+
+next:
+ callchain_cursor_advance(&callchain_cursor);
+ node = callchain_cursor_current(&callchain_cursor);
+ }
+
+ pthread_mutex_unlock(&evsel->hists.lock);
+
+ free(he_cache);
+ return err;
+}
+
static void perf_event__process_sample(struct perf_tool *tool,
const union perf_event *event,
struct perf_evsel *evsel,
@@ -754,9 +847,16 @@ static void perf_event__process_sample(struct perf_tool *tool,
return;
}
- err = hist_entry__append_callchain(he, sample);
- if (err)
- return;
+ if (symbol_conf.cumulate_callchain) {
+ err = process_cumulative_entry(top, he, evsel, &al,
+ sample, parent);
+ if (err)
+ return;
+ } else {
+ err = hist_entry__append_callchain(he, sample);
+ if (err)
+ return;
+ }
if (sort__has_sym)
perf_top__record_precise_ip(top, he, evsel->idx, ip);
--
1.7.11.7
next prev parent reply other threads:[~2013-12-24 8:24 UTC|newest]
Thread overview: 53+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-24 8:22 [PATCHSET 00/21] perf tools: Add support to accumulate hist periods (v4) Namhyung Kim
2013-12-24 8:22 ` [PATCH 01/21] perf tools: Introduce struct add_entry_iter Namhyung Kim
2014-01-05 14:55 ` Jiri Olsa
2014-01-06 7:45 ` Namhyung Kim
2014-01-05 15:28 ` Jiri Olsa
2014-01-06 7:45 ` Namhyung Kim
2014-01-05 15:55 ` Jiri Olsa
2014-01-06 8:03 ` Namhyung Kim
2014-01-06 14:32 ` Jiri Olsa
2013-12-24 8:22 ` [PATCH 02/21] perf hists: Convert hist entry functions to use struct he_stat Namhyung Kim
2014-01-05 16:09 ` Jiri Olsa
2013-12-24 8:22 ` [PATCH 03/21] perf hists: Add support for accumulated stat of hist entry Namhyung Kim
2014-01-05 16:16 ` Jiri Olsa
2014-01-05 16:26 ` Jiri Olsa
2014-01-06 8:09 ` Namhyung Kim
2014-01-05 16:45 ` Jiri Olsa
2014-01-06 8:10 ` Namhyung Kim
2013-12-24 8:22 ` [PATCH 04/21] perf hists: Check if accumulated when adding a " Namhyung Kim
2013-12-24 8:22 ` [PATCH 05/21] perf hists: Accumulate hist entry stat based on the callchain Namhyung Kim
2014-01-05 16:58 ` Jiri Olsa
2014-01-05 17:15 ` Jiri Olsa
2014-01-06 8:17 ` Namhyung Kim
2013-12-24 8:22 ` [PATCH 06/21] perf tools: Update cpumode for each cumulative entry Namhyung Kim
2014-01-05 17:02 ` Jiri Olsa
2014-01-06 8:18 ` Namhyung Kim
2013-12-24 8:22 ` [PATCH 07/21] perf report: Cache cumulative callchains Namhyung Kim
2014-01-05 17:10 ` Jiri Olsa
2013-12-24 8:22 ` [PATCH 08/21] perf hists: Sort hist entries by accumulated period Namhyung Kim
2013-12-24 8:22 ` [PATCH 09/21] perf ui/hist: Add support to accumulated hist stat Namhyung Kim
2014-01-05 17:31 ` Jiri Olsa
2014-01-06 8:32 ` Namhyung Kim
2014-01-06 14:30 ` Jiri Olsa
2013-12-24 8:22 ` [PATCH 10/21] perf ui/browser: " Namhyung Kim
2014-01-05 17:33 ` Jiri Olsa
2013-12-24 8:22 ` [PATCH 11/21] perf ui/gtk: " Namhyung Kim
2014-01-05 17:35 ` Jiri Olsa
2013-12-24 8:22 ` [PATCH 12/21] perf tools: Apply percent-limit to cumulative percentage Namhyung Kim
2014-01-05 17:40 ` Jiri Olsa
2014-01-06 8:33 ` Namhyung Kim
2013-12-24 8:22 ` [PATCH 13/21] perf tools: Add more hpp helper functions Namhyung Kim
2013-12-24 8:22 ` [PATCH 14/21] perf report: Add --children option Namhyung Kim
2013-12-24 8:22 ` [PATCH 15/21] perf report: Add report.children config option Namhyung Kim
2013-12-24 8:22 ` [PATCH 16/21] perf tools: Factor out sample__resolve_callchain() Namhyung Kim
2014-01-05 17:56 ` Jiri Olsa
2013-12-24 8:22 ` [PATCH 17/21] perf tools: Factor out fill_callchain_info() Namhyung Kim
2013-12-24 8:22 ` Namhyung Kim [this message]
2014-01-05 18:01 ` [PATCH 18/21] perf top: Support callchain accumulation Jiri Olsa
2014-01-06 8:34 ` Namhyung Kim
2013-12-24 8:22 ` [PATCH 19/21] perf top: Add --children option Namhyung Kim
2013-12-24 8:22 ` [PATCH 20/21] perf top: Add top.children config option Namhyung Kim
2013-12-24 8:22 ` [PATCH 21/21] perf tools: Enable --children option by default Namhyung Kim
2014-01-05 18:08 ` Jiri Olsa
2014-01-06 8:47 ` Namhyung Kim
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1387873347-28838-19-git-send-email-namhyung@kernel.org \
--to=namhyung@kernel.org \
--cc=a.p.zijlstra@chello.nl \
--cc=acme@ghostprotocols.net \
--cc=asharma@fb.com \
--cc=fweisbec@gmail.com \
--cc=jolsa@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=namhyung.kim@lge.com \
--cc=paulus@samba.org \
--cc=rodrigo@sdfg.com.ar \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®