From: Namhyung Kim <namhyung@kernel.org>
To: Jiri Olsa <jolsa@redhat.com>
Cc: Arnaldo Carvalho de Melo <acme@ghostprotocols.net>,
Peter Zijlstra <a.p.zijlstra@chello.nl>,
Paul Mackerras <paulus@samba.org>, Ingo Molnar <mingo@kernel.org>,
Namhyung Kim <namhyung.kim@lge.com>,
LKML <linux-kernel@vger.kernel.org>, Arun Sharma <asharma@fb.com>,
Frederic Weisbecker <fweisbec@gmail.com>,
Rodrigo Campos <rodrigo@sdfg.com.ar>,
Stephane Eranian <eranian@google.com>
Subject: Re: [PATCH 01/21] perf tools: Introduce struct add_entry_iter
Date: Mon, 06 Jan 2014 16:45:39 +0900 [thread overview]
Message-ID: <87sit1eeos.fsf@sejong.aot.lge.com> (raw)
In-Reply-To: <20140105152815.GA8720@krava.brq.redhat.com> (Jiri Olsa's message of "Sun, 5 Jan 2014 16:28:15 +0100")
On Sun, 5 Jan 2014 16:28:15 +0100, Jiri Olsa wrote:
> On Tue, Dec 24, 2013 at 05:22:07PM +0900, Namhyung Kim wrote:
>> From: Namhyung Kim <namhyung.kim@lge.com>
>> + iter->rep = rep;
>> + ret = perf_evsel__add_entry(evsel, &al, sample, machine, iter);
>
> you dont need to pass machine pointer, it's already in 'al'
Right.
Thanks,
Namhyung
next prev parent reply other threads:[~2014-01-06 7:45 UTC|newest]
Thread overview: 53+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-24 8:22 [PATCHSET 00/21] perf tools: Add support to accumulate hist periods (v4) Namhyung Kim
2013-12-24 8:22 ` [PATCH 01/21] perf tools: Introduce struct add_entry_iter Namhyung Kim
2014-01-05 14:55 ` Jiri Olsa
2014-01-06 7:45 ` Namhyung Kim
2014-01-05 15:28 ` Jiri Olsa
2014-01-06 7:45 ` Namhyung Kim [this message]
2014-01-05 15:55 ` Jiri Olsa
2014-01-06 8:03 ` Namhyung Kim
2014-01-06 14:32 ` Jiri Olsa
2013-12-24 8:22 ` [PATCH 02/21] perf hists: Convert hist entry functions to use struct he_stat Namhyung Kim
2014-01-05 16:09 ` Jiri Olsa
2013-12-24 8:22 ` [PATCH 03/21] perf hists: Add support for accumulated stat of hist entry Namhyung Kim
2014-01-05 16:16 ` Jiri Olsa
2014-01-05 16:26 ` Jiri Olsa
2014-01-06 8:09 ` Namhyung Kim
2014-01-05 16:45 ` Jiri Olsa
2014-01-06 8:10 ` Namhyung Kim
2013-12-24 8:22 ` [PATCH 04/21] perf hists: Check if accumulated when adding a " Namhyung Kim
2013-12-24 8:22 ` [PATCH 05/21] perf hists: Accumulate hist entry stat based on the callchain Namhyung Kim
2014-01-05 16:58 ` Jiri Olsa
2014-01-05 17:15 ` Jiri Olsa
2014-01-06 8:17 ` Namhyung Kim
2013-12-24 8:22 ` [PATCH 06/21] perf tools: Update cpumode for each cumulative entry Namhyung Kim
2014-01-05 17:02 ` Jiri Olsa
2014-01-06 8:18 ` Namhyung Kim
2013-12-24 8:22 ` [PATCH 07/21] perf report: Cache cumulative callchains Namhyung Kim
2014-01-05 17:10 ` Jiri Olsa
2013-12-24 8:22 ` [PATCH 08/21] perf hists: Sort hist entries by accumulated period Namhyung Kim
2013-12-24 8:22 ` [PATCH 09/21] perf ui/hist: Add support to accumulated hist stat Namhyung Kim
2014-01-05 17:31 ` Jiri Olsa
2014-01-06 8:32 ` Namhyung Kim
2014-01-06 14:30 ` Jiri Olsa
2013-12-24 8:22 ` [PATCH 10/21] perf ui/browser: " Namhyung Kim
2014-01-05 17:33 ` Jiri Olsa
2013-12-24 8:22 ` [PATCH 11/21] perf ui/gtk: " Namhyung Kim
2014-01-05 17:35 ` Jiri Olsa
2013-12-24 8:22 ` [PATCH 12/21] perf tools: Apply percent-limit to cumulative percentage Namhyung Kim
2014-01-05 17:40 ` Jiri Olsa
2014-01-06 8:33 ` Namhyung Kim
2013-12-24 8:22 ` [PATCH 13/21] perf tools: Add more hpp helper functions Namhyung Kim
2013-12-24 8:22 ` [PATCH 14/21] perf report: Add --children option Namhyung Kim
2013-12-24 8:22 ` [PATCH 15/21] perf report: Add report.children config option Namhyung Kim
2013-12-24 8:22 ` [PATCH 16/21] perf tools: Factor out sample__resolve_callchain() Namhyung Kim
2014-01-05 17:56 ` Jiri Olsa
2013-12-24 8:22 ` [PATCH 17/21] perf tools: Factor out fill_callchain_info() Namhyung Kim
2013-12-24 8:22 ` [PATCH 18/21] perf top: Support callchain accumulation Namhyung Kim
2014-01-05 18:01 ` Jiri Olsa
2014-01-06 8:34 ` Namhyung Kim
2013-12-24 8:22 ` [PATCH 19/21] perf top: Add --children option Namhyung Kim
2013-12-24 8:22 ` [PATCH 20/21] perf top: Add top.children config option Namhyung Kim
2013-12-24 8:22 ` [PATCH 21/21] perf tools: Enable --children option by default Namhyung Kim
2014-01-05 18:08 ` Jiri Olsa
2014-01-06 8:47 ` Namhyung Kim
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87sit1eeos.fsf@sejong.aot.lge.com \
--to=namhyung@kernel.org \
--cc=a.p.zijlstra@chello.nl \
--cc=acme@ghostprotocols.net \
--cc=asharma@fb.com \
--cc=eranian@google.com \
--cc=fweisbec@gmail.com \
--cc=jolsa@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=namhyung.kim@lge.com \
--cc=paulus@samba.org \
--cc=rodrigo@sdfg.com.ar \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome