Re: [PATCH 06/21] perf tools: Update cpumode for each cumulative entry

[Namhyung Kim <namhyung@kernel.org>]

On Sun, 5 Jan 2014 18:02:19 +0100, Jiri Olsa wrote:
> On Tue, Dec 24, 2013 at 05:22:12PM +0900, Namhyung Kim wrote:
[SNIP]

>> @@ -100,6 +100,7 @@ struct add_entry_iter {
>>  	struct report *rep;
>>  	struct perf_evsel *evsel;
>>  	struct perf_sample *sample;
>> +	struct machine *machine;
>>  	struct hist_entry *he;
>>  	struct symbol *parent;
>>  	void *priv;
>> @@ -362,7 +363,7 @@ iter_finish_normal_entry(struct add_entry_iter *iter, struct addr_location *al)
>>  
>>  static int
>>  iter_prepare_cumulative_entry(struct add_entry_iter *iter,
>> -			      struct machine *machine __maybe_unused,
>> +			      struct machine *machine,
>>  			      struct perf_evsel *evsel,
>>  			      struct addr_location *al __maybe_unused,
>>  			      struct perf_sample *sample)
>> @@ -371,6 +372,7 @@ iter_prepare_cumulative_entry(struct add_entry_iter *iter,
>>  
>>  	iter->evsel = evsel;
>>  	iter->sample = sample;
>> +	iter->machine = machine;
>
> machine is already in 'al->machine'

Okay, will remove ->machine in the iter.

Thanks,
Namhyung