[PATCH] staging: binder: fix coding style issues

[PATCH] staging: binder: fix coding style issues

[Dmitry Voytik]

Fix coding style issues:
* put braces in all if-else branches;
* limit the length of changed lines to 80 columns.
checkpatch.pl warning count reduces by 3.

Signed-off-by: Dmitry Voytik <voytikd@gmail.com>
---
 drivers/staging/android/binder.c | 16 ++++++++++------
 1 file changed, 10 insertions(+), 6 deletions(-)

diff --git a/drivers/staging/android/binder.c b/drivers/staging/android/binder.c
index 4f34dc0..b7d6b3a 100644
--- a/drivers/staging/android/binder.c
+++ b/drivers/staging/android/binder.c
@@ -2198,12 +2198,16 @@ retry:
 		struct binder_work *w;
 		struct binder_transaction *t = NULL;
 
-		if (!list_empty(&thread->todo))
-			w = list_first_entry(&thread->todo, struct binder_work, entry);
-		else if (!list_empty(&proc->todo) && wait_for_proc_work)
-			w = list_first_entry(&proc->todo, struct binder_work, entry);
-		else {
-			if (ptr - buffer == 4 && !(thread->looper & BINDER_LOOPER_STATE_NEED_RETURN)) /* no data added */
+		if (!list_empty(&thread->todo)) {
+			w = list_first_entry(&thread->todo, struct binder_work,
+						entry);
+		} else if (!list_empty(&proc->todo) && wait_for_proc_work) {
+			w = list_first_entry(&proc->todo, struct binder_work,
+						entry);
+		} else {
+			/* no data added */
+			if (ptr - buffer == 4 && !(thread->looper &
+					BINDER_LOOPER_STATE_NEED_RETURN))
 				goto retry;
 			break;
 		}
-- 
1.9.1

Re: [PATCH] staging: binder: fix coding style issues

[Joe Perches]

On Mon, 2014-09-08 at 17:37 +0400, Dmitry Voytik wrote:
> Fix coding style issues:
> * put braces in all if-else branches;
> * limit the length of changed lines to 80 columns.
> checkpatch.pl warning count reduces by 3.
[]
> diff --git a/drivers/staging/android/binder.c b/drivers/staging/android/binder.c
[]
> @@ -2198,12 +2198,16 @@ retry:
>  		struct binder_work *w;
>  		struct binder_transaction *t = NULL;
>  
> -		if (!list_empty(&thread->todo))
> -			w = list_first_entry(&thread->todo, struct binder_work, entry);
> -		else if (!list_empty(&proc->todo) && wait_for_proc_work)
> -			w = list_first_entry(&proc->todo, struct binder_work, entry);
> -		else {
> -			if (ptr - buffer == 4 && !(thread->looper & BINDER_LOOPER_STATE_NEED_RETURN)) /* no data added */
> +		if (!list_empty(&thread->todo)) {
> +			w = list_first_entry(&thread->todo, struct binder_work,
> +						entry);
> +		} else if (!list_empty(&proc->todo) && wait_for_proc_work) {
> +			w = list_first_entry(&proc->todo, struct binder_work,
> +						entry);

Please indent multi line statements to the
appropriate open parenthesis using maximal
initial tabs and few spaces as required.

Here it would use 5 tabs, then 6 spaces.

			w =  list_first_entry(&proc->todo, struct binder_work,
					      entry);
> +		} else {
> +			/* no data added */
> +			if (ptr - buffer == 4 && !(thread->looper &
> +					BINDER_LOOPER_STATE_NEED_RETURN))

better as
			if (ptr - buffer == 4 &&
			    !(thread->looper & BINDER_LOOPER_STATE_NEED_RETURN))

[PATCH] staging: binder: fix coding style issues

[Dmitry Voytik]

Fix coding style issues:
* put braces in all if-else branches;
* limit the length of changed lines to 80 columns.
checkpatch.pl warning count reduces by 3.

Signed-off-by: Dmitry Voytik <voytikd@gmail.com>
Reviewed-by: Joe Perches <joe@perches.com>
---
 drivers/staging/android/binder.c | 16 ++++++++++------
 1 file changed, 10 insertions(+), 6 deletions(-)

diff --git a/drivers/staging/android/binder.c b/drivers/staging/android/binder.c
index 4f34dc0..4f1a6f7 100644
--- a/drivers/staging/android/binder.c
+++ b/drivers/staging/android/binder.c
@@ -2198,12 +2198,16 @@ retry:
 		struct binder_work *w;
 		struct binder_transaction *t = NULL;
 
-		if (!list_empty(&thread->todo))
-			w = list_first_entry(&thread->todo, struct binder_work, entry);
-		else if (!list_empty(&proc->todo) && wait_for_proc_work)
-			w = list_first_entry(&proc->todo, struct binder_work, entry);
-		else {
-			if (ptr - buffer == 4 && !(thread->looper & BINDER_LOOPER_STATE_NEED_RETURN)) /* no data added */
+		if (!list_empty(&thread->todo)) {
+			w = list_first_entry(&thread->todo, struct binder_work,
+					     entry);
+		} else if (!list_empty(&proc->todo) && wait_for_proc_work) {
+			w = list_first_entry(&proc->todo, struct binder_work,
+					     entry);
+		} else {
+			/* no data added */
+			if (ptr - buffer == 4 &&
+			    !(thread->looper & BINDER_LOOPER_STATE_NEED_RETURN))
 				goto retry;
 			break;
 		}
-- 
1.9.1

Re: [PATCH] staging: binder: fix coding style issues

[Joe Perches]

On Mon, 2014-09-08 at 18:16 +0400, Dmitry Voytik wrote:
> Fix coding style issues:
> * put braces in all if-else branches;
> * limit the length of changed lines to 80 columns.
> checkpatch.pl warning count reduces by 3.
> 
> Signed-off-by: Dmitry Voytik <voytikd@gmail.com>
> Reviewed-by: Joe Perches <joe@perches.com>

Hi Dmitry.

I don't see any defect in your patch now but here's
a bit of trivia for you.

I didn't sign anything here.

Please don't add signatures from another person unless
or until specifically written by that other person.

cheers, Joe

Re: [PATCH] staging: binder: fix coding style issues

[Dmitry Voytik]

On Mon, Sep 8, 2014 at 7:41 PM, Joe Perches <joe@perches.com> wrote:
> On Mon, 2014-09-08 at 18:16 +0400, Dmitry Voytik wrote:
>> Fix coding style issues:
>> * put braces in all if-else branches;
>> * limit the length of changed lines to 80 columns.
>> checkpatch.pl warning count reduces by 3.
>>
>> Signed-off-by: Dmitry Voytik <voytikd@gmail.com>
>> Reviewed-by: Joe Perches <joe@perches.com>
>
> Hi Dmitry.
>
> I don't see any defect in your patch now but here's
> a bit of trivia for you.
>
> I didn't sign anything here.
>
> Please don't add signatures from another person unless
> or until specifically written by that other person.

Oops. Sorry about that.
Thank you for the review and guiding!


> cheers, Joe
>



-- 
Best Regards,
Dmitry Voytik.
voytikd@gmail.com