mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Kishon Vijay Abraham I <kishon@ti.com>
To: <gregkh@linuxfoundation.org>
Cc: <kishon@ti.com>, <linux-kernel@vger.kernel.org>
Subject: [PATCH 04/25] phy: miphy28lp: Add SSC support for SATA
Date: Thu, 27 Nov 2014 11:55:56 +0530	[thread overview]
Message-ID: <1417069577-1169-5-git-send-email-kishon@ti.com> (raw)
In-Reply-To: <1417069577-1169-1-git-send-email-kishon@ti.com>

From: Gabriel FERNANDEZ <gabriel.fernandez@st.com>

This patch to tune on/off the ssc on miphy sata setup.
User can now enable ssc via dt blob, it is useful to reduce
effects of EMI.

Signed-off-by: Giuseppe Condorelli <giuseppe.condorelli@st.com>
Signed-off-by: Gabriel Fernandez <gabriel.fernandez@linaro.org>
Signed-off-by: Kishon Vijay Abraham I <kishon@ti.com>
---
 .../devicetree/bindings/phy/phy-miphy28lp.txt      |    1 +
 drivers/phy/phy-miphy28lp.c                        |   46 ++++++++++++++++++++
 2 files changed, 47 insertions(+)

diff --git a/Documentation/devicetree/bindings/phy/phy-miphy28lp.txt b/Documentation/devicetree/bindings/phy/phy-miphy28lp.txt
index b7c13ad..4a3b4af 100644
--- a/Documentation/devicetree/bindings/phy/phy-miphy28lp.txt
+++ b/Documentation/devicetree/bindings/phy/phy-miphy28lp.txt
@@ -39,6 +39,7 @@ Optional properties (port (child) node):
 			  register.
 - st,px_rx_pol_inv	: to invert polarity of RXn/RXp (respectively negative line and positive
 			  line).
+- st,scc-on		: enable ssc to reduce effects of EMI (only for sata or PCIe).
 
 example:
 
diff --git a/drivers/phy/phy-miphy28lp.c b/drivers/phy/phy-miphy28lp.c
index 7d592e6..d2f797c 100644
--- a/drivers/phy/phy-miphy28lp.c
+++ b/drivers/phy/phy-miphy28lp.c
@@ -191,6 +191,8 @@
 #define SYSCFG_PCIE_PCIE_VAL	0x80
 #define SATA_SPDMODE		1
 
+#define MIPHY_SATA_BANK_NB	3
+
 struct miphy28lp_phy {
 	struct phy *phy;
 	struct miphy28lp_dev *phydev;
@@ -200,6 +202,7 @@ struct miphy28lp_phy {
 	bool osc_force_ext;
 	bool osc_rdy;
 	bool px_rx_pol_inv;
+	bool ssc;
 
 	struct reset_control *miphy_rst;
 
@@ -550,6 +553,44 @@ static inline void miphy28_usb3_miphy_reset(struct miphy28lp_phy *miphy_phy)
 	writeb_relaxed(0x00, base + MIPHY_CONF);
 }
 
+static void miphy_sata_tune_ssc(struct miphy28lp_phy *miphy_phy)
+{
+	void __iomem *base = miphy_phy->base;
+	u8 val;
+
+	/* Compensate Tx impedance to avoid out of range values */
+	/*
+	 * Enable the SSC on PLL for all banks
+	 * SSC Modulation @ 31 KHz and 4000 ppm modulation amp
+	 */
+	val = readb_relaxed(base + MIPHY_BOUNDARY_2);
+	val |= SSC_EN_SW;
+	writeb_relaxed(val, base + MIPHY_BOUNDARY_2);
+
+	val = readb_relaxed(base + MIPHY_BOUNDARY_SEL);
+	val |= SSC_SEL;
+	writeb_relaxed(val, base + MIPHY_BOUNDARY_SEL);
+
+	for (val = 0; val < MIPHY_SATA_BANK_NB; val++) {
+		writeb_relaxed(val, base + MIPHY_CONF);
+
+		/* Add value to each reference clock cycle  */
+		/* and define the period length of the SSC */
+		writeb_relaxed(0x3c, base + MIPHY_PLL_SBR_2);
+		writeb_relaxed(0x6c, base + MIPHY_PLL_SBR_3);
+		writeb_relaxed(0x81, base + MIPHY_PLL_SBR_4);
+
+		/* Clear any previous request */
+		writeb_relaxed(0x00, base + MIPHY_PLL_SBR_1);
+
+		/* requests the PLL to take in account new parameters */
+		writeb_relaxed(SET_NEW_CHANGE, base + MIPHY_PLL_SBR_1);
+
+		/* To be sure there is no other pending requests */
+		writeb_relaxed(0x00, base + MIPHY_PLL_SBR_1);
+	}
+}
+
 static inline int miphy28lp_configure_sata(struct miphy28lp_phy *miphy_phy)
 {
 	void __iomem *base = miphy_phy->base;
@@ -585,6 +626,9 @@ static inline int miphy28lp_configure_sata(struct miphy28lp_phy *miphy_phy)
 		writeb_relaxed(val, miphy_phy->base + MIPHY_CONTROL);
 	}
 
+	if (miphy_phy->ssc)
+		miphy_sata_tune_ssc(miphy_phy);
+
 	return 0;
 }
 
@@ -1064,6 +1108,8 @@ static int miphy28lp_of_probe(struct device_node *np,
 	miphy_phy->px_rx_pol_inv =
 		of_property_read_bool(np, "st,px_rx_pol_inv");
 
+	miphy_phy->ssc = of_property_read_bool(np, "st,ssc-on");
+
 	of_property_read_u32(np, "st,sata-gen", &miphy_phy->sata_gen);
 	if (!miphy_phy->sata_gen)
 		miphy_phy->sata_gen = SATA_GEN1;
-- 
1.7.9.5


  parent reply	other threads:[~2014-11-27  6:33 UTC|newest]

Thread overview: 28+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-11-27  6:25 [GIT PULL 00/25] phy: for 3.19 Kishon Vijay Abraham I
2014-11-27  6:25 ` [PATCH 01/25] phy: Add PHY header file for DT x Driver defines Kishon Vijay Abraham I
2014-11-27  6:25 ` [PATCH 02/25] phy: miphy28lp: Add Device Tree bindings for the MiPHY28lp Kishon Vijay Abraham I
2014-11-27  6:25 ` [PATCH 03/25] phy: miphy28lp: Provide support for the MiPHY28lp Generic PHY Kishon Vijay Abraham I
2014-11-27  7:00   ` sanjeev sharma
2014-11-27  6:25 ` Kishon Vijay Abraham I [this message]
2014-11-27  6:25 ` [PATCH 05/25] phy: miphy28lp: Add SSC support for PCIE Kishon Vijay Abraham I
2014-11-27  6:25 ` [PATCH 06/25] phy: miphy28lp: Tune tx impedance across Soc cuts Kishon Vijay Abraham I
2014-11-27  6:25 ` [PATCH 07/25] phy: phy-core: use the np present in of_phandle_args to get the PHY Kishon Vijay Abraham I
2014-11-27  6:26 ` [PATCH 08/25] phy: sun4i: add support for USB phy0 Kishon Vijay Abraham I
2014-11-27  6:26 ` [PATCH 09/25] phy: berlin-sata: Move PHY_BASE into private data struct Kishon Vijay Abraham I
2014-11-27  6:26 ` [PATCH 10/25] phy: berlin-sata: Add support for BG2 SATA PHY Kishon Vijay Abraham I
2014-11-27  6:26 ` [PATCH 11/25] phy: berlin-sata: Document BG2 compatible Kishon Vijay Abraham I
2014-11-27  6:26 ` [PATCH 12/25] phy: add the Berlin USB PHY driver Kishon Vijay Abraham I
2014-11-27  6:26 ` [PATCH 13/25] Documentation: bindings: add doc for the Berlin USB PHY Kishon Vijay Abraham I
2014-11-27  6:26 ` [PATCH 14/25] phy: safer to_phy() macro Kishon Vijay Abraham I
2014-11-27  6:26 ` [PATCH 15/25] phy: improved lookup method Kishon Vijay Abraham I
2014-11-27  6:26 ` [PATCH 16/25] phy: twl4030: use the new " Kishon Vijay Abraham I
2014-11-27  6:26 ` [PATCH 17/25] phy: remove the old " Kishon Vijay Abraham I
2014-11-27  6:26 ` [PATCH 18/25] usb: dwc3: host: convey the PHYs to xhci Kishon Vijay Abraham I
2014-11-27  6:26 ` [PATCH 19/25] phy: exynos5-usbdrd: Add pipe-clk, utmi-clk and itp-clk support Kishon Vijay Abraham I
2014-11-27  6:26 ` [PATCH 20/25] phy: exynos5-usbdrd: Add facility for VBUS-BOOST-5V supply Kishon Vijay Abraham I
2014-11-27  6:26 ` [PATCH 21/25] phy: exynos7-usbdrd: Update dependency for ARCH_EXYNOS Kishon Vijay Abraham I
2014-11-27  6:26 ` [PATCH 22/25] phy: Use PTR_ERR_OR_ZERO to fix warning raised by coccinelle Kishon Vijay Abraham I
2014-11-27  6:26 ` [PATCH 23/25] Phy: DT binding documentation for Marvell MVEBU SATA phy Kishon Vijay Abraham I
2014-11-27  6:26 ` [PATCH 24/25] Phy: DT binding documentation for the Armada 375 USB cluster binding Kishon Vijay Abraham I
2014-11-27  6:26 ` [PATCH 25/25] phy: add support for USB cluster on the Armada 375 SoC Kishon Vijay Abraham I
2014-11-27 16:49 ` [GIT PULL 00/25] phy: for 3.19 Greg KH

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1417069577-1169-5-git-send-email-kishon@ti.com \
    --to=kishon@ti.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

Powered by JetHome