* [PATCH] staging:vt6655 Add extern variable in head file
@ 2014-12-16 7:39 sunwxg
2015-01-13 3:36 ` Greg Kroah-Hartman
0 siblings, 1 reply; 3+ messages in thread
From: sunwxg @ 2014-12-16 7:39 UTC (permalink / raw)
To: Forest Bond, Greg Kroah-Hartman, Guido Martínez, Silvio Fricke
Cc: Sun Wang, devel, linux-kernel
From: Sun Wang <sun.wxg@gmail.com>
Subject: [PATCH] staging:vt6655 Add extern variable in head file
Extern variable must be declared in head file. Compiler can catch the inconsistency when variable changes.
Signed-off-by: Sun Wang <sun.wxg@gmail.com>
---
drivers/staging/vt6655/ioctl.c | 1 -
drivers/staging/vt6655/ioctl.h | 5 +++++
2 files changed, 5 insertions(+), 1 deletion(-)
diff --git a/drivers/staging/vt6655/ioctl.c b/drivers/staging/vt6655/ioctl.c
index 970e80d..716fc89 100644
--- a/drivers/staging/vt6655/ioctl.c
+++ b/drivers/staging/vt6655/ioctl.c
@@ -31,7 +31,6 @@
*/
#include "ioctl.h"
-#include "iocmd.h"
#include "mac.h"
#include "card.h"
#include "hostap.h"
diff --git a/drivers/staging/vt6655/ioctl.h b/drivers/staging/vt6655/ioctl.h
index 2dc5a57..42f6910 100644
--- a/drivers/staging/vt6655/ioctl.h
+++ b/drivers/staging/vt6655/ioctl.h
@@ -30,6 +30,11 @@
#define __IOCTL_H__
#include "device.h"
+#include "iocmd.h"
+
+#ifdef WPA_SM_Transtatus
+extern SWPAResult wpa_Result;
+#endif
int private_ioctl(struct vnt_private *, struct ifreq *rq);
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] staging:vt6655 Add extern variable in head file
2014-12-16 7:39 [PATCH] staging:vt6655 Add extern variable in head file sunwxg
@ 2015-01-13 3:36 ` Greg Kroah-Hartman
0 siblings, 0 replies; 3+ messages in thread
From: Greg Kroah-Hartman @ 2015-01-13 3:36 UTC (permalink / raw)
To: sunwxg
Cc: Forest Bond, Guido Martínez, Silvio Fricke, devel, linux-kernel
On Tue, Dec 16, 2014 at 03:39:50PM +0800, sunwxg wrote:
> From: Sun Wang <sun.wxg@gmail.com>
>
> Subject: [PATCH] staging:vt6655 Add extern variable in head file
Why is this in the middle of the patch? I would have to hand edit it
out :(
>
> Extern variable must be declared in head file. Compiler can catch the inconsistency when variable changes.
Always wrap your changelog at 72 columns.
Please fix up and resend.
thanks,
greg k-h
^ permalink raw reply [flat|nested] 3+ messages in thread
[parent not found: <20150113083114.GA57460@nas4free.local>]
* Re: [PATCH] staging:vt6655 Add extern variable in head file
[not found] <20150113083114.GA57460@nas4free.local>
@ 2015-01-13 17:12 ` Greg KH
0 siblings, 0 replies; 3+ messages in thread
From: Greg KH @ 2015-01-13 17:12 UTC (permalink / raw)
To: sun wang
Cc: Forest, Bond, forest, Greg, Kroah-Hartman, guido, Silvio, Fricke,
silvio.fricke, linux-kernel, devel
On Tue, Jan 13, 2015 at 04:31:14PM +0800, sun wang wrote:
> Extern variable must be declared in head file. Compiler can catch the inconsistency when variable changes.
>
> Signed-off-by: Sun Wang <sun.wxg@gmail.com>
> ---
> drivers/staging/vt6655/ioctl.c | 1 -
> drivers/staging/vt6655/ioctl.h | 5 +++++
> 2 files changed, 5 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/staging/vt6655/ioctl.c b/drivers/staging/vt6655/ioctl.c
> index 970e80d..716fc89 100644
> --- a/drivers/staging/vt6655/ioctl.c
> +++ b/drivers/staging/vt6655/ioctl.c
> @@ -31,7 +31,6 @@
> */
>
> #include "ioctl.h"
> -#include "iocmd.h"
> #include "mac.h"
> #include "card.h"
> #include "hostap.h"
> diff --git a/drivers/staging/vt6655/ioctl.h b/drivers/staging/vt6655/ioctl.h
> index 2dc5a57..42f6910 100644
> --- a/drivers/staging/vt6655/ioctl.h
> +++ b/drivers/staging/vt6655/ioctl.h
> @@ -30,6 +30,11 @@
> #define __IOCTL_H__
>
> #include "device.h"
> +#include "iocmd.h"
> +
> +#ifdef WPA_SM_Transtatus
> +extern SWPAResult wpa_Result;
> +#endif
I don't understand, what problem is this solving? This variable isn't
in the driver at all.
confused,
greg k-h
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2015-01-13 17:12 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2014-12-16 7:39 [PATCH] staging:vt6655 Add extern variable in head file sunwxg
2015-01-13 3:36 ` Greg Kroah-Hartman
[not found] <20150113083114.GA57460@nas4free.local>
2015-01-13 17:12 ` Greg KH
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®