* [PATCH][linux-next] coda: Do not define TRACE_SYSTEM_STRING
@ 2015-05-15 2:52 Steven Rostedt
2015-05-15 2:58 ` Steven Rostedt
2015-05-20 9:42 ` Philipp Zabel
0 siblings, 2 replies; 3+ messages in thread
From: Steven Rostedt @ 2015-05-15 2:52 UTC (permalink / raw)
To: Philipp Zabel; +Cc: LKML, Kamil Debski, Mauro Carvalho Chehab
TRACE_SYSTEM_STRING is used internally to the TRACE_EVENT system. It
should not be defined by tracepoint files. I'm not even sure who
started that (I hope it wasn't me!)
Reported-by: kbuild test robot <fengguang.wu@intel.com>
Signed-off-by: Steven Rostedt <rostedt@goodmis.org.
---
diff --git a/drivers/media/platform/coda/trace.h b/drivers/media/platform/coda/trace.h
index d1d06cbd1f6a..781bf7286d53 100644
--- a/drivers/media/platform/coda/trace.h
+++ b/drivers/media/platform/coda/trace.h
@@ -9,8 +9,6 @@
#include "coda.h"
-#define TRACE_SYSTEM_STRING __stringify(TRACE_SYSTEM)
-
TRACE_EVENT(coda_bit_run,
TP_PROTO(struct coda_ctx *ctx, int cmd),
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH][linux-next] coda: Do not define TRACE_SYSTEM_STRING
2015-05-15 2:52 [PATCH][linux-next] coda: Do not define TRACE_SYSTEM_STRING Steven Rostedt
@ 2015-05-15 2:58 ` Steven Rostedt
2015-05-20 9:42 ` Philipp Zabel
1 sibling, 0 replies; 3+ messages in thread
From: Steven Rostedt @ 2015-05-15 2:58 UTC (permalink / raw)
To: Philipp Zabel; +Cc: LKML, Kamil Debski, Mauro Carvalho Chehab, Chris Wilson
On Thu, 14 May 2015 22:52:50 -0400
Steven Rostedt <rostedt@goodmis.org> wrote:
> TRACE_SYSTEM_STRING is used internally to the TRACE_EVENT system. It
> should not be defined by tracepoint files. I'm not even sure who
> started that (I hope it wasn't me!)
According to git history, that define first showed up in
commit 1c5d22f76dc721f3acb7a3dadc657a221e487fb7
Author: Chris Wilson <chris@chris-wilson.co.uk>
Date: Tue Aug 25 11:15:50 2009 +0100
drm/i915: Add tracepoints
And it must have spread with cut and paste. Now I need to start
administering a vaccine to keep developers from catching it!
-- Steve
>
> Reported-by: kbuild test robot <fengguang.wu@intel.com>
> Signed-off-by: Steven Rostedt <rostedt@goodmis.org.
> ---
> diff --git a/drivers/media/platform/coda/trace.h b/drivers/media/platform/coda/trace.h
> index d1d06cbd1f6a..781bf7286d53 100644
> --- a/drivers/media/platform/coda/trace.h
> +++ b/drivers/media/platform/coda/trace.h
> @@ -9,8 +9,6 @@
>
> #include "coda.h"
>
> -#define TRACE_SYSTEM_STRING __stringify(TRACE_SYSTEM)
> -
> TRACE_EVENT(coda_bit_run,
> TP_PROTO(struct coda_ctx *ctx, int cmd),
>
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH][linux-next] coda: Do not define TRACE_SYSTEM_STRING
2015-05-15 2:52 [PATCH][linux-next] coda: Do not define TRACE_SYSTEM_STRING Steven Rostedt
2015-05-15 2:58 ` Steven Rostedt
@ 2015-05-20 9:42 ` Philipp Zabel
1 sibling, 0 replies; 3+ messages in thread
From: Philipp Zabel @ 2015-05-20 9:42 UTC (permalink / raw)
To: Steven Rostedt; +Cc: LKML, Kamil Debski, Mauro Carvalho Chehab, Arnd Bergmann
Am Donnerstag, den 14.05.2015, 22:52 -0400 schrieb Steven Rostedt:
> TRACE_SYSTEM_STRING is used internally to the TRACE_EVENT system. It
> should not be defined by tracepoint files. I'm not even sure who
> started that (I hope it wasn't me!)
>
> Reported-by: kbuild test robot <fengguang.wu@intel.com>
> Signed-off-by: Steven Rostedt <rostedt@goodmis.org.
> ---
> diff --git a/drivers/media/platform/coda/trace.h b/drivers/media/platform/coda/trace.h
> index d1d06cbd1f6a..781bf7286d53 100644
> --- a/drivers/media/platform/coda/trace.h
> +++ b/drivers/media/platform/coda/trace.h
> @@ -9,8 +9,6 @@
>
> #include "coda.h"
>
> -#define TRACE_SYSTEM_STRING __stringify(TRACE_SYSTEM)
> -
> TRACE_EVENT(coda_bit_run,
> TP_PROTO(struct coda_ctx *ctx, int cmd),
Acked-by: Philipp Zabel <p.zabel@pengutronix.de>
thanks
Philipp
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2015-05-20 9:42 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-05-15 2:52 [PATCH][linux-next] coda: Do not define TRACE_SYSTEM_STRING Steven Rostedt
2015-05-15 2:58 ` Steven Rostedt
2015-05-20 9:42 ` Philipp Zabel
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®