From: Petr Tesarik <ptesarik@suse.com>
To: Johan Hovold <johan@kernel.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: Petr Tesarik <ptesarik@suse.com>,
linux-usb@vger.kernel.org (open list:USB SERIAL SUBSYSTEM),
linux-kernel@vger.kernel.org (open list),
Petr Tesarik <ptesarik@suse.cz>
Subject: [PATCH 1/4] cp210x: Replace USB magic numbers with symbolic names
Date: Fri, 24 Jul 2015 08:48:08 +0200 [thread overview]
Message-ID: <1437720491-28702-2-git-send-email-ptesarik@suse.com> (raw)
In-Reply-To: <1437720491-28702-1-git-send-email-ptesarik@suse.com>
From: Petr Tesarik <ptesarik@suse.cz>
The request type is in fact made of three fields that already have
symbolic constants.
While I was rewriting those lines, I also converted the pre-processor
defines into an enum, so they are seen by debuggers.
Signed-off-by: Petr Tesarik <ptesarik@suse.com>
---
drivers/usb/serial/cp210x.c | 14 ++++++++++----
1 file changed, 10 insertions(+), 4 deletions(-)
diff --git a/drivers/usb/serial/cp210x.c b/drivers/usb/serial/cp210x.c
index eac7cca..1bae015 100644
--- a/drivers/usb/serial/cp210x.c
+++ b/drivers/usb/serial/cp210x.c
@@ -226,10 +226,16 @@ static struct usb_serial_driver * const serial_drivers[] = {
};
/* Config request types */
-#define REQTYPE_HOST_TO_INTERFACE 0x41
-#define REQTYPE_INTERFACE_TO_HOST 0xc1
-#define REQTYPE_HOST_TO_DEVICE 0x40
-#define REQTYPE_DEVICE_TO_HOST 0xc0
+enum cp210x_request_type {
+ REQTYPE_HOST_TO_INTERFACE =
+ USB_DIR_OUT | USB_TYPE_VENDOR | USB_RECIP_INTERFACE,
+ REQTYPE_INTERFACE_TO_HOST =
+ USB_DIR_IN | USB_TYPE_VENDOR | USB_RECIP_INTERFACE,
+ REQTYPE_HOST_TO_DEVICE =
+ USB_DIR_OUT | USB_TYPE_VENDOR | USB_RECIP_DEVICE,
+ REQTYPE_DEVICE_TO_HOST =
+ USB_DIR_IN | USB_TYPE_VENDOR | USB_RECIP_DEVICE,
+};
/* Config request codes */
#define CP210X_IFC_ENABLE 0x00
--
2.1.4
next prev parent reply other threads:[~2015-07-24 6:49 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-24 6:48 [PATCH 0/4] Show CP210x part number in sysfs Petr Tesarik
2015-07-24 6:48 ` Petr Tesarik [this message]
2015-07-24 6:48 ` [PATCH 2/4] cp210x: Unify code for set/get config control messages Petr Tesarik
2015-07-30 17:01 ` Johan Hovold
2015-07-24 6:48 ` [PATCH 3/4] cp210x: Store part number Petr Tesarik
2015-07-26 13:32 ` Oliver Neukum
2015-07-27 6:50 ` Petr Tesarik
2015-07-27 9:29 ` Oliver Neukum
2015-07-24 6:48 ` [PATCH 4/4] cp210x: Expose the part number in sysfs Petr Tesarik
2015-07-24 18:17 ` Greg Kroah-Hartman
2015-07-24 21:00 ` Petr Tesarik
2015-07-24 21:33 ` Greg Kroah-Hartman
2015-07-24 21:46 ` Petr Tesarik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1437720491-28702-2-git-send-email-ptesarik@suse.com \
--to=ptesarik@suse.com \
--cc=gregkh@linuxfoundation.org \
--cc=johan@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=ptesarik@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome