mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Petr Tesarik <ptesarik@suse.com>
To: Johan Hovold <johan@kernel.org>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: Petr Tesarik <ptesarik@suse.com>,
	linux-usb@vger.kernel.org (open list:USB SERIAL SUBSYSTEM),
	linux-kernel@vger.kernel.org (open list),
	Petr Tesarik <ptesarik@suse.cz>
Subject: [PATCH 4/4] cp210x: Expose the part number in sysfs
Date: Fri, 24 Jul 2015 08:48:11 +0200	[thread overview]
Message-ID: <1437720491-28702-5-git-send-email-ptesarik@suse.com> (raw)
In-Reply-To: <1437720491-28702-1-git-send-email-ptesarik@suse.com>

From: Petr Tesarik <ptesarik@suse.cz>

Make it possible to read the cp210x part number from userspace by making
it a sysfs attribute.

Signed-off-by: Petr Tesarik <ptesarik@suse.com>
---
 drivers/usb/serial/cp210x.c | 21 ++++++++++++++++++++-
 1 file changed, 20 insertions(+), 1 deletion(-)

diff --git a/drivers/usb/serial/cp210x.c b/drivers/usb/serial/cp210x.c
index dbfc722..66de350 100644
--- a/drivers/usb/serial/cp210x.c
+++ b/drivers/usb/serial/cp210x.c
@@ -871,11 +871,24 @@ static void cp210x_break_ctl(struct tty_struct *tty, int break_state)
 	cp210x_set_config(port, CP210X_SET_BREAK, &state, 2);
 }
 
+static ssize_t part_number_show(struct device *dev,
+				struct device_attribute *attr, char *buf)
+{
+	struct usb_interface *intf = to_usb_interface(dev);
+	struct usb_serial *serial = usb_get_intfdata(intf);
+	struct cp210x_serial_private *spriv = usb_get_serial_data(serial);
+
+	return sprintf(buf, "%i\n", spriv->bPartNumber);
+}
+
+static DEVICE_ATTR_RO(part_number);
+
 static int cp210x_startup(struct usb_serial *serial)
 {
 	struct usb_host_interface *cur_altsetting;
 	struct cp210x_serial_private *spriv;
 	unsigned int partnum;
+	int result;
 
 	spriv = kzalloc(sizeof(*spriv), GFP_KERNEL);
 	if (!spriv)
@@ -892,13 +905,19 @@ static int cp210x_startup(struct usb_serial *serial)
 			   &partnum, 1, USB_CTRL_GET_TIMEOUT);
 	spriv->bPartNumber = partnum & 0xFF;
 
-	return 0;
+	result = device_create_file(&serial->interface->dev,
+				    &dev_attr_part_number);
+	if (result)
+		kfree(spriv);
+
+	return result;
 }
 
 static void cp210x_release(struct usb_serial *serial)
 {
 	struct cp210x_serial_private *spriv;
 
+	device_remove_file(&serial->interface->dev, &dev_attr_part_number);
 	spriv = usb_get_serial_data(serial);
 	kfree(spriv);
 }
-- 
2.1.4


  parent reply	other threads:[~2015-07-24  6:49 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-07-24  6:48 [PATCH 0/4] Show CP210x " Petr Tesarik
2015-07-24  6:48 ` [PATCH 1/4] cp210x: Replace USB magic numbers with symbolic names Petr Tesarik
2015-07-24  6:48 ` [PATCH 2/4] cp210x: Unify code for set/get config control messages Petr Tesarik
2015-07-30 17:01   ` Johan Hovold
2015-07-24  6:48 ` [PATCH 3/4] cp210x: Store part number Petr Tesarik
2015-07-26 13:32   ` Oliver Neukum
2015-07-27  6:50     ` Petr Tesarik
2015-07-27  9:29       ` Oliver Neukum
2015-07-24  6:48 ` Petr Tesarik [this message]
2015-07-24 18:17   ` [PATCH 4/4] cp210x: Expose the part number in sysfs Greg Kroah-Hartman
2015-07-24 21:00     ` Petr Tesarik
2015-07-24 21:33       ` Greg Kroah-Hartman
2015-07-24 21:46         ` Petr Tesarik

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1437720491-28702-5-git-send-email-ptesarik@suse.com \
    --to=ptesarik@suse.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=johan@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=ptesarik@suse.cz \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

Powered by JetHome