From: Oliver Neukum <oneukum@suse.com>
To: Petr Tesarik <ptesarik@suse.com>
Cc: Johan Hovold <johan@kernel.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
"open list:USB SERIAL SUBSYSTEM" <linux-usb@vger.kernel.org>,
open list <linux-kernel@vger.kernel.org>,
Petr Tesarik <ptesarik@suse.cz>
Subject: Re: [PATCH 3/4] cp210x: Store part number
Date: Sun, 26 Jul 2015 15:32:54 +0200 [thread overview]
Message-ID: <1437917574.5839.2.camel@suse.com> (raw)
In-Reply-To: <1437720491-28702-4-git-send-email-ptesarik@suse.com>
On Fri, 2015-07-24 at 08:48 +0200, Petr Tesarik wrote:
> @@ -872,6 +886,12 @@ static int cp210x_startup(struct usb_serial
> *serial)
>
> usb_set_serial_data(serial, spriv);
>
> + /* Get the 1-byte part number of the cp210x device */
> + cp210x_control_msg(serial->port[0], CP210X_VENDOR_SPECIFIC,
> + REQTYPE_DEVICE_TO_HOST, CP210X_GET_PARTNUM,
> + &partnum, 1, USB_CTRL_GET_TIMEOUT);
> + spriv->bPartNumber = partnum & 0xFF;
DMA on the stack. That breaks the cache coherency rules.
You must kmalloc the buffer.
Regards
Oliver
next prev parent reply other threads:[~2015-07-26 13:33 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-24 6:48 [PATCH 0/4] Show CP210x part number in sysfs Petr Tesarik
2015-07-24 6:48 ` [PATCH 1/4] cp210x: Replace USB magic numbers with symbolic names Petr Tesarik
2015-07-24 6:48 ` [PATCH 2/4] cp210x: Unify code for set/get config control messages Petr Tesarik
2015-07-30 17:01 ` Johan Hovold
2015-07-24 6:48 ` [PATCH 3/4] cp210x: Store part number Petr Tesarik
2015-07-26 13:32 ` Oliver Neukum [this message]
2015-07-27 6:50 ` Petr Tesarik
2015-07-27 9:29 ` Oliver Neukum
2015-07-24 6:48 ` [PATCH 4/4] cp210x: Expose the part number in sysfs Petr Tesarik
2015-07-24 18:17 ` Greg Kroah-Hartman
2015-07-24 21:00 ` Petr Tesarik
2015-07-24 21:33 ` Greg Kroah-Hartman
2015-07-24 21:46 ` Petr Tesarik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1437917574.5839.2.camel@suse.com \
--to=oneukum@suse.com \
--cc=gregkh@linuxfoundation.org \
--cc=johan@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=ptesarik@suse.com \
--cc=ptesarik@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome