From: Oliver Neukum <oneukum@suse.com>
To: Petr Tesarik <PTesarik@suse.com>
Cc: Johan Hovold <johan@kernel.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
PetrTesarik <ptesarik@suse.cz>,
open list <linux-kernel@vger.kernel.org>,
"open list:USB SERIAL SUBSYSTEM" <linux-usb@vger.kernel.org>
Subject: Re: [PATCH 3/4] cp210x: Store part number
Date: Mon, 27 Jul 2015 11:29:17 +0200 [thread overview]
Message-ID: <1437989357.32457.3.camel@suse.com> (raw)
In-Reply-To: <20150727085039.1627db72@hananiah.suse.cz>
On Mon, 2015-07-27 at 08:50 +0200, Petr Tesarik wrote:
> I don't understand. While you're right that I copied this part from
> Sillicon Labs' driver without much thinking, and &spriv->bPartNumber
> can be used directly, I can't see any DMA on stack. FWIW
> cp210x_control_msg always allocates a buffer using kcalloc:
>
> buf = kcalloc(length, sizeof(__le32), GFP_KERNEL);
> /* ... */
> result = usb_control_msg(serial->dev,
> usb_rcvctrlpipe(serial->dev, 0),
> request, requesttype, value,
> spriv->bInterfaceNumber, buf, size,
> timeout);
>
> Is that what you mean?
Yes, sorry, that part wasn't so clear from the previous patch.
Sorry
Oliver
next prev parent reply other threads:[~2015-07-27 9:29 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-24 6:48 [PATCH 0/4] Show CP210x part number in sysfs Petr Tesarik
2015-07-24 6:48 ` [PATCH 1/4] cp210x: Replace USB magic numbers with symbolic names Petr Tesarik
2015-07-24 6:48 ` [PATCH 2/4] cp210x: Unify code for set/get config control messages Petr Tesarik
2015-07-30 17:01 ` Johan Hovold
2015-07-24 6:48 ` [PATCH 3/4] cp210x: Store part number Petr Tesarik
2015-07-26 13:32 ` Oliver Neukum
2015-07-27 6:50 ` Petr Tesarik
2015-07-27 9:29 ` Oliver Neukum [this message]
2015-07-24 6:48 ` [PATCH 4/4] cp210x: Expose the part number in sysfs Petr Tesarik
2015-07-24 18:17 ` Greg Kroah-Hartman
2015-07-24 21:00 ` Petr Tesarik
2015-07-24 21:33 ` Greg Kroah-Hartman
2015-07-24 21:46 ` Petr Tesarik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1437989357.32457.3.camel@suse.com \
--to=oneukum@suse.com \
--cc=PTesarik@suse.com \
--cc=gregkh@linuxfoundation.org \
--cc=johan@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=ptesarik@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome