mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Ben Hutchings <ben@decadent.org.uk>
To: Maxim Levitsky <maximlevitsky@gmail.com>,
	Roger Tseng <rogerable@realtek.com>
Cc: LKML <linux-kernel@vger.kernel.org>, Lee Jones <lee.jones@linaro.org>
Subject: [PATCH RESEND] rtsx_usb_ms: Use msleep_interruptible() in polling loop
Date: Mon, 28 Sep 2015 01:34:21 +0100	[thread overview]
Message-ID: <1443400461.2517.22.camel@decadent.org.uk> (raw)

[-- Attachment #1: Type: text/plain, Size: 822 bytes --]

rtsx_usb_ms creates a task that mostly sleeps, but tasks in
uninterruptible sleep still contribute to the load average (for
bug-compatibility with Unix).  A load average of ~1 on a system that
should be idle is somewhat alarming.

Change the sleep to be interruptible, but still ignore signals.

A better fix might be to replace this loop with a delayed work item.

References: https://bugs.debian.org/765717
Signed-off-by: Ben Hutchings <ben@decadent.org.uk>
---
--- a/drivers/memstick/host/rtsx_usb_ms.c
+++ b/drivers/memstick/host/rtsx_usb_ms.c
@@ -706,7 +706,8 @@ poll_again:
 		if (host->eject)
 			break;
 
-		msleep(1000);
+		if (msleep_interruptible(1000))
+			flush_signals(current);
 	}
 
 	complete(&host->detect_ms_exit);
-- 
Ben Hutchings
All extremists should be taken out and shot.

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 811 bytes --]

             reply	other threads:[~2015-09-28  0:34 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-09-28  0:34 Ben Hutchings [this message]
2015-09-28 10:34 ` Lee Jones
2015-09-28 11:10   ` Ben Hutchings
2015-09-28 11:23     ` Lee Jones
2015-10-08  3:37 ` Roger Tseng
2015-10-08  7:19 ` Lee Jones
2015-10-08 19:35   ` Ben Hutchings
2015-10-09  7:18     ` Lee Jones
2016-05-02 20:17 Oleksandr Natalenko
2016-05-02 20:56 ` Andrew Morton
2016-05-03 13:40   ` Oleg Nesterov
2016-05-03 15:22     ` Ben Hutchings

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1443400461.2517.22.camel@decadent.org.uk \
    --to=ben@decadent.org.uk \
    --cc=lee.jones@linaro.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=maximlevitsky@gmail.com \
    --cc=rogerable@realtek.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

Powered by JetHome