From: Ben Hutchings <ben@decadent.org.uk>
To: Oleg Nesterov <oleg@redhat.com>,
Andrew Morton <akpm@linux-foundation.org>
Cc: Oleksandr Natalenko <oleksandr@natalenko.name>,
Lee Jones <lee.jones@linaro.org>,
Wolfram Sang <wsa@the-dreams.de>,
Roger Tseng <rogerable@realtek.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH RESEND] rtsx_usb_ms: Use msleep_interruptible() in polling loop
Date: Tue, 03 May 2016 17:22:47 +0200 [thread overview]
Message-ID: <1462288967.17662.107.camel@decadent.org.uk> (raw)
In-Reply-To: <20160503134009.GA26668@redhat.com>
[-- Attachment #1: Type: text/plain, Size: 726 bytes --]
On Tue, 2016-05-03 at 15:40 +0200, Oleg Nesterov wrote:
> On 05/02, Andrew Morton wrote:
> >
> >
> > On Mon, 02 May 2016 23:17:41 +0300 Oleksandr Natalenko wrote:
> >
> > >
> > > rtsx_usb_ms creates a task that mostly sleeps, but tasks in
> > > uninterruptible sleep still contribute to the load average (for
> > > bug-compatibility with Unix).
> We have TASK_NOLOAD/TASK_IDLE, you can just use schedule_timeout_idle(HZ).
[...]
I wasn't aware of that function... ah, that would be because it's new
in 4.6. It seems much clearer to use that than to use
msleep_interruptible() and ignore the result.
Ben.
--
Ben Hutchings
In a hierarchy, every employee tends to rise to his level of incompetence.
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
next prev parent reply other threads:[~2016-05-03 15:23 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-02 20:17 Oleksandr Natalenko
2016-05-02 20:56 ` Andrew Morton
2016-05-03 13:40 ` Oleg Nesterov
2016-05-03 15:22 ` Ben Hutchings [this message]
-- strict thread matches above, loose matches on Subject: below --
2015-09-28 0:34 Ben Hutchings
2015-09-28 10:34 ` Lee Jones
2015-09-28 11:10 ` Ben Hutchings
2015-09-28 11:23 ` Lee Jones
2015-10-08 3:37 ` Roger Tseng
2015-10-08 7:19 ` Lee Jones
2015-10-08 19:35 ` Ben Hutchings
2015-10-09 7:18 ` Lee Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1462288967.17662.107.camel@decadent.org.uk \
--to=ben@decadent.org.uk \
--cc=akpm@linux-foundation.org \
--cc=lee.jones@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=oleg@redhat.com \
--cc=oleksandr@natalenko.name \
--cc=rogerable@realtek.com \
--cc=wsa@the-dreams.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®