From: Ming Lei <ming.lei@canonical.com>
To: Jens Axboe <axboe@kernel.dk>, linux-kernel@vger.kernel.org
Cc: Ming Lin <ming.l@ssi.samsung.com>,
Kent Overstreet <kent.overstreet@gmail.com>,
Christoph Hellwig <hch@infradead.org>,
Ming Lei <ming.lei@canonical.com>
Subject: [PATCH 2/4] block: avoid to merge splitted bio
Date: Wed, 14 Oct 2015 11:30:46 +0800 [thread overview]
Message-ID: <1444793448-9994-3-git-send-email-ming.lei@canonical.com> (raw)
In-Reply-To: <1444793448-9994-1-git-send-email-ming.lei@canonical.com>
The splitted bio has been already too fat to merge, so mark it
as NOMERGE.
Signed-off-by: Ming Lei <ming.lei@canonical.com>
---
block/blk-merge.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/block/blk-merge.c b/block/blk-merge.c
index 22293fd..de5716d8 100644
--- a/block/blk-merge.c
+++ b/block/blk-merge.c
@@ -139,6 +139,9 @@ void blk_queue_split(struct request_queue *q, struct bio **bio,
bio_set_flag(res, BIO_SEG_VALID);
if (split) {
+ /* there isn't chance to merge the splitted bio */
+ split->bi_rw |= REQ_NOMERGE;
+
bio_chain(split, *bio);
generic_make_request(*bio);
*bio = split;
--
1.9.1
next prev parent reply other threads:[~2015-10-14 3:31 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-14 3:30 [PATCH 0/4] block: some misc changes Ming Lei
2015-10-14 3:30 ` [PATCH 1/4] block: setup bi_phys_segments after splitting Ming Lei
2015-10-15 15:14 ` Jeff Moyer
2015-10-14 3:30 ` Ming Lei [this message]
2015-10-15 15:15 ` [PATCH 2/4] block: avoid to merge splitted bio Jeff Moyer
2015-10-14 3:30 ` [PATCH 3/4] blk-mq: check bio_mergeable() early before merging Ming Lei
2015-10-15 15:21 ` Jeff Moyer
2015-10-16 0:26 ` Ming Lei
2015-10-14 3:30 ` [PATCH 4/4] blk-mq: mark ctx as pending at batch in flush plug path Ming Lei
2015-10-15 15:26 ` Jeff Moyer
2015-10-16 0:24 ` Ming Lei
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1444793448-9994-3-git-send-email-ming.lei@canonical.com \
--to=ming.lei@canonical.com \
--cc=axboe@kernel.dk \
--cc=hch@infradead.org \
--cc=kent.overstreet@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=ming.l@ssi.samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®