mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Ming Lei <ming.lei@canonical.com>
To: Jens Axboe <axboe@kernel.dk>, linux-kernel@vger.kernel.org
Cc: Ming Lin <ming.l@ssi.samsung.com>,
	Kent Overstreet <kent.overstreet@gmail.com>,
	Christoph Hellwig <hch@infradead.org>,
	Ming Lei <ming.lei@canonical.com>
Subject: [PATCH 3/4] blk-mq: check bio_mergeable() early before merging
Date: Wed, 14 Oct 2015 11:30:47 +0800	[thread overview]
Message-ID: <1444793448-9994-4-git-send-email-ming.lei@canonical.com> (raw)
In-Reply-To: <1444793448-9994-1-git-send-email-ming.lei@canonical.com>

It isn't necessary to try to merge the bio which is marked
as NOMERGE.

Signed-off-by: Ming Lei <ming.lei@canonical.com>
---
 block/blk-mq.c | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/block/blk-mq.c b/block/blk-mq.c
index 546b3b8..deb5f4c 100644
--- a/block/blk-mq.c
+++ b/block/blk-mq.c
@@ -671,6 +671,9 @@ static bool blk_mq_attempt_merge(struct request_queue *q,
 	struct request *rq;
 	int checked = 8;
 
+	if (!bio_mergeable(bio))
+		return false;
+
 	list_for_each_entry_reverse(rq, &ctx->rq_list, queuelist) {
 		int el_ret;
 
@@ -1140,7 +1143,7 @@ static inline bool blk_mq_merge_queue_io(struct blk_mq_hw_ctx *hctx,
 					 struct blk_mq_ctx *ctx,
 					 struct request *rq, struct bio *bio)
 {
-	if (!hctx_allow_merges(hctx)) {
+	if (!hctx_allow_merges(hctx) || !bio_mergeable(bio)) {
 		blk_mq_bio_to_request(rq, bio);
 		spin_lock(&ctx->lock);
 insert_rq:
-- 
1.9.1


  parent reply	other threads:[~2015-10-14  3:31 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-10-14  3:30 [PATCH 0/4] block: some misc changes Ming Lei
2015-10-14  3:30 ` [PATCH 1/4] block: setup bi_phys_segments after splitting Ming Lei
2015-10-15 15:14   ` Jeff Moyer
2015-10-14  3:30 ` [PATCH 2/4] block: avoid to merge splitted bio Ming Lei
2015-10-15 15:15   ` Jeff Moyer
2015-10-14  3:30 ` Ming Lei [this message]
2015-10-15 15:21   ` [PATCH 3/4] blk-mq: check bio_mergeable() early before merging Jeff Moyer
2015-10-16  0:26     ` Ming Lei
2015-10-14  3:30 ` [PATCH 4/4] blk-mq: mark ctx as pending at batch in flush plug path Ming Lei
2015-10-15 15:26   ` Jeff Moyer
2015-10-16  0:24     ` Ming Lei

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1444793448-9994-4-git-send-email-ming.lei@canonical.com \
    --to=ming.lei@canonical.com \
    --cc=axboe@kernel.dk \
    --cc=hch@infradead.org \
    --cc=kent.overstreet@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=ming.l@ssi.samsung.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®