* [PATCH] ceph: fix a wrong comparison
@ 2016-02-10 17:38 Anton Protopopov
2016-02-11 2:52 ` Yan, Zheng
0 siblings, 1 reply; 2+ messages in thread
From: Anton Protopopov @ 2016-02-10 17:38 UTC (permalink / raw)
To: Yan, Zheng, Sage Weil, Ilya Dryomov
Cc: ceph-devel, linux-kernel, Anton Protopopov
A negative value rc compared to the positive value ENOENT in the
finish_read() function.
Signed-off-by: Anton Protopopov <a.s.protopopov@gmail.com>
---
fs/ceph/addr.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/fs/ceph/addr.c b/fs/ceph/addr.c
index c222137..1b809c9 100644
--- a/fs/ceph/addr.c
+++ b/fs/ceph/addr.c
@@ -276,7 +276,7 @@ static void finish_read(struct ceph_osd_request *req, struct ceph_msg *msg)
for (i = 0; i < num_pages; i++) {
struct page *page = osd_data->pages[i];
- if (rc < 0 && rc != ENOENT)
+ if (rc < 0 && rc != -ENOENT)
goto unlock;
if (bytes < (int)PAGE_CACHE_SIZE) {
/* zero (remainder of) page */
--
2.6.5
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] ceph: fix a wrong comparison
2016-02-10 17:38 [PATCH] ceph: fix a wrong comparison Anton Protopopov
@ 2016-02-11 2:52 ` Yan, Zheng
0 siblings, 0 replies; 2+ messages in thread
From: Yan, Zheng @ 2016-02-11 2:52 UTC (permalink / raw)
To: Anton Protopopov; +Cc: Sage Weil, Ilya Dryomov, ceph-devel, linux-kernel
> On Feb 11, 2016, at 01:38, Anton Protopopov <a.s.protopopov@gmail.com> wrote:
>
> A negative value rc compared to the positive value ENOENT in the
> finish_read() function.
>
> Signed-off-by: Anton Protopopov <a.s.protopopov@gmail.com>
> ---
> fs/ceph/addr.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/fs/ceph/addr.c b/fs/ceph/addr.c
> index c222137..1b809c9 100644
> --- a/fs/ceph/addr.c
> +++ b/fs/ceph/addr.c
> @@ -276,7 +276,7 @@ static void finish_read(struct ceph_osd_request *req, struct ceph_msg *msg)
> for (i = 0; i < num_pages; i++) {
> struct page *page = osd_data->pages[i];
>
> - if (rc < 0 && rc != ENOENT)
> + if (rc < 0 && rc != -ENOENT)
> goto unlock;
> if (bytes < (int)PAGE_CACHE_SIZE) {
> /* zero (remainder of) page */
Good catch, thanks
Yan, Zheng
> --
> 2.6.5
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2016-02-11 2:52 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-02-10 17:38 [PATCH] ceph: fix a wrong comparison Anton Protopopov
2016-02-11 2:52 ` Yan, Zheng
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®