* [PATCH] firmware: qemu_fw_cfg.c: fix typo FW_CFG_DATA_OFF
@ 2016-02-11 11:12 Valentin Rothberg
2016-02-11 11:19 ` [PATCH v2] " Valentin Rothberg
0 siblings, 1 reply; 3+ messages in thread
From: Valentin Rothberg @ 2016-02-11 11:12 UTC (permalink / raw)
To: gregkh, somlo; +Cc: linux-kernel, Valentin Rothberg, Anreads Ziegler
s/FW_CTRL_DATA_OFF/FW_CFG_DATA_OFF/
Signed-off-by: Valentin Rothberg <valentin.rothberg@posteo.net>
Signed-off-by: Anreads Ziegler <andreas.ziegler@fau.de>
---
drivers/firmware/qemu_fw_cfg.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/firmware/qemu_fw_cfg.c b/drivers/firmware/qemu_fw_cfg.c
index 19f6851be87f..fedbff55a7f3 100644
--- a/drivers/firmware/qemu_fw_cfg.c
+++ b/drivers/firmware/qemu_fw_cfg.c
@@ -98,7 +98,7 @@ static void fw_cfg_io_cleanup(void)
}
/* arch-specific ctrl & data register offsets are not available in ACPI, DT */
-#if !(defined(FW_CFG_CTRL_OFF) && defined(FW_CTRL_DATA_OFF))
+#if !(defined(FW_CFG_CTRL_OFF) && defined(FW_CFG_DATA_OFF))
# if (defined(CONFIG_ARM) || defined(CONFIG_ARM64))
# define FW_CFG_CTRL_OFF 0x08
# define FW_CFG_DATA_OFF 0x00
--
2.5.0
^ permalink raw reply [flat|nested] 3+ messages in thread
* [PATCH v2] firmware: qemu_fw_cfg.c: fix typo FW_CFG_DATA_OFF
2016-02-11 11:12 [PATCH] firmware: qemu_fw_cfg.c: fix typo FW_CFG_DATA_OFF Valentin Rothberg
@ 2016-02-11 11:19 ` Valentin Rothberg
2016-02-11 12:12 ` Gabriel L. Somlo
0 siblings, 1 reply; 3+ messages in thread
From: Valentin Rothberg @ 2016-02-11 11:19 UTC (permalink / raw)
To: gregkh, somlo; +Cc: linux-kernel, Valentin Rothberg, Andreas Ziegler
s/FW_CTRL_DATA_OFF/FW_CFG_DATA_OFF/
Signed-off-by: Valentin Rothberg <valentin.rothberg@posteo.net>
Signed-off-by: Andreas Ziegler <andreas.ziegler@fau.de>
---
v2: corrected typo in signed-off-by
drivers/firmware/qemu_fw_cfg.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/firmware/qemu_fw_cfg.c b/drivers/firmware/qemu_fw_cfg.c
index 19f6851be87f..fedbff55a7f3 100644
--- a/drivers/firmware/qemu_fw_cfg.c
+++ b/drivers/firmware/qemu_fw_cfg.c
@@ -98,7 +98,7 @@ static void fw_cfg_io_cleanup(void)
}
/* arch-specific ctrl & data register offsets are not available in ACPI, DT */
-#if !(defined(FW_CFG_CTRL_OFF) && defined(FW_CTRL_DATA_OFF))
+#if !(defined(FW_CFG_CTRL_OFF) && defined(FW_CFG_DATA_OFF))
# if (defined(CONFIG_ARM) || defined(CONFIG_ARM64))
# define FW_CFG_CTRL_OFF 0x08
# define FW_CFG_DATA_OFF 0x00
--
2.5.0
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH v2] firmware: qemu_fw_cfg.c: fix typo FW_CFG_DATA_OFF
2016-02-11 11:19 ` [PATCH v2] " Valentin Rothberg
@ 2016-02-11 12:12 ` Gabriel L. Somlo
0 siblings, 0 replies; 3+ messages in thread
From: Gabriel L. Somlo @ 2016-02-11 12:12 UTC (permalink / raw)
To: Valentin Rothberg; +Cc: gregkh, linux-kernel, Andreas Ziegler
On Thu, Feb 11, 2016 at 12:19:03PM +0100, Valentin Rothberg wrote:
> s/FW_CTRL_DATA_OFF/FW_CFG_DATA_OFF/
Thanks for catching that !
Acked-by: Gabriel Somlo <somlo@cmu.edu>
>
> Signed-off-by: Valentin Rothberg <valentin.rothberg@posteo.net>
> Signed-off-by: Andreas Ziegler <andreas.ziegler@fau.de>
> ---
> v2: corrected typo in signed-off-by
>
> drivers/firmware/qemu_fw_cfg.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/firmware/qemu_fw_cfg.c b/drivers/firmware/qemu_fw_cfg.c
> index 19f6851be87f..fedbff55a7f3 100644
> --- a/drivers/firmware/qemu_fw_cfg.c
> +++ b/drivers/firmware/qemu_fw_cfg.c
> @@ -98,7 +98,7 @@ static void fw_cfg_io_cleanup(void)
> }
>
> /* arch-specific ctrl & data register offsets are not available in ACPI, DT */
> -#if !(defined(FW_CFG_CTRL_OFF) && defined(FW_CTRL_DATA_OFF))
> +#if !(defined(FW_CFG_CTRL_OFF) && defined(FW_CFG_DATA_OFF))
> # if (defined(CONFIG_ARM) || defined(CONFIG_ARM64))
> # define FW_CFG_CTRL_OFF 0x08
> # define FW_CFG_DATA_OFF 0x00
> --
> 2.5.0
>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2016-02-11 12:13 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-02-11 11:12 [PATCH] firmware: qemu_fw_cfg.c: fix typo FW_CFG_DATA_OFF Valentin Rothberg
2016-02-11 11:19 ` [PATCH v2] " Valentin Rothberg
2016-02-11 12:12 ` Gabriel L. Somlo
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®