* [PATCH] phy: brcm-sata: Return proper error if brcm_sata_phy_init fails
@ 2016-05-23 5:21 Axel Lin
2016-05-23 5:28 ` Kishon Vijay Abraham I
0 siblings, 1 reply; 3+ messages in thread
From: Axel Lin @ 2016-05-23 5:21 UTC (permalink / raw)
To: Kishon Vijay Abraham I; +Cc: Anup Patel, Florian Fainelli, linux-kernel
Signed-off-by: Axel Lin <axel.lin@ingics.com>
---
drivers/phy/phy-brcm-sata.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/phy/phy-brcm-sata.c b/drivers/phy/phy-brcm-sata.c
index 6c4c5cb..5d7fad4b 100644
--- a/drivers/phy/phy-brcm-sata.c
+++ b/drivers/phy/phy-brcm-sata.c
@@ -288,7 +288,7 @@ static int brcm_sata_phy_init(struct phy *phy)
rc = -ENODEV;
};
- return 0;
+ return rc;
}
static const struct phy_ops phy_ops = {
--
2.5.0
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] phy: brcm-sata: Return proper error if brcm_sata_phy_init fails
2016-05-23 5:21 [PATCH] phy: brcm-sata: Return proper error if brcm_sata_phy_init fails Axel Lin
@ 2016-05-23 5:28 ` Kishon Vijay Abraham I
2016-05-23 5:30 ` Axel Lin
0 siblings, 1 reply; 3+ messages in thread
From: Kishon Vijay Abraham I @ 2016-05-23 5:28 UTC (permalink / raw)
To: Axel Lin; +Cc: Anup Patel, Florian Fainelli, linux-kernel
Hi,
On Monday 23 May 2016 10:51 AM, Axel Lin wrote:
> Signed-off-by: Axel Lin <axel.lin@ingics.com>
however obvious the patch maybe, it's nice to add a little commit log.
Thanks
Kishon
> ---
> drivers/phy/phy-brcm-sata.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/phy/phy-brcm-sata.c b/drivers/phy/phy-brcm-sata.c
> index 6c4c5cb..5d7fad4b 100644
> --- a/drivers/phy/phy-brcm-sata.c
> +++ b/drivers/phy/phy-brcm-sata.c
> @@ -288,7 +288,7 @@ static int brcm_sata_phy_init(struct phy *phy)
> rc = -ENODEV;
> };
>
> - return 0;
> + return rc;
> }
>
> static const struct phy_ops phy_ops = {
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] phy: brcm-sata: Return proper error if brcm_sata_phy_init fails
2016-05-23 5:28 ` Kishon Vijay Abraham I
@ 2016-05-23 5:30 ` Axel Lin
0 siblings, 0 replies; 3+ messages in thread
From: Axel Lin @ 2016-05-23 5:30 UTC (permalink / raw)
To: Kishon Vijay Abraham I; +Cc: Anup Patel, Florian Fainelli, linux-kernel
2016-05-23 13:28 GMT+08:00 Kishon Vijay Abraham I <kishon@ti.com>:
> Hi,
>
> On Monday 23 May 2016 10:51 AM, Axel Lin wrote:
>> Signed-off-by: Axel Lin <axel.lin@ingics.com>
>
> however obvious the patch maybe, it's nice to add a little commit log.
I think the subject line is already very clear about the intention.
In additional, checkpatch does not complain.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2016-05-23 5:30 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-05-23 5:21 [PATCH] phy: brcm-sata: Return proper error if brcm_sata_phy_init fails Axel Lin
2016-05-23 5:28 ` Kishon Vijay Abraham I
2016-05-23 5:30 ` Axel Lin
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®