* [PATCH] leds: Only remove trigger if one is actually configured. @ 2016-09-14 9:23 ` Daniel Romell 2016-09-15 11:48 ` Jacek Anaszewski 0 siblings, 1 reply; 4+ messages in thread From: Daniel Romell @ 2016-09-14 9:23 UTC (permalink / raw) To: rpurdie, j.anaszewski; +Cc: linux-leds, linux-kernel, Daniel Romell In led_trigger_remove(), check if there is a trigger configured before calling led_trigger_set(). This will prevent some unnecessary work, and more importantly stop sending uevent change events when no change has in fact occurred. Signed-off-by: Daniel Romell <daro@hms.se> --- drivers/leds/led-triggers.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/leds/led-triggers.c b/drivers/leds/led-triggers.c index 59d6a3e..28c7a66 100644 --- a/drivers/leds/led-triggers.c +++ b/drivers/leds/led-triggers.c @@ -147,7 +147,8 @@ EXPORT_SYMBOL_GPL(led_trigger_set); void led_trigger_remove(struct led_classdev *led_cdev) { down_write(&led_cdev->trigger_lock); - led_trigger_set(led_cdev, NULL); + if (led_cdev->trigger) + led_trigger_set(led_cdev, NULL); up_write(&led_cdev->trigger_lock); } EXPORT_SYMBOL_GPL(led_trigger_remove); -- 2.7.4 ^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] leds: Only remove trigger if one is actually configured. 2016-09-14 9:23 ` [PATCH] leds: Only remove trigger if one is actually configured Daniel Romell @ 2016-09-15 11:48 ` Jacek Anaszewski 2016-09-20 7:38 ` Jacek Anaszewski 0 siblings, 1 reply; 4+ messages in thread From: Jacek Anaszewski @ 2016-09-15 11:48 UTC (permalink / raw) To: Daniel Romell, rpurdie; +Cc: linux-leds, linux-kernel, Daniel Romell Hi Daniel, On 09/14/2016 11:23 AM, Daniel Romell wrote: > In led_trigger_remove(), check if there is a trigger > configured before calling led_trigger_set(). This will > prevent some unnecessary work, and more importantly stop > sending uevent change events when no change has in fact > occurred. > > Signed-off-by: Daniel Romell <daro@hms.se> > --- > drivers/leds/led-triggers.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/drivers/leds/led-triggers.c b/drivers/leds/led-triggers.c > index 59d6a3e..28c7a66 100644 > --- a/drivers/leds/led-triggers.c > +++ b/drivers/leds/led-triggers.c > @@ -147,7 +147,8 @@ EXPORT_SYMBOL_GPL(led_trigger_set); > void led_trigger_remove(struct led_classdev *led_cdev) > { > down_write(&led_cdev->trigger_lock); > - led_trigger_set(led_cdev, NULL); > + if (led_cdev->trigger) > + led_trigger_set(led_cdev, NULL); > up_write(&led_cdev->trigger_lock); > } > EXPORT_SYMBOL_GPL(led_trigger_remove); > Thanks for the patch. Applied. -- Best regards, Jacek Anaszewski ^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] leds: Only remove trigger if one is actually configured. 2016-09-15 11:48 ` Jacek Anaszewski @ 2016-09-20 7:38 ` Jacek Anaszewski 2016-09-20 12:53 ` Daniel Romell 0 siblings, 1 reply; 4+ messages in thread From: Jacek Anaszewski @ 2016-09-20 7:38 UTC (permalink / raw) To: Daniel Romell, rpurdie; +Cc: linux-leds, linux-kernel, Daniel Romell Hi Daniel, I dropped that patch because we need to fix the problem at the origin, i.e. inside led_trigger_set(). I submitted the patch [0] doing that, and credited you by adding Reported-by tag to the commit message. Thanks, Jacek Anaszewski On 09/15/2016 01:48 PM, Jacek Anaszewski wrote: > Hi Daniel, > > On 09/14/2016 11:23 AM, Daniel Romell wrote: >> In led_trigger_remove(), check if there is a trigger >> configured before calling led_trigger_set(). This will >> prevent some unnecessary work, and more importantly stop >> sending uevent change events when no change has in fact >> occurred. >> >> Signed-off-by: Daniel Romell <daro@hms.se> >> --- >> drivers/leds/led-triggers.c | 3 ++- >> 1 file changed, 2 insertions(+), 1 deletion(-) >> >> diff --git a/drivers/leds/led-triggers.c b/drivers/leds/led-triggers.c >> index 59d6a3e..28c7a66 100644 >> --- a/drivers/leds/led-triggers.c >> +++ b/drivers/leds/led-triggers.c >> @@ -147,7 +147,8 @@ EXPORT_SYMBOL_GPL(led_trigger_set); >> void led_trigger_remove(struct led_classdev *led_cdev) >> { >> down_write(&led_cdev->trigger_lock); >> - led_trigger_set(led_cdev, NULL); >> + if (led_cdev->trigger) >> + led_trigger_set(led_cdev, NULL); >> up_write(&led_cdev->trigger_lock); >> } >> EXPORT_SYMBOL_GPL(led_trigger_remove); >> > > Thanks for the patch. Applied. > [0] https://git.kernel.org/cgit/linux/kernel/git/j.anaszewski/linux-leds.git/commit/?h=for-next&id=19afa7b4c4c9deebd312d293df2e2703de29e26a ^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] leds: Only remove trigger if one is actually configured. 2016-09-20 7:38 ` Jacek Anaszewski @ 2016-09-20 12:53 ` Daniel Romell 0 siblings, 0 replies; 4+ messages in thread From: Daniel Romell @ 2016-09-20 12:53 UTC (permalink / raw) To: Jacek Anaszewski, rpurdie; +Cc: linux-leds, linux-kernel Hi, Yeah, I agree that was a better solution. I'll respond with an ACK on that patch as well. / Daniel Romell ^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2016-09-20 19:24 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <CGME20160914092340eucas1p27f875a415de6684be5b09872ab1b9ab6@eucas1p2.samsung.com>
2016-09-14 9:23 ` [PATCH] leds: Only remove trigger if one is actually configured Daniel Romell
2016-09-15 11:48 ` Jacek Anaszewski
2016-09-20 7:38 ` Jacek Anaszewski
2016-09-20 12:53 ` Daniel Romell
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®