* [RESEND PATCH] ACPI: CPPC: Support PCC with interrupt flag
@ 2016-09-14 17:54 Hoan Tran
2016-09-26 12:56 ` Rafael J. Wysocki
0 siblings, 1 reply; 2+ messages in thread
From: Hoan Tran @ 2016-09-14 17:54 UTC (permalink / raw)
To: Rafael J. Wysocki, Len Brown, pprakash, Ashwin Chaugule
Cc: linux-acpi, linux-kernel, lho, Duc Dang, Hoan Tran
For PCC mailbox with interrupt flag, CPPC should call mbox_chan_txdone()
function to notify the mailbox framework about TX completion.
Signed-off-by: Hoan Tran <hotran@apm.com>
Reviewed-by: Prashanth Prakash <pprakash@codeaurora.org>
---
drivers/acpi/cppc_acpi.c | 5 ++++-
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/drivers/acpi/cppc_acpi.c b/drivers/acpi/cppc_acpi.c
index 3d1ae6d..d0d0504 100644
--- a/drivers/acpi/cppc_acpi.c
+++ b/drivers/acpi/cppc_acpi.c
@@ -311,7 +311,10 @@ static int send_pcc_cmd(u16 cmd)
if (pcc_data.pcc_mrtt)
last_cmd_cmpl_time = ktime_get();
- mbox_client_txdone(pcc_data.pcc_channel, ret);
+ if (pcc_data.pcc_channel->mbox->txdone_irq)
+ mbox_chan_txdone(pcc_data.pcc_channel, ret);
+ else
+ mbox_client_txdone(pcc_data.pcc_channel, ret);
end:
if (cmd == CMD_WRITE) {
--
1.9.1
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [RESEND PATCH] ACPI: CPPC: Support PCC with interrupt flag
2016-09-14 17:54 [RESEND PATCH] ACPI: CPPC: Support PCC with interrupt flag Hoan Tran
@ 2016-09-26 12:56 ` Rafael J. Wysocki
0 siblings, 0 replies; 2+ messages in thread
From: Rafael J. Wysocki @ 2016-09-26 12:56 UTC (permalink / raw)
To: Hoan Tran
Cc: Len Brown, pprakash, Ashwin Chaugule, linux-acpi, linux-kernel,
lho, Duc Dang
On Wednesday, September 14, 2016 10:54:58 AM Hoan Tran wrote:
> For PCC mailbox with interrupt flag, CPPC should call mbox_chan_txdone()
> function to notify the mailbox framework about TX completion.
>
> Signed-off-by: Hoan Tran <hotran@apm.com>
> Reviewed-by: Prashanth Prakash <pprakash@codeaurora.org>
> ---
> drivers/acpi/cppc_acpi.c | 5 ++++-
> 1 file changed, 4 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/acpi/cppc_acpi.c b/drivers/acpi/cppc_acpi.c
> index 3d1ae6d..d0d0504 100644
> --- a/drivers/acpi/cppc_acpi.c
> +++ b/drivers/acpi/cppc_acpi.c
> @@ -311,7 +311,10 @@ static int send_pcc_cmd(u16 cmd)
> if (pcc_data.pcc_mrtt)
> last_cmd_cmpl_time = ktime_get();
>
> - mbox_client_txdone(pcc_data.pcc_channel, ret);
> + if (pcc_data.pcc_channel->mbox->txdone_irq)
> + mbox_chan_txdone(pcc_data.pcc_channel, ret);
> + else
> + mbox_client_txdone(pcc_data.pcc_channel, ret);
>
> end:
> if (cmd == CMD_WRITE) {
>
Applied.
Thanks,
Rafael
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2016-09-26 12:49 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-09-14 17:54 [RESEND PATCH] ACPI: CPPC: Support PCC with interrupt flag Hoan Tran
2016-09-26 12:56 ` Rafael J. Wysocki
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®