* [PATCH v2] leds: triggers: Check return value of kobject_uevent_env()
@ 2016-09-19 10:05 Jacek Anaszewski
2016-09-19 10:19 ` Joe Perches
0 siblings, 1 reply; 2+ messages in thread
From: Jacek Anaszewski @ 2016-09-19 10:05 UTC (permalink / raw)
To: linux-leds; +Cc: linux-kernel, greg, Jacek Anaszewski
Log error message if kobject_uevent_env() fails in led_trigger_set().
Signed-off-by: Jacek Anaszewski <j.anaszewski@samsung.com>
---
Changes from v1:
- switched to using dev_err() instead of pr_err()
drivers/leds/led-triggers.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/drivers/leds/led-triggers.c b/drivers/leds/led-triggers.c
index c7a38d4..26b3db1 100644
--- a/drivers/leds/led-triggers.c
+++ b/drivers/leds/led-triggers.c
@@ -141,7 +141,9 @@ void led_trigger_set(struct led_classdev *led_cdev, struct led_trigger *trig)
if (event) {
envp[0] = event;
envp[1] = NULL;
- kobject_uevent_env(&led_cdev->dev->kobj, KOBJ_CHANGE, envp);
+ if (kobject_uevent_env(&led_cdev->dev->kobj, KOBJ_CHANGE, envp))
+ dev_err(led_cdev->dev,
+ "led_trigger_set: Error sending uevent\n");
kfree(event);
}
}
--
1.9.1
^ permalink raw reply [flat|nested] 2+ messages in thread* Re: [PATCH v2] leds: triggers: Check return value of kobject_uevent_env()
2016-09-19 10:05 [PATCH v2] leds: triggers: Check return value of kobject_uevent_env() Jacek Anaszewski
@ 2016-09-19 10:19 ` Joe Perches
0 siblings, 0 replies; 2+ messages in thread
From: Joe Perches @ 2016-09-19 10:19 UTC (permalink / raw)
To: Jacek Anaszewski, linux-leds; +Cc: linux-kernel, greg
On Mon, 2016-09-19 at 12:05 +0200, Jacek Anaszewski wrote:
> Log error message if kobject_uevent_env() fails in led_trigger_set().
trivia:
> diff --git a/drivers/leds/led-triggers.c b/drivers/leds/led-triggers.c
[]
> @@ -141,7 +141,9 @@ void led_trigger_set(struct led_classdev *led_cdev, struct led_trigger *trig)
> if (event) {
> envp[0] = event;
> envp[1] = NULL;
> - kobject_uevent_env(&led_cdev->dev->kobj, KOBJ_CHANGE, envp);
> + if (kobject_uevent_env(&led_cdev->dev->kobj, KOBJ_CHANGE, envp))
> + dev_err(led_cdev->dev,
> + "led_trigger_set: Error sending uevent\n");
It is generally better to use %s, __func__ than to embed
a function name in the format string.
+ dev_err(led_cdev->dev, "%s: Error sending uevent\n",
+ __func__);
Then Function renaming and code refactoring is less
error prone.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2016-09-19 10:19 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-09-19 10:05 [PATCH v2] leds: triggers: Check return value of kobject_uevent_env() Jacek Anaszewski
2016-09-19 10:19 ` Joe Perches
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome