* [PATCH v3 1/5] staging: nvec: Remove unnecessary cast on void pointer
2017-03-03 11:35 [PATCH v3 0/5] Fixed compilation error simran singhal
@ 2017-03-03 11:35 ` simran singhal
2017-03-03 11:35 ` [PATCH v3 2/5] staging: lustre: " simran singhal
` (4 subsequent siblings)
5 siblings, 0 replies; 11+ messages in thread
From: simran singhal @ 2017-03-03 11:35 UTC (permalink / raw)
To: Larry.Finger
Cc: florian.c.schilhabel, gregkh, devel, linux-kernel, oleg.drokin,
marvin24, outreachy-kernel
The following Coccinelle script was used to detect this:
@r@
expression x;
void* e;
type T;
identifier f;
@@
(
*((T *)e)
|
((T *)x)[...]
|
((T*)x)->f
|
- (T*)
e
)
Signed-off-by: simran singhal <singhalsimran0@gmail.com>
---
drivers/staging/nvec/nvec_kbd.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/nvec/nvec_kbd.c b/drivers/staging/nvec/nvec_kbd.c
index e881e6b..a01f486 100644
--- a/drivers/staging/nvec/nvec_kbd.c
+++ b/drivers/staging/nvec/nvec_kbd.c
@@ -58,7 +58,7 @@ static int nvec_keys_notifier(struct notifier_block *nb,
unsigned long event_type, void *data)
{
int code, state;
- unsigned char *msg = (unsigned char *)data;
+ unsigned char *msg = data;
if (event_type == NVEC_KB_EVT) {
int _size = (msg[0] & (3 << 5)) >> 5;
--
2.7.4
^ permalink raw reply [flat|nested] 11+ messages in thread* [PATCH v3 2/5] staging: lustre: Remove unnecessary cast on void pointer
2017-03-03 11:35 [PATCH v3 0/5] Fixed compilation error simran singhal
2017-03-03 11:35 ` [PATCH v3 1/5] staging: nvec: Remove unnecessary cast on void pointer simran singhal
@ 2017-03-03 11:35 ` simran singhal
2017-03-03 11:35 ` [PATCH v3 3/5] staging: lustre: " simran singhal
` (3 subsequent siblings)
5 siblings, 0 replies; 11+ messages in thread
From: simran singhal @ 2017-03-03 11:35 UTC (permalink / raw)
To: Larry.Finger
Cc: florian.c.schilhabel, gregkh, devel, linux-kernel, oleg.drokin,
marvin24, outreachy-kernel
The following Coccinelle script was used to detect this:
@r@
expression x;
void* e;
type T;
identifier f;
@@
(
*((T *)e)
|
((T *)x)[...]
|
((T*)x)->f
|
- (T*)
e
)
Signed-off-by: simran singhal <singhalsimran0@gmail.com>
---
drivers/staging/lustre/lustre/lmv/lmv_obd.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/lustre/lustre/lmv/lmv_obd.c b/drivers/staging/lustre/lustre/lmv/lmv_obd.c
index 271e189..09b46924 100644
--- a/drivers/staging/lustre/lustre/lmv/lmv_obd.c
+++ b/drivers/staging/lustre/lustre/lmv/lmv_obd.c
@@ -640,7 +640,7 @@ static int lmv_fid2path(struct obd_export *exp, int len, void *karg,
int remote_gf_size = 0;
int rc;
- gf = (struct getinfo_fid2path *)karg;
+ gf = karg;
tgt = lmv_find_target(lmv, &gf->gf_fid);
if (IS_ERR(tgt))
return PTR_ERR(tgt);
@@ -657,7 +657,7 @@ static int lmv_fid2path(struct obd_export *exp, int len, void *karg,
struct getinfo_fid2path *ori_gf;
char *ptr;
- ori_gf = (struct getinfo_fid2path *)karg;
+ ori_gf = karg;
if (strlen(ori_gf->gf_path) +
strlen(gf->gf_path) > ori_gf->gf_pathlen) {
rc = -EOVERFLOW;
--
2.7.4
^ permalink raw reply [flat|nested] 11+ messages in thread* [PATCH v3 3/5] staging: lustre: lustre: Remove unnecessary cast on void pointer
2017-03-03 11:35 [PATCH v3 0/5] Fixed compilation error simran singhal
2017-03-03 11:35 ` [PATCH v3 1/5] staging: nvec: Remove unnecessary cast on void pointer simran singhal
2017-03-03 11:35 ` [PATCH v3 2/5] staging: lustre: " simran singhal
@ 2017-03-03 11:35 ` simran singhal
2017-03-03 11:35 ` [PATCH v3 4/5] staging: rts5208: " simran singhal
` (2 subsequent siblings)
5 siblings, 0 replies; 11+ messages in thread
From: simran singhal @ 2017-03-03 11:35 UTC (permalink / raw)
To: Larry.Finger
Cc: florian.c.schilhabel, gregkh, devel, linux-kernel, oleg.drokin,
marvin24, outreachy-kernel
The following Coccinelle script was used to detect this:
@r@
expression x;
void* e;
type T;
identifier f;
@@
(
*((T *)e)
|
((T *)x)[...]
|
((T*)x)->f
|
- (T*)
e
)
Signed-off-by: simran singhal <singhalsimran0@gmail.com>
---
drivers/staging/lustre/lustre/llite/range_lock.c | 2 +-
drivers/staging/lustre/lustre/mgc/mgc_request.c | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/lustre/lustre/llite/range_lock.c b/drivers/staging/lustre/lustre/llite/range_lock.c
index 14148a0..161391b 100644
--- a/drivers/staging/lustre/lustre/llite/range_lock.c
+++ b/drivers/staging/lustre/lustre/llite/range_lock.c
@@ -174,7 +174,7 @@ void range_unlock(struct range_lock_tree *tree, struct range_lock *lock)
*/
static enum interval_iter range_lock_cb(struct interval_node *node, void *arg)
{
- struct range_lock *lock = (struct range_lock *)arg;
+ struct range_lock *lock = arg;
struct range_lock *overlap = node2rangelock(node);
lock->rl_blocking_ranges += overlap->rl_lock_count + 1;
diff --git a/drivers/staging/lustre/lustre/mgc/mgc_request.c b/drivers/staging/lustre/lustre/mgc/mgc_request.c
index 6a76605..8ca0a04 100644
--- a/drivers/staging/lustre/lustre/mgc/mgc_request.c
+++ b/drivers/staging/lustre/lustre/mgc/mgc_request.c
@@ -1050,7 +1050,7 @@ static int mgc_set_info_async(const struct lu_env *env, struct obd_export *exp,
sptlrpc_flavor2name(&cli->cl_flvr_mgc,
str, sizeof(str));
LCONSOLE_ERROR("asking sptlrpc flavor %s to MGS but currently %s is in use\n",
- (char *)val, str);
+ val, str);
rc = -EPERM;
}
return rc;
--
2.7.4
^ permalink raw reply [flat|nested] 11+ messages in thread* [PATCH v3 4/5] staging: rts5208: Remove unnecessary cast on void pointer
2017-03-03 11:35 [PATCH v3 0/5] Fixed compilation error simran singhal
` (2 preceding siblings ...)
2017-03-03 11:35 ` [PATCH v3 3/5] staging: lustre: " simran singhal
@ 2017-03-03 11:35 ` simran singhal
2017-03-03 11:35 ` [PATCH v3 5/5] staging: rtl8712: " simran singhal
2017-03-03 15:50 ` [PATCH v3 0/5] Fixed compilation error Joe Perches
5 siblings, 0 replies; 11+ messages in thread
From: simran singhal @ 2017-03-03 11:35 UTC (permalink / raw)
To: Larry.Finger
Cc: florian.c.schilhabel, gregkh, devel, linux-kernel, oleg.drokin,
marvin24, outreachy-kernel
The following Coccinelle script was used to detect this:
@r@
expression x;
void* e;
type T;
identifier f;
@@
(
*((T *)e)
|
((T *)x)[...]
|
((T*)x)->f
|
- (T*)
e
)
Signed-off-by: simran singhal <singhalsimran0@gmail.com>
---
drivers/staging/rts5208/rtsx_transport.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/staging/rts5208/rtsx_transport.c b/drivers/staging/rts5208/rtsx_transport.c
index 2379901..8b57e17 100644
--- a/drivers/staging/rts5208/rtsx_transport.c
+++ b/drivers/staging/rts5208/rtsx_transport.c
@@ -766,8 +766,7 @@ int rtsx_transfer_data(struct rtsx_chip *chip, u8 card, void *buf, size_t len,
return -EIO;
if (use_sg) {
- err = rtsx_transfer_sglist_adma(chip, card,
- (struct scatterlist *)buf,
+ err = rtsx_transfer_sglist_adma(chip, card, buf,
use_sg, dma_dir, timeout);
} else {
err = rtsx_transfer_buf(chip, card, buf, len, dma_dir, timeout);
--
2.7.4
^ permalink raw reply [flat|nested] 11+ messages in thread* [PATCH v3 5/5] staging: rtl8712: Remove unnecessary cast on void pointer
2017-03-03 11:35 [PATCH v3 0/5] Fixed compilation error simran singhal
` (3 preceding siblings ...)
2017-03-03 11:35 ` [PATCH v3 4/5] staging: rts5208: " simran singhal
@ 2017-03-03 11:35 ` simran singhal
2017-03-03 15:50 ` [PATCH v3 0/5] Fixed compilation error Joe Perches
5 siblings, 0 replies; 11+ messages in thread
From: simran singhal @ 2017-03-03 11:35 UTC (permalink / raw)
To: Larry.Finger
Cc: florian.c.schilhabel, gregkh, devel, linux-kernel, oleg.drokin,
marvin24, outreachy-kernel
The following Coccinelle script was used to detect this:
@r@
expression x;
void* e;
type T;
identifier f;
@@
(
*((T *)e)
|
((T *)x)[...]
|
((T*)x)->f
|
- (T*)
e
)
Signed-off-by: simran singhal <singhalsimran0@gmail.com>
---
drivers/staging/rtl8712/rtl8712_recv.c | 11 +++++------
1 file changed, 5 insertions(+), 6 deletions(-)
diff --git a/drivers/staging/rtl8712/rtl8712_recv.c b/drivers/staging/rtl8712/rtl8712_recv.c
index 20fe45a..266ffef 100644
--- a/drivers/staging/rtl8712/rtl8712_recv.c
+++ b/drivers/staging/rtl8712/rtl8712_recv.c
@@ -444,9 +444,9 @@ void r8712_rxcmd_event_hdl(struct _adapter *padapter, void *prxcmdbuf)
u16 cmd_len, drvinfo_sz;
struct recv_stat *prxstat;
- poffset = (u8 *)prxcmdbuf;
+ poffset = prxcmdbuf;
voffset = *(__le32 *)poffset;
- prxstat = (struct recv_stat *)prxcmdbuf;
+ prxstat = prxcmdbuf;
drvinfo_sz = (le32_to_cpu(prxstat->rxdw0) & 0x000f0000) >> 16;
drvinfo_sz <<= 3;
poffset += RXDESC_SIZE + drvinfo_sz;
@@ -634,8 +634,7 @@ static int recv_indicatepkt_reorder(struct _adapter *padapter,
void r8712_reordering_ctrl_timeout_handler(void *pcontext)
{
unsigned long irql;
- struct recv_reorder_ctrl *preorder_ctrl =
- (struct recv_reorder_ctrl *)pcontext;
+ struct recv_reorder_ctrl *preorder_ctrl = pcontext;
struct _adapter *padapter = preorder_ctrl->padapter;
struct __queue *ppending_recvframe_queue =
&preorder_ctrl->pending_recvframe_queue;
@@ -976,7 +975,7 @@ int recv_func(struct _adapter *padapter, void *pcontext)
struct __queue *pfree_recv_queue = &padapter->recvpriv.free_recv_queue;
struct mlme_priv *pmlmepriv = &padapter->mlmepriv;
- prframe = (union recv_frame *)pcontext;
+ prframe = pcontext;
orig_prframe = prframe;
pattrib = &prframe->u.hdr.attrib;
if (check_fwstate(pmlmepriv, WIFI_MP_STATE)) {
@@ -1124,7 +1123,7 @@ static int recvbuf2recvframe(struct _adapter *padapter, struct sk_buff *pskb)
static void recv_tasklet(void *priv)
{
struct sk_buff *pskb;
- struct _adapter *padapter = (struct _adapter *)priv;
+ struct _adapter *padapter = priv;
struct recv_priv *precvpriv = &padapter->recvpriv;
while (NULL != (pskb = skb_dequeue(&precvpriv->rx_skb_queue))) {
--
2.7.4
^ permalink raw reply [flat|nested] 11+ messages in thread* Re: [PATCH v3 0/5] Fixed compilation error
2017-03-03 11:35 [PATCH v3 0/5] Fixed compilation error simran singhal
` (4 preceding siblings ...)
2017-03-03 11:35 ` [PATCH v3 5/5] staging: rtl8712: " simran singhal
@ 2017-03-03 15:50 ` Joe Perches
2017-03-03 16:05 ` SIMRAN SINGHAL
5 siblings, 1 reply; 11+ messages in thread
From: Joe Perches @ 2017-03-03 15:50 UTC (permalink / raw)
To: simran singhal, Larry.Finger
Cc: florian.c.schilhabel, gregkh, devel, linux-kernel, oleg.drokin,
marvin24, outreachy-kernel
On Fri, 2017-03-03 at 17:05 +0530, simran singhal wrote:
> Fixed compilation warning in lustre/lustre/llite/range_lock.c
Really? What compilation warning was removed?
> simran singhal (5):
> staging: nvec: Remove unnecessary cast on void pointer
> staging: lustre: Remove unnecessary cast on void pointer
> staging: lustre: lustre: Remove unnecessary cast on void pointer
> staging: rts5208: Remove unnecessary cast on void pointer
> staging: rtl8712: Remove unnecessary cast on void pointer
What compiler warns about unnecessary casts?
> drivers/staging/lustre/lustre/llite/range_lock.c | 2 +-
> drivers/staging/lustre/lustre/lmv/lmv_obd.c | 4 ++--
> drivers/staging/lustre/lustre/mgc/mgc_request.c | 2 +-
> drivers/staging/nvec/nvec_kbd.c | 2 +-
> drivers/staging/rtl8712/rtl8712_recv.c | 11 +++++------
> drivers/staging/rts5208/rtsx_transport.c | 3 +--
> 6 files changed, 11 insertions(+), 13 deletions(-)
>
^ permalink raw reply [flat|nested] 11+ messages in thread* Re: [PATCH v3 0/5] Fixed compilation error
2017-03-03 15:50 ` [PATCH v3 0/5] Fixed compilation error Joe Perches
@ 2017-03-03 16:05 ` SIMRAN SINGHAL
2017-03-03 16:15 ` [Outreachy kernel] " Julia Lawall
2017-03-03 20:13 ` Joe Perches
0 siblings, 2 replies; 11+ messages in thread
From: SIMRAN SINGHAL @ 2017-03-03 16:05 UTC (permalink / raw)
To: Joe Perches
Cc: Larry.Finger, Florian Schilhabel, Greg KH, devel, linux-kernel,
oleg.drokin, marvin24, outreachy-kernel
On Fri, Mar 3, 2017 at 9:20 PM, Joe Perches <joe@perches.com> wrote:
> On Fri, 2017-03-03 at 17:05 +0530, simran singhal wrote:
>> Fixed compilation warning in lustre/lustre/llite/range_lock.c
>
> Really? What compilation warning was removed?
CC [M] drivers/staging/lustre/lustre/mgc/mgc_request.o
drivers/staging/lustre/lustre/mgc/mgc_request.c: In function
‘mgc_set_info_async’:
drivers/staging/lustre/lustre/mgc/mgc_request.c:1036:115: warning:
format ‘%s’ expects argument of type ‘char *’, but argument 3 has type
‘void *’ [-Wformat=]
I was getting this warning because of changing (char *)val to val
where val is a pointer to void.
So I fixed this by reverting this change.
Simran
>
>> simran singhal (5):
>> staging: nvec: Remove unnecessary cast on void pointer
>> staging: lustre: Remove unnecessary cast on void pointer
>> staging: lustre: lustre: Remove unnecessary cast on void pointer
>> staging: rts5208: Remove unnecessary cast on void pointer
>> staging: rtl8712: Remove unnecessary cast on void pointer
>
> What compiler warns about unnecessary casts?
>
>> drivers/staging/lustre/lustre/llite/range_lock.c | 2 +-
>> drivers/staging/lustre/lustre/lmv/lmv_obd.c | 4 ++--
>> drivers/staging/lustre/lustre/mgc/mgc_request.c | 2 +-
>> drivers/staging/nvec/nvec_kbd.c | 2 +-
>> drivers/staging/rtl8712/rtl8712_recv.c | 11 +++++------
>> drivers/staging/rts5208/rtsx_transport.c | 3 +--
>> 6 files changed, 11 insertions(+), 13 deletions(-)
>>
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [Outreachy kernel] Re: [PATCH v3 0/5] Fixed compilation error
2017-03-03 16:05 ` SIMRAN SINGHAL
@ 2017-03-03 16:15 ` Julia Lawall
2017-03-03 16:37 ` SIMRAN SINGHAL
2017-03-03 20:13 ` Joe Perches
1 sibling, 1 reply; 11+ messages in thread
From: Julia Lawall @ 2017-03-03 16:15 UTC (permalink / raw)
To: SIMRAN SINGHAL
Cc: Joe Perches, Larry.Finger, Florian Schilhabel, Greg KH, devel,
linux-kernel, oleg.drokin, marvin24, outreachy-kernel
[-- Attachment #1: Type: text/plain, Size: 2394 bytes --]
On Fri, 3 Mar 2017, SIMRAN SINGHAL wrote:
> On Fri, Mar 3, 2017 at 9:20 PM, Joe Perches <joe@perches.com> wrote:
> > On Fri, 2017-03-03 at 17:05 +0530, simran singhal wrote:
> >> Fixed compilation warning in lustre/lustre/llite/range_lock.c
> >
> > Really? What compilation warning was removed?
>
> CC [M] drivers/staging/lustre/lustre/mgc/mgc_request.o
> drivers/staging/lustre/lustre/mgc/mgc_request.c: In function
> ‘mgc_set_info_async’:
> drivers/staging/lustre/lustre/mgc/mgc_request.c:1036:115: warning:
> format ‘%s’ expects argument of type ‘char *’, but argument 3 has type
> ‘void *’ [-Wformat=]
>
> I was getting this warning because of changing (char *)val to val
> where val is a pointer to void.
> So I fixed this by reverting this change.
Someone pointed out recently that when you make the cover letter for vn+1,
the subject should not change. It doesn't describe what is new in the
version. You put that in the message.
julia
>
> Simran
>
> >
> >> simran singhal (5):
> >> staging: nvec: Remove unnecessary cast on void pointer
> >> staging: lustre: Remove unnecessary cast on void pointer
> >> staging: lustre: lustre: Remove unnecessary cast on void pointer
> >> staging: rts5208: Remove unnecessary cast on void pointer
> >> staging: rtl8712: Remove unnecessary cast on void pointer
> >
> > What compiler warns about unnecessary casts?
> >
> >> drivers/staging/lustre/lustre/llite/range_lock.c | 2 +-
> >> drivers/staging/lustre/lustre/lmv/lmv_obd.c | 4 ++--
> >> drivers/staging/lustre/lustre/mgc/mgc_request.c | 2 +-
> >> drivers/staging/nvec/nvec_kbd.c | 2 +-
> >> drivers/staging/rtl8712/rtl8712_recv.c | 11 +++++------
> >> drivers/staging/rts5208/rtsx_transport.c | 3 +--
> >> 6 files changed, 11 insertions(+), 13 deletions(-)
> >>
>
> --
> You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to outreachy-kernel+unsubscribe@googlegroups.com.
> To post to this group, send email to outreachy-kernel@googlegroups.com.
> To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/CALrZqyMKJvhQMAdjtLWWKTtxOP%2BicRZ6bctB0bTtzA8gJi%2BwNA%40mail.gmail.com.
> For more options, visit https://groups.google.com/d/optout.
>
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [Outreachy kernel] Re: [PATCH v3 0/5] Fixed compilation error
2017-03-03 16:15 ` [Outreachy kernel] " Julia Lawall
@ 2017-03-03 16:37 ` SIMRAN SINGHAL
0 siblings, 0 replies; 11+ messages in thread
From: SIMRAN SINGHAL @ 2017-03-03 16:37 UTC (permalink / raw)
To: Julia Lawall
Cc: Joe Perches, Larry.Finger, Florian Schilhabel, Greg KH, devel,
linux-kernel, oleg.drokin, marvin24, outreachy-kernel
On Fri, Mar 3, 2017 at 9:45 PM, Julia Lawall <julia.lawall@lip6.fr> wrote:
>
>
> On Fri, 3 Mar 2017, SIMRAN SINGHAL wrote:
>
>> On Fri, Mar 3, 2017 at 9:20 PM, Joe Perches <joe@perches.com> wrote:
>> > On Fri, 2017-03-03 at 17:05 +0530, simran singhal wrote:
>> >> Fixed compilation warning in lustre/lustre/llite/range_lock.c
>> >
>> > Really? What compilation warning was removed?
>>
>> CC [M] drivers/staging/lustre/lustre/mgc/mgc_request.o
>> drivers/staging/lustre/lustre/mgc/mgc_request.c: In function
>> ‘mgc_set_info_async’:
>> drivers/staging/lustre/lustre/mgc/mgc_request.c:1036:115: warning:
>> format ‘%s’ expects argument of type ‘char *’, but argument 3 has type
>> ‘void *’ [-Wformat=]
>>
>> I was getting this warning because of changing (char *)val to val
>> where val is a pointer to void.
>> So I fixed this by reverting this change.
>
> Someone pointed out recently that when you make the cover letter for vn+1,
> the subject should not change. It doesn't describe what is new in the
> version. You put that in the message.
>
I will resend the complete patch series with changed subject of cover-patch.
> julia
>
>>
>> Simran
>>
>> >
>> >> simran singhal (5):
>> >> staging: nvec: Remove unnecessary cast on void pointer
>> >> staging: lustre: Remove unnecessary cast on void pointer
>> >> staging: lustre: lustre: Remove unnecessary cast on void pointer
>> >> staging: rts5208: Remove unnecessary cast on void pointer
>> >> staging: rtl8712: Remove unnecessary cast on void pointer
>> >
>> > What compiler warns about unnecessary casts?
>> >
>> >> drivers/staging/lustre/lustre/llite/range_lock.c | 2 +-
>> >> drivers/staging/lustre/lustre/lmv/lmv_obd.c | 4 ++--
>> >> drivers/staging/lustre/lustre/mgc/mgc_request.c | 2 +-
>> >> drivers/staging/nvec/nvec_kbd.c | 2 +-
>> >> drivers/staging/rtl8712/rtl8712_recv.c | 11 +++++------
>> >> drivers/staging/rts5208/rtsx_transport.c | 3 +--
>> >> 6 files changed, 11 insertions(+), 13 deletions(-)
>> >>
>>
>> --
>> You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
>> To unsubscribe from this group and stop receiving emails from it, send an email to outreachy-kernel+unsubscribe@googlegroups.com.
>> To post to this group, send email to outreachy-kernel@googlegroups.com.
>> To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/CALrZqyMKJvhQMAdjtLWWKTtxOP%2BicRZ6bctB0bTtzA8gJi%2BwNA%40mail.gmail.com.
>> For more options, visit https://groups.google.com/d/optout.
>>
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH v3 0/5] Fixed compilation error
2017-03-03 16:05 ` SIMRAN SINGHAL
2017-03-03 16:15 ` [Outreachy kernel] " Julia Lawall
@ 2017-03-03 20:13 ` Joe Perches
1 sibling, 0 replies; 11+ messages in thread
From: Joe Perches @ 2017-03-03 20:13 UTC (permalink / raw)
To: SIMRAN SINGHAL
Cc: Larry.Finger, Florian Schilhabel, Greg KH, devel, linux-kernel,
oleg.drokin, marvin24, outreachy-kernel
On Fri, 2017-03-03 at 21:35 +0530, SIMRAN SINGHAL wrote:
> On Fri, Mar 3, 2017 at 9:20 PM, Joe Perches <joe@perches.com> wrote:
> > On Fri, 2017-03-03 at 17:05 +0530, simran singhal wrote:
> > > Fixed compilation warning in lustre/lustre/llite/range_lock.c
> >
> > Really? What compilation warning was removed?
>
> CC [M] drivers/staging/lustre/lustre/mgc/mgc_request.o
> drivers/staging/lustre/lustre/mgc/mgc_request.c: In function
> ‘mgc_set_info_async’:
> drivers/staging/lustre/lustre/mgc/mgc_request.c:1036:115: warning:
> format ‘%s’ expects argument of type ‘char *’, but argument 3 has type
> ‘void *’ [-Wformat=]
>
> I was getting this warning because of changing (char *)val to val
> where val is a pointer to void.
> So I fixed this by reverting this change.
Wrong thought.
Your original defective patches were not applied and
this is a simple revision to those defective patches
that do not include defects.
As Julia has said, you should use the imperative and
describe the change that this patch series implements.
i.e:
Subject: [PATCH V3 0/5] staging: Remove unnecessary casts
Casting void pointers to another undereferenced type is
generally unnecessary so remove the unnecessary casts.
^ permalink raw reply [flat|nested] 11+ messages in thread