* [PATCH 1/1] time: clocksource: use setup_timer() helper.
@ 2017-09-21 13:13 Allen Pais
2017-10-19 14:30 ` Thomas Gleixner
0 siblings, 1 reply; 2+ messages in thread
From: Allen Pais @ 2017-09-21 13:13 UTC (permalink / raw)
To: linux-kernel; +Cc: john.stultz, tglx, sboyd, Allen Pais
Use setup_timer function instead of initializing timer with the
function and data fields.
Signed-off-by: Allen Pais <allen.lkml@gmail.com>
---
kernel/time/clocksource.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/kernel/time/clocksource.c b/kernel/time/clocksource.c
index 03918a1..5b51d5b 100644
--- a/kernel/time/clocksource.c
+++ b/kernel/time/clocksource.c
@@ -290,8 +290,7 @@ static inline void clocksource_start_watchdog(void)
{
if (watchdog_running || !watchdog || list_empty(&watchdog_list))
return;
- init_timer(&watchdog_timer);
- watchdog_timer.function = clocksource_watchdog;
+ setup_timer(&watchdog_timer, clocksource_watchdog, 0UL);
watchdog_timer.expires = jiffies + WATCHDOG_INTERVAL;
add_timer_on(&watchdog_timer, cpumask_first(cpu_online_mask));
watchdog_running = 1;
--
2.7.4
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH 1/1] time: clocksource: use setup_timer() helper.
2017-09-21 13:13 [PATCH 1/1] time: clocksource: use setup_timer() helper Allen Pais
@ 2017-10-19 14:30 ` Thomas Gleixner
0 siblings, 0 replies; 2+ messages in thread
From: Thomas Gleixner @ 2017-10-19 14:30 UTC (permalink / raw)
To: Allen Pais; +Cc: linux-kernel, john.stultz, sboyd
On Thu, 21 Sep 2017, Allen Pais wrote:
> Use setup_timer function instead of initializing timer with the
> function and data fields.
>
> Signed-off-by: Allen Pais <allen.lkml@gmail.com>
> ---
> kernel/time/clocksource.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/kernel/time/clocksource.c b/kernel/time/clocksource.c
> index 03918a1..5b51d5b 100644
> --- a/kernel/time/clocksource.c
> +++ b/kernel/time/clocksource.c
> @@ -290,8 +290,7 @@ static inline void clocksource_start_watchdog(void)
> {
> if (watchdog_running || !watchdog || list_empty(&watchdog_list))
> return;
> - init_timer(&watchdog_timer);
> - watchdog_timer.function = clocksource_watchdog;
> + setup_timer(&watchdog_timer, clocksource_watchdog, 0UL);
We changed this to use the timer_setup() function. Please resend.
Thanks,
tglx
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2017-10-19 14:30 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-09-21 13:13 [PATCH 1/1] time: clocksource: use setup_timer() helper Allen Pais
2017-10-19 14:30 ` Thomas Gleixner
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®