* [PATCH 1/4] staging: gs_fpgaboot: pr_err() strings should end with newlines
2017-10-03 11:43 [PATCH 0/4] staging: rtlwifi: pr_err() strings should end with newlines Arvind Yadav
@ 2017-10-03 11:43 ` Arvind Yadav
2017-10-03 11:43 ` [PATCH 2/4] staging: media: davinci_vpfe: " Arvind Yadav
` (2 subsequent siblings)
3 siblings, 0 replies; 6+ messages in thread
From: Arvind Yadav @ 2017-10-03 11:43 UTC (permalink / raw)
To: gregkh, jacobvonchorus, mchehab, eric, stefan.wahren, f.fainelli,
rjui, Larry.Finger, pkshih
Cc: devel, linux-kernel, linux-media
pr_err() messages should end with a new-line to avoid other messages
being concatenated.
Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>
---
drivers/staging/gs_fpgaboot/gs_fpgaboot.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/gs_fpgaboot/gs_fpgaboot.c b/drivers/staging/gs_fpgaboot/gs_fpgaboot.c
index bcbdc73..fa8b27e 100644
--- a/drivers/staging/gs_fpgaboot/gs_fpgaboot.c
+++ b/drivers/staging/gs_fpgaboot/gs_fpgaboot.c
@@ -106,7 +106,7 @@ static int readmagic_bitstream(u8 *bitdata, int *offset)
read_bitstream(bitdata, buf, offset, 13);
r = memcmp(buf, bits_magic, 13);
if (r) {
- pr_err("error: corrupted header");
+ pr_err("error: corrupted header\n");
return -EINVAL;
}
pr_info("bitstream file magic number Ok\n");
--
1.9.1
^ permalink raw reply [flat|nested] 6+ messages in thread* [PATCH 2/4] staging: media: davinci_vpfe: pr_err() strings should end with newlines
2017-10-03 11:43 [PATCH 0/4] staging: rtlwifi: pr_err() strings should end with newlines Arvind Yadav
2017-10-03 11:43 ` [PATCH 1/4] staging: gs_fpgaboot: " Arvind Yadav
@ 2017-10-03 11:43 ` Arvind Yadav
2017-10-03 11:43 ` [PATCH 3/4] staging: bcm2835-camera: " Arvind Yadav
2017-10-03 11:43 ` [PATCH 4/4] staging: rtlwifi: " Arvind Yadav
3 siblings, 0 replies; 6+ messages in thread
From: Arvind Yadav @ 2017-10-03 11:43 UTC (permalink / raw)
To: gregkh, jacobvonchorus, mchehab, eric, stefan.wahren, f.fainelli,
rjui, Larry.Finger, pkshih
Cc: devel, linux-kernel, linux-media
pr_err() messages should end with a new-line to avoid other messages
being concatenated.
Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>
---
drivers/staging/media/davinci_vpfe/dm365_ipipe_hw.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/media/davinci_vpfe/dm365_ipipe_hw.c b/drivers/staging/media/davinci_vpfe/dm365_ipipe_hw.c
index a893072..8cfe873 100644
--- a/drivers/staging/media/davinci_vpfe/dm365_ipipe_hw.c
+++ b/drivers/staging/media/davinci_vpfe/dm365_ipipe_hw.c
@@ -268,7 +268,7 @@ int config_ipipe_hw(struct vpfe_ipipe_device *ipipe)
ipipe_mode = get_ipipe_mode(ipipe);
if (ipipe_mode < 0) {
- pr_err("Failed to get ipipe mode");
+ pr_err("Failed to get ipipe mode\n");
return -EINVAL;
}
regw_ip(ipipe_base, ipipe_mode, IPIPE_SRC_MODE);
--
1.9.1
^ permalink raw reply [flat|nested] 6+ messages in thread* [PATCH 3/4] staging: bcm2835-camera: pr_err() strings should end with newlines
2017-10-03 11:43 [PATCH 0/4] staging: rtlwifi: pr_err() strings should end with newlines Arvind Yadav
2017-10-03 11:43 ` [PATCH 1/4] staging: gs_fpgaboot: " Arvind Yadav
2017-10-03 11:43 ` [PATCH 2/4] staging: media: davinci_vpfe: " Arvind Yadav
@ 2017-10-03 11:43 ` Arvind Yadav
2017-10-04 6:20 ` Stefan Wahren
2017-10-03 11:43 ` [PATCH 4/4] staging: rtlwifi: " Arvind Yadav
3 siblings, 1 reply; 6+ messages in thread
From: Arvind Yadav @ 2017-10-03 11:43 UTC (permalink / raw)
To: gregkh, jacobvonchorus, mchehab, eric, stefan.wahren, f.fainelli,
rjui, Larry.Finger, pkshih
Cc: devel, linux-kernel, linux-media
pr_err() messages should end with a new-line to avoid other messages
being concatenated.
Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>
---
drivers/staging/vc04_services/bcm2835-camera/mmal-vchiq.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/vc04_services/bcm2835-camera/mmal-vchiq.c b/drivers/staging/vc04_services/bcm2835-camera/mmal-vchiq.c
index 4360db6..6ea7fb0 100644
--- a/drivers/staging/vc04_services/bcm2835-camera/mmal-vchiq.c
+++ b/drivers/staging/vc04_services/bcm2835-camera/mmal-vchiq.c
@@ -1963,7 +1963,7 @@ int vchiq_mmal_finalise(struct vchiq_mmal_instance *instance)
status = vchi_service_close(instance->handle);
if (status != 0)
- pr_err("mmal-vchiq: VCHIQ close failed");
+ pr_err("mmal-vchiq: VCHIQ close failed\n");
mutex_unlock(&instance->vchiq_mutex);
--
1.9.1
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH 3/4] staging: bcm2835-camera: pr_err() strings should end with newlines
2017-10-03 11:43 ` [PATCH 3/4] staging: bcm2835-camera: " Arvind Yadav
@ 2017-10-04 6:20 ` Stefan Wahren
0 siblings, 0 replies; 6+ messages in thread
From: Stefan Wahren @ 2017-10-04 6:20 UTC (permalink / raw)
To: Arvind Yadav, gregkh, jacobvonchorus, mchehab, eric, f.fainelli,
rjui, Larry.Finger, pkshih
Cc: devel, linux-kernel, linux-media
Am 03.10.2017 um 13:43 schrieb Arvind Yadav:
> pr_err() messages should end with a new-line to avoid other messages
> being concatenated.
>
> Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>
Acked-by: Stefan Wahren <stefan.wahren@i2se.com>
> ---
> drivers/staging/vc04_services/bcm2835-camera/mmal-vchiq.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/vc04_services/bcm2835-camera/mmal-vchiq.c b/drivers/staging/vc04_services/bcm2835-camera/mmal-vchiq.c
> index 4360db6..6ea7fb0 100644
> --- a/drivers/staging/vc04_services/bcm2835-camera/mmal-vchiq.c
> +++ b/drivers/staging/vc04_services/bcm2835-camera/mmal-vchiq.c
> @@ -1963,7 +1963,7 @@ int vchiq_mmal_finalise(struct vchiq_mmal_instance *instance)
>
> status = vchi_service_close(instance->handle);
> if (status != 0)
> - pr_err("mmal-vchiq: VCHIQ close failed");
> + pr_err("mmal-vchiq: VCHIQ close failed\n");
>
> mutex_unlock(&instance->vchiq_mutex);
>
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH 4/4] staging: rtlwifi: pr_err() strings should end with newlines
2017-10-03 11:43 [PATCH 0/4] staging: rtlwifi: pr_err() strings should end with newlines Arvind Yadav
` (2 preceding siblings ...)
2017-10-03 11:43 ` [PATCH 3/4] staging: bcm2835-camera: " Arvind Yadav
@ 2017-10-03 11:43 ` Arvind Yadav
3 siblings, 0 replies; 6+ messages in thread
From: Arvind Yadav @ 2017-10-03 11:43 UTC (permalink / raw)
To: gregkh, jacobvonchorus, mchehab, eric, stefan.wahren, f.fainelli,
rjui, Larry.Finger, pkshih
Cc: devel, linux-kernel, linux-media
pr_err() messages should end with a new-line to avoid other messages
being concatenated.
Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>
---
drivers/staging/rtlwifi/halmac/halmac_88xx/halmac_func_88xx.c | 6 +++---
drivers/staging/rtlwifi/rtl8822be/phy.c | 4 ++--
2 files changed, 5 insertions(+), 5 deletions(-)
diff --git a/drivers/staging/rtlwifi/halmac/halmac_88xx/halmac_func_88xx.c b/drivers/staging/rtlwifi/halmac/halmac_88xx/halmac_func_88xx.c
index f33024e..eeef8b6 100644
--- a/drivers/staging/rtlwifi/halmac/halmac_88xx/halmac_func_88xx.c
+++ b/drivers/staging/rtlwifi/halmac/halmac_88xx/halmac_func_88xx.c
@@ -1036,7 +1036,7 @@ enum halmac_ret_status
if (halmac_send_fwpkt_88xx(
halmac_adapter, code_ptr + mem_offset,
send_pkt_size) != HALMAC_RET_SUCCESS) {
- pr_err("halmac_send_fwpkt_88xx fail!!");
+ pr_err("halmac_send_fwpkt_88xx fail!!\n");
return HALMAC_RET_DLFW_FAIL;
}
@@ -1046,7 +1046,7 @@ enum halmac_ret_status
halmac_adapter->hw_config_info.txdesc_size,
dest + mem_offset, send_pkt_size,
first_part) != HALMAC_RET_SUCCESS) {
- pr_err("halmac_iddma_dlfw_88xx fail!!");
+ pr_err("halmac_iddma_dlfw_88xx fail!!\n");
return HALMAC_RET_DLFW_FAIL;
}
@@ -1057,7 +1057,7 @@ enum halmac_ret_status
if (halmac_check_fw_chksum_88xx(halmac_adapter, dest) !=
HALMAC_RET_SUCCESS) {
- pr_err("halmac_check_fw_chksum_88xx fail!!");
+ pr_err("halmac_check_fw_chksum_88xx fail!!\n");
return HALMAC_RET_DLFW_FAIL;
}
diff --git a/drivers/staging/rtlwifi/rtl8822be/phy.c b/drivers/staging/rtlwifi/rtl8822be/phy.c
index 4cba2ad..921226b 100644
--- a/drivers/staging/rtlwifi/rtl8822be/phy.c
+++ b/drivers/staging/rtlwifi/rtl8822be/phy.c
@@ -890,7 +890,7 @@ bool rtl8822be_load_txpower_by_rate(struct ieee80211_hw *hw)
rtstatus = rtlpriv->phydm.ops->phydm_load_txpower_by_rate(rtlpriv);
if (!rtstatus) {
- pr_err("BB_PG Reg Fail!!");
+ pr_err("BB_PG Reg Fail!!\n");
return false;
}
@@ -915,7 +915,7 @@ bool rtl8822be_load_txpower_limit(struct ieee80211_hw *hw)
rtstatus = rtlpriv->phydm.ops->phydm_load_txpower_limit(rtlpriv);
if (!rtstatus) {
- pr_err("RF TxPwr Limit Fail!!");
+ pr_err("RF TxPwr Limit Fail!!\n");
return false;
}
--
1.9.1
^ permalink raw reply [flat|nested] 6+ messages in thread