* [PATCH] memory hotplug: fix comments when add section
@ 2017-11-15 8:40 Fan Du
2017-11-15 9:18 ` Michal Hocko
0 siblings, 1 reply; 2+ messages in thread
From: Fan Du @ 2017-11-15 8:40 UTC (permalink / raw)
To: mhocko; +Cc: akpm, linux-kernel, Fan Du
Here, pfn_to_node should be page_to_nid.
Signed-off-by: Fan Du <fan.du@intel.com>
---
mm/memory_hotplug.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/mm/memory_hotplug.c b/mm/memory_hotplug.c
index d4b5f29..c3c1c57 100644
--- a/mm/memory_hotplug.c
+++ b/mm/memory_hotplug.c
@@ -265,7 +265,7 @@ static int __meminit __add_section(int nid, unsigned long phys_start_pfn,
/*
* Make all the pages reserved so that nobody will stumble over half
* initialized state.
- * FIXME: We also have to associate it with a node because pfn_to_node
+ * FIXME: We also have to associate it with a node because page_to_nid
* relies on having page with the proper node.
*/
for (i = 0; i < PAGES_PER_SECTION; i++) {
--
1.8.3.1
^ permalink raw reply [flat|nested] 2+ messages in thread* Re: [PATCH] memory hotplug: fix comments when add section
2017-11-15 8:40 [PATCH] memory hotplug: fix comments when add section Fan Du
@ 2017-11-15 9:18 ` Michal Hocko
0 siblings, 0 replies; 2+ messages in thread
From: Michal Hocko @ 2017-11-15 9:18 UTC (permalink / raw)
To: Fan Du; +Cc: akpm, linux-kernel
On Wed 15-11-17 16:40:05, Fan Du wrote:
> Here, pfn_to_node should be page_to_nid.
>
> Signed-off-by: Fan Du <fan.du@intel.com>
Yes, it is a typo. And the one worth fixing because this will make git grep
great again
Acked-by: Michal Hocko <mhocko@suse.com>
> ---
> mm/memory_hotplug.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/mm/memory_hotplug.c b/mm/memory_hotplug.c
> index d4b5f29..c3c1c57 100644
> --- a/mm/memory_hotplug.c
> +++ b/mm/memory_hotplug.c
> @@ -265,7 +265,7 @@ static int __meminit __add_section(int nid, unsigned long phys_start_pfn,
> /*
> * Make all the pages reserved so that nobody will stumble over half
> * initialized state.
> - * FIXME: We also have to associate it with a node because pfn_to_node
> + * FIXME: We also have to associate it with a node because page_to_nid
> * relies on having page with the proper node.
> */
> for (i = 0; i < PAGES_PER_SECTION; i++) {
> --
> 1.8.3.1
--
Michal Hocko
SUSE Labs
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2017-11-15 9:19 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-11-15 8:40 [PATCH] memory hotplug: fix comments when add section Fan Du
2017-11-15 9:18 ` Michal Hocko
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®