From: David Woodhouse <dwmw2@infradead.org>
To: Borislav Petkov <bp@alien8.de>
Cc: arjan@linux.intel.com, tglx@linutronix.de, karahmed@amazon.de,
x86@kernel.org, linux-kernel@vger.kernel.org,
tim.c.chen@linux.intel.com, peterz@infradead.org,
pbonzini@redhat.com, ak@linux.intel.com,
torvalds@linux-foundation.org, gregkh@linux-foundation.org,
dave.hansen@intel.com, gnomes@lxorguk.ukuu.org.uk,
ashok.raj@intel.com, mingo@kernel.org
Subject: Re: [PATCH v4 7/7] x86/speculation: Add basic IBPB (Indirect Branch Prediction Barrier) support
Date: Thu, 25 Jan 2018 12:11:55 +0000 [thread overview]
Message-ID: <1516882315.30244.88.camel@infradead.org> (raw)
In-Reply-To: <20180125120348.ss62p5yaviemprxn@pd.tnic>
[-- Attachment #1: Type: text/plain, Size: 819 bytes --]
On Thu, 2018-01-25 at 13:03 +0100, Borislav Petkov wrote:
> On Thu, Jan 25, 2018 at 11:58:20AM +0000, David Woodhouse wrote:
> > They're immediates, not registers. So it's like the first example
> in...
>
> Oh, I know very well what they are - I simply find the macro more
> readable if there are less or no arguments.
Oh, I agree, but having to write 0x49 there instead of
MSR_IA32_PRED_CMD was a more pressing reason *not* to change it.
There are possibly macro hacks that can make that work (the first naïve
attempt didn't) but it exceeded my boredom threshold fairly rapidly.
If you send me a version which still uses MSR_IA32_PRED_CMD and
PRED_CMD_IBPB instead of hard-coding the numbers, and which doesn't end
up with piles of __stringify() and similar crap to do so, I'll happily
change it.
[-- Attachment #2: smime.p7s --]
[-- Type: application/x-pkcs7-signature, Size: 5213 bytes --]
prev parent reply other threads:[~2018-01-25 12:11 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-25 9:23 [PATCH v4 0/7] Basic Speculation Control feature support David Woodhouse
2018-01-25 9:23 ` [PATCH v4 1/7] x86/cpufeatures: Add CPUID_7_EDX CPUID leaf David Woodhouse
2018-01-25 9:23 ` [PATCH v4 2/7] x86/cpufeatures: Add Intel feature bits for Speculation Control David Woodhouse
2018-01-25 9:23 ` [PATCH v4 3/7] x86/cpufeatures: Add AMD " David Woodhouse
2018-01-25 9:23 ` [PATCH v4 4/7] x86/msr: Add definitions for new speculation control MSRs David Woodhouse
2018-01-25 9:23 ` [PATCH v4 5/7] x86/pti: Do not enable PTI on processors which are not vulnerable to Meltdown David Woodhouse
2018-01-25 9:42 ` Peter Zijlstra
2018-01-25 9:56 ` David Woodhouse
2018-01-25 10:01 ` Thomas Gleixner
2018-01-25 15:12 ` Alan Cox
2018-01-25 9:23 ` [PATCH v4 6/7] x86/cpufeature: Blacklist SPEC_CTRL on early Spectre v2 microcodes David Woodhouse
2018-01-25 10:43 ` David Woodhouse
2018-01-25 10:54 ` Thomas Gleixner
2018-01-25 11:20 ` David Woodhouse
2018-01-25 11:34 ` Thomas Gleixner
2018-01-25 13:41 ` David Woodhouse
2018-01-25 14:58 ` Thomas Gleixner
2018-01-25 16:16 ` Alan Cox
2018-01-25 16:24 ` Thomas Gleixner
2018-01-25 16:35 ` David Woodhouse
2018-01-26 9:40 ` Ingo Molnar
2018-01-25 9:23 ` [PATCH v4 7/7] x86/speculation: Add basic IBPB (Indirect Branch Prediction Barrier) support David Woodhouse
2018-01-25 11:41 ` Borislav Petkov
2018-01-25 11:47 ` David Woodhouse
2018-01-25 11:50 ` Borislav Petkov
2018-01-25 11:58 ` David Woodhouse
2018-01-25 12:03 ` Borislav Petkov
2018-01-25 12:11 ` David Woodhouse [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1516882315.30244.88.camel@infradead.org \
--to=dwmw2@infradead.org \
--cc=ak@linux.intel.com \
--cc=arjan@linux.intel.com \
--cc=ashok.raj@intel.com \
--cc=bp@alien8.de \
--cc=dave.hansen@intel.com \
--cc=gnomes@lxorguk.ukuu.org.uk \
--cc=gregkh@linux-foundation.org \
--cc=karahmed@amazon.de \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=pbonzini@redhat.com \
--cc=peterz@infradead.org \
--cc=tglx@linutronix.de \
--cc=tim.c.chen@linux.intel.com \
--cc=torvalds@linux-foundation.org \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®