mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
* [PATCH] regulator: giving regulator controlling gpios a non-empty label when used through the devicetree.
@ 2018-03-19 13:23 Nicholas Lowell
  2018-03-20  1:22 ` Applied "regulator: giving regulator controlling gpios a non-empty label when used through the devicetree." to the regulator tree Mark Brown
  0 siblings, 1 reply; 3+ messages in thread
From: Nicholas Lowell @ 2018-03-19 13:23 UTC (permalink / raw)
  To: Liam Girdwood, Mark Brown, linux-kernel; +Cc: Nicholas Lowell

When the label is empty, it causes missing information and limits diagnostics
for instances such as 'cat /sys/kernel/debug/gpio'

Setting the label to the regulator supply_name will point to the device
using the gpio(s).

Signed-off-by: Nicholas Lowell <nlowell@lexmark.com>
---
 drivers/regulator/gpio-regulator.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/regulator/gpio-regulator.c b/drivers/regulator/gpio-regulator.c
index 0fce06a..b1f00e2 100644
--- a/drivers/regulator/gpio-regulator.c
+++ b/drivers/regulator/gpio-regulator.c
@@ -196,6 +196,7 @@ of_get_gpio_regulator_config(struct device *dev, struct device_node *np,
 				break;
 			}
 			config->gpios[i].gpio = gpio;
+			config->gpios[i].label = config->supply_name;
 			if (proplen > 0) {
 				of_property_read_u32_index(np, "gpios-states",
 							   i, &ret);
-- 
2.7.4

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Applied "regulator: giving regulator controlling gpios a non-empty label when used through the devicetree." to the regulator tree
  2018-03-19 13:23 [PATCH] regulator: giving regulator controlling gpios a non-empty label when used through the devicetree Nicholas Lowell
@ 2018-03-20  1:22 ` Mark Brown
  0 siblings, 0 replies; 3+ messages in thread
From: Mark Brown @ 2018-03-20  1:22 UTC (permalink / raw)
  To: Nicholas Lowell
  Cc: Mark Brown, Liam Girdwood, Mark Brown, linux-kernel, linux-kernel

The patch

   regulator: giving regulator controlling gpios a non-empty label when used through the devicetree.

has been applied to the regulator tree at

   https://git.kernel.org/pub/scm/linux/kernel/git/broonie/regulator.git 

All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.  

You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying
to this mail.

Thanks,
Mark

>From 37ad490bab09b7c218e37b570069cf188f2616e7 Mon Sep 17 00:00:00 2001
From: Nicholas Lowell <nlowell@lexmark.com>
Date: Mon, 19 Mar 2018 09:23:14 -0400
Subject: [PATCH] regulator: giving regulator controlling gpios a non-empty
 label when used through the devicetree.

When the label is empty, it causes missing information and limits diagnostics
for instances such as 'cat /sys/kernel/debug/gpio'

Setting the label to the regulator supply_name will point to the device
using the gpio(s).

Signed-off-by: Nicholas Lowell <nlowell@lexmark.com>
Signed-off-by: Mark Brown <broonie@kernel.org>
---
 drivers/regulator/gpio-regulator.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/regulator/gpio-regulator.c b/drivers/regulator/gpio-regulator.c
index a2eb50719c7b..a86b8997bb54 100644
--- a/drivers/regulator/gpio-regulator.c
+++ b/drivers/regulator/gpio-regulator.c
@@ -196,6 +196,7 @@ of_get_gpio_regulator_config(struct device *dev, struct device_node *np,
 				break;
 			}
 			config->gpios[i].gpio = gpio;
+			config->gpios[i].label = config->supply_name;
 			if (proplen > 0) {
 				of_property_read_u32_index(np, "gpios-states",
 							   i, &ret);
-- 
2.16.2

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] regulator: giving regulator controlling gpios a non-empty label when used through the devicetree
       [not found] <CANnE4YfYihuhAa8TtdzDB+MR2njSwszFRvr2g+h=mcRjD-DiiQ@mail.gmail.com>
@ 2018-03-05 15:40 ` Mark Brown
  0 siblings, 0 replies; 3+ messages in thread
From: Mark Brown @ 2018-03-05 15:40 UTC (permalink / raw)
  To: Nicholas Lowell; +Cc: lgirdwood, linux-kernel

[-- Attachment #1: Type: text/plain, Size: 609 bytes --]

On Fri, Mar 02, 2018 at 11:20:49AM -0500, Nicholas Lowell wrote:

> +++ b/drivers/regulator/gpio-regulator.c
> @@ -196,6 +196,7 @@ of_get_gpio_regulator_config(struct device *dev, struct
> device_node *np,
>   break;
>   }
>   config->gpios[i].gpio = gpio;
> + config->gpios[i].label = config->supply_name;
>   if (proplen > 0) {
>   of_property_read_u32_index(np, "gpios-states",
>      i, &ret);
> -- 
> 2.7.4

This patch is completely mangled, please see Documentation/SubmittingPatches
- it looks like tabs have been converted into single spaces and there's
some word wrapping going on.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2018-03-20  1:22 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-03-19 13:23 [PATCH] regulator: giving regulator controlling gpios a non-empty label when used through the devicetree Nicholas Lowell
2018-03-20  1:22 ` Applied "regulator: giving regulator controlling gpios a non-empty label when used through the devicetree." to the regulator tree Mark Brown
     [not found] <CANnE4YfYihuhAa8TtdzDB+MR2njSwszFRvr2g+h=mcRjD-DiiQ@mail.gmail.com>
2018-03-05 15:40 ` [PATCH] regulator: giving regulator controlling gpios a non-empty label when used through the devicetree Mark Brown

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®