From: Vasant Hegde <vasant.hegde@amd.com>
To: Magnus Kalland <magnus@dolphinics.com>,
suravee.suthikulpanit@amd.com, joro@8bytes.org,
iommu@lists.linux.dev, linux-kernel@vger.kernel.org
Cc: dhsrivas@amd.com
Subject: Re: [PATCH v3 1/3] iommu/amd: Use raw spinlock for interrupt remapping tables
Date: Mon, 30 Mar 2026 20:53:48 +0530 [thread overview]
Message-ID: <152a5b57-4956-4f49-85f8-d32ef5f44beb@amd.com> (raw)
In-Reply-To: <20260225202330.23027-2-magnus@dolphinics.com>
Magnus,
On 2/26/2026 1:53 AM, Magnus Kalland wrote:
> Use raw spinlock for interrupt remapping tables since
> iommu_flush_irt_and_complete is called under a raw spinlock.
>
I spent sometime going through entire flow. I think we can re-arrange code so
that we can avoid this lock change.
#1 ) alloc_irq_table()
Remove iommu_flush_dte() from set_remap_table_entry /
set_remap_table_entry_alias
Once table is updated, at the end of this function we can have a logic to
flush/completion wait.
#2) iommu_flush_irt_and_complete()
This needs to be reworked to match device_flush_dte()
Makes sense? Did I miss anything?
-Vasant
next prev parent reply other threads:[~2026-03-30 15:24 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-25 20:23 [PATCH v3 0/3] iommu/amd: Invalidate IRT cache for DMA aliases Magnus Kalland
2026-02-25 20:23 ` [PATCH v3 1/3] iommu/amd: Use raw spinlock for interrupt remapping tables Magnus Kalland
2026-03-30 15:23 ` Vasant Hegde [this message]
2026-03-31 13:10 ` Magnus Kalland
2026-02-25 20:23 ` [PATCH v3 2/3] iommu/amd: Track PCIe DMA aliases in set_remap_table_entry_alias Magnus Kalland
2026-02-25 20:23 ` [PATCH v3 3/3] iommu/amd: Invalidate IRT cache for DMA aliases Magnus Kalland
2026-03-30 11:18 ` Vasant Hegde
2026-03-31 12:48 ` Magnus Kalland
2026-04-01 7:44 ` Vasant Hegde
2026-04-01 10:34 ` Magnus Kalland
2026-04-01 10:46 ` Vasant Hegde
2026-04-01 11:38 ` Magnus Kalland
2026-03-06 9:22 [PATCH v3 0/3] " Magnus Kalland
2026-03-06 9:22 ` [PATCH v3 1/3] iommu/amd: Use raw spinlock for interrupt remapping tables Magnus Kalland
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=152a5b57-4956-4f49-85f8-d32ef5f44beb@amd.com \
--to=vasant.hegde@amd.com \
--cc=dhsrivas@amd.com \
--cc=iommu@lists.linux.dev \
--cc=joro@8bytes.org \
--cc=linux-kernel@vger.kernel.org \
--cc=magnus@dolphinics.com \
--cc=suravee.suthikulpanit@amd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®