From: Magnus Kalland <magnus@dolphinics.com>
To: vasant.hegde@amd.com, suravee.suthikulpanit@amd.com,
joro@8bytes.org, iommu@lists.linux.dev,
linux-kernel@vger.kernel.org
Cc: dhsrivas@amd.com, Magnus Kalland <magnus@dolphinics.com>
Subject: [PATCH v3 1/3] iommu/amd: Use raw spinlock for interrupt remapping tables
Date: Wed, 25 Feb 2026 21:23:28 +0100 [thread overview]
Message-ID: <20260225202330.23027-2-magnus@dolphinics.com> (raw)
In-Reply-To: <20260225202330.23027-1-magnus@dolphinics.com>
Use raw spinlock for interrupt remapping tables since
iommu_flush_irt_and_complete is called under a raw spinlock.
Signed-off-by: Magnus Kalland <magnus@dolphinics.com>
---
drivers/iommu/amd/iommu.c | 11 ++++++-----
1 file changed, 6 insertions(+), 5 deletions(-)
diff --git a/drivers/iommu/amd/iommu.c b/drivers/iommu/amd/iommu.c
index 81c4d7733872..f3193c6428c9 100644
--- a/drivers/iommu/amd/iommu.c
+++ b/drivers/iommu/amd/iommu.c
@@ -3164,7 +3164,8 @@ const struct iommu_ops amd_iommu_ops = {
*****************************************************************************/
static struct irq_chip amd_ir_chip;
-static DEFINE_SPINLOCK(iommu_table_lock);
+static DEFINE_RAW_SPINLOCK(iommu_table_lock);
+
static void iommu_flush_irt_and_complete(struct amd_iommu *iommu, u16 devid)
{
@@ -3310,7 +3311,7 @@ static struct irq_remap_table *alloc_irq_table(struct amd_iommu *iommu,
int nid = iommu->dev ? dev_to_node(&iommu->dev->dev) : NUMA_NO_NODE;
u16 alias;
- spin_lock_irqsave(&iommu_table_lock, flags);
+ raw_spin_lock_irqsave(&iommu_table_lock, flags);
pci_seg = iommu->pci_seg;
table = pci_seg->irq_lookup_table[devid];
@@ -3323,14 +3324,14 @@ static struct irq_remap_table *alloc_irq_table(struct amd_iommu *iommu,
set_remap_table_entry(iommu, devid, table);
goto out_wait;
}
- spin_unlock_irqrestore(&iommu_table_lock, flags);
+ raw_spin_unlock_irqrestore(&iommu_table_lock, flags);
/* Nothing there yet, allocate new irq remapping table */
new_table = __alloc_irq_table(nid, get_irq_table_size(max_irqs));
if (!new_table)
return NULL;
- spin_lock_irqsave(&iommu_table_lock, flags);
+ raw_spin_lock_irqsave(&iommu_table_lock, flags);
table = pci_seg->irq_lookup_table[devid];
if (table)
@@ -3358,7 +3359,7 @@ static struct irq_remap_table *alloc_irq_table(struct amd_iommu *iommu,
iommu_completion_wait(iommu);
out_unlock:
- spin_unlock_irqrestore(&iommu_table_lock, flags);
+ raw_spin_unlock_irqrestore(&iommu_table_lock, flags);
if (new_table) {
iommu_free_pages(new_table->table);
--
2.43.0
next prev parent reply other threads:[~2026-02-25 20:23 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-25 20:23 [PATCH v3 0/3] iommu/amd: Invalidate IRT cache for DMA aliases Magnus Kalland
2026-02-25 20:23 ` Magnus Kalland [this message]
2026-03-30 15:23 ` [PATCH v3 1/3] iommu/amd: Use raw spinlock for interrupt remapping tables Vasant Hegde
2026-03-31 13:10 ` Magnus Kalland
2026-02-25 20:23 ` [PATCH v3 2/3] iommu/amd: Track PCIe DMA aliases in set_remap_table_entry_alias Magnus Kalland
2026-02-25 20:23 ` [PATCH v3 3/3] iommu/amd: Invalidate IRT cache for DMA aliases Magnus Kalland
2026-03-30 11:18 ` Vasant Hegde
2026-03-31 12:48 ` Magnus Kalland
2026-04-01 7:44 ` Vasant Hegde
2026-04-01 10:34 ` Magnus Kalland
2026-04-01 10:46 ` Vasant Hegde
2026-04-01 11:38 ` Magnus Kalland
2026-03-06 9:22 [PATCH v3 0/3] " Magnus Kalland
2026-03-06 9:22 ` [PATCH v3 1/3] iommu/amd: Use raw spinlock for interrupt remapping tables Magnus Kalland
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260225202330.23027-2-magnus@dolphinics.com \
--to=magnus@dolphinics.com \
--cc=dhsrivas@amd.com \
--cc=iommu@lists.linux.dev \
--cc=joro@8bytes.org \
--cc=linux-kernel@vger.kernel.org \
--cc=suravee.suthikulpanit@amd.com \
--cc=vasant.hegde@amd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®