* [PATCH v2] net: atm: Remove the error message according to the atomic context
@ 2020-06-11 0:38 Yi Wang
2020-06-11 1:08 ` David Miller
0 siblings, 1 reply; 2+ messages in thread
From: Yi Wang @ 2020-06-11 0:38 UTC (permalink / raw)
To: davem
Cc: kuba, mst, hkallweit1, snelson, andriy.shevchenko,
xiyou.wangcong, netdev, linux-kernel, xue.zhihong, wang.yi59,
wang.liang82, Liao Pingfang
From: Liao Pingfang <liao.pingfang@zte.com.cn>
Looking into the context (atomic!) and the error message should be dropped.
Signed-off-by: Liao Pingfang <liao.pingfang@zte.com.cn>
---
Changes in v2: drop the error message instead of changing it.
net/atm/lec.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/net/atm/lec.c b/net/atm/lec.c
index ca37f5a..997ce13 100644
--- a/net/atm/lec.c
+++ b/net/atm/lec.c
@@ -1537,7 +1537,6 @@ static struct lec_arp_table *make_entry(struct lec_priv *priv,
to_return = kzalloc(sizeof(struct lec_arp_table), GFP_ATOMIC);
if (!to_return) {
- pr_info("LEC: Arp entry kmalloc failed\n");
return NULL;
}
ether_addr_copy(to_return->mac_addr, mac_addr);
--
2.9.5
^ permalink raw reply [flat|nested] 2+ messages in thread* Re: [PATCH v2] net: atm: Remove the error message according to the atomic context
2020-06-11 0:38 [PATCH v2] net: atm: Remove the error message according to the atomic context Yi Wang
@ 2020-06-11 1:08 ` David Miller
0 siblings, 0 replies; 2+ messages in thread
From: David Miller @ 2020-06-11 1:08 UTC (permalink / raw)
To: wang.yi59
Cc: kuba, mst, hkallweit1, snelson, andriy.shevchenko,
xiyou.wangcong, netdev, linux-kernel, xue.zhihong, wang.liang82,
liao.pingfang
From: Yi Wang <wang.yi59@zte.com.cn>
Date: Thu, 11 Jun 2020 08:38:50 +0800
> @@ -1537,7 +1537,6 @@ static struct lec_arp_table *make_entry(struct lec_priv *priv,
>
> to_return = kzalloc(sizeof(struct lec_arp_table), GFP_ATOMIC);
> if (!to_return) {
> - pr_info("LEC: Arp entry kmalloc failed\n");
> return NULL;
> }
This now becomes a single-statement basic block and thus the curly
braces should be removed.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-06-11 1:09 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-06-11 0:38 [PATCH v2] net: atm: Remove the error message according to the atomic context Yi Wang
2020-06-11 1:08 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®