* [PATCH v2 0/2] phy: renesas: rcar-gen3-usb2: Add suspend to RAM support
@ 2025-11-19 12:04 Claudiu
2025-11-19 12:04 ` [PATCH v2 1/2] phy: renesas: rcar-gen3-usb2: Move phy_data->init_bus check Claudiu
` (2 more replies)
0 siblings, 3 replies; 6+ messages in thread
From: Claudiu @ 2025-11-19 12:04 UTC (permalink / raw)
To: yoshihiro.shimoda.uh, vkoul, kishon, geert+renesas, magnus.damm, p.zabel
Cc: claudiu.beznea, linux-renesas-soc, linux-phy, linux-kernel,
Claudiu Beznea
From: Claudiu Beznea <claudiu.beznea.uj@bp.renesas.com>
Hi,
Series adds suspend to RAM support for the Renesas R-Car GEN3 USB2 PHY
driver. Along with it, a preparatory patch was added (patch 1/2).
Series is built on top of patches 1/7, 2/7 at [1]
Thank you,
Claudiu
Changes in v2:
- added patch 1/2 which was initially part of suspend to RAM support
patch
[1] https://lore.kernel.org/all/20251023135810.1688415-2-claudiu.beznea.uj@bp.renesas.com
Claudiu Beznea (2):
phy: renesas: rcar-gen3-usb2: Move phy_data->init_bus check
phy: renesas: rcar-gen3-usb2: Add suspend/resume support
drivers/phy/renesas/phy-rcar-gen3-usb2.c | 66 +++++++++++++++++-------
1 file changed, 47 insertions(+), 19 deletions(-)
--
2.43.0
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH v2 1/2] phy: renesas: rcar-gen3-usb2: Move phy_data->init_bus check
2025-11-19 12:04 [PATCH v2 0/2] phy: renesas: rcar-gen3-usb2: Add suspend to RAM support Claudiu
@ 2025-11-19 12:04 ` Claudiu
2025-11-19 14:49 ` Neil Armstrong
2025-11-19 12:04 ` [PATCH v2 2/2] phy: renesas: rcar-gen3-usb2: Add suspend/resume support Claudiu
2025-11-20 17:11 ` [PATCH v2 0/2] phy: renesas: rcar-gen3-usb2: Add suspend to RAM support Vinod Koul
2 siblings, 1 reply; 6+ messages in thread
From: Claudiu @ 2025-11-19 12:04 UTC (permalink / raw)
To: yoshihiro.shimoda.uh, vkoul, kishon, geert+renesas, magnus.damm, p.zabel
Cc: claudiu.beznea, linux-renesas-soc, linux-phy, linux-kernel,
Claudiu Beznea
From: Claudiu Beznea <claudiu.beznea.uj@bp.renesas.com>
Move the check of phy_data->init_bus from rcar_gen3_phy_usb2_init_bus()
to rcar_gen3_phy_usb2_probe() to avoid having it duplicated in both the
probe path and the upcoming resume code. This is a preparatory patch.
Signed-off-by: Claudiu Beznea <claudiu.beznea.uj@bp.renesas.com>
---
Changes in v2:
- none; this patch is new
drivers/phy/renesas/phy-rcar-gen3-usb2.c | 11 ++++++-----
1 file changed, 6 insertions(+), 5 deletions(-)
diff --git a/drivers/phy/renesas/phy-rcar-gen3-usb2.c b/drivers/phy/renesas/phy-rcar-gen3-usb2.c
index a38ead7c8055..b9d5bb52e02c 100644
--- a/drivers/phy/renesas/phy-rcar-gen3-usb2.c
+++ b/drivers/phy/renesas/phy-rcar-gen3-usb2.c
@@ -782,6 +782,9 @@ static int rcar_gen3_phy_usb2_init_bus(struct rcar_gen3_chan *channel)
int ret;
u32 val;
+ if (!channel->phy_data->init_bus)
+ return 0;
+
rstc = devm_reset_control_array_get_shared(dev);
if (IS_ERR(rstc))
return PTR_ERR(rstc);
@@ -861,11 +864,9 @@ static int rcar_gen3_phy_usb2_probe(struct platform_device *pdev)
platform_set_drvdata(pdev, channel);
channel->dev = dev;
- if (channel->phy_data->init_bus) {
- ret = rcar_gen3_phy_usb2_init_bus(channel);
- if (ret)
- goto error;
- }
+ ret = rcar_gen3_phy_usb2_init_bus(channel);
+ if (ret)
+ goto error;
spin_lock_init(&channel->lock);
for (i = 0; i < NUM_OF_PHYS; i++) {
--
2.43.0
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH v2 2/2] phy: renesas: rcar-gen3-usb2: Add suspend/resume support
2025-11-19 12:04 [PATCH v2 0/2] phy: renesas: rcar-gen3-usb2: Add suspend to RAM support Claudiu
2025-11-19 12:04 ` [PATCH v2 1/2] phy: renesas: rcar-gen3-usb2: Move phy_data->init_bus check Claudiu
@ 2025-11-19 12:04 ` Claudiu
2025-11-19 14:49 ` Neil Armstrong
2025-11-20 17:11 ` [PATCH v2 0/2] phy: renesas: rcar-gen3-usb2: Add suspend to RAM support Vinod Koul
2 siblings, 1 reply; 6+ messages in thread
From: Claudiu @ 2025-11-19 12:04 UTC (permalink / raw)
To: yoshihiro.shimoda.uh, vkoul, kishon, geert+renesas, magnus.damm, p.zabel
Cc: claudiu.beznea, linux-renesas-soc, linux-phy, linux-kernel,
Claudiu Beznea
From: Claudiu Beznea <claudiu.beznea.uj@bp.renesas.com>
The Renesas RZ/G3S supports a power saving mode where power to most of the
SoC components is turned off. The USB PHY is among these components.
Because of this the settings applied in driver probe need to be executed
also on resume path. On suspend path only reset signal need to be asserted.
Add suspend/resume support.
Signed-off-by: Claudiu Beznea <claudiu.beznea.uj@bp.renesas.com>
---
Changes in v2:
- dropped the changes that were integrated in patch 1/2
drivers/phy/renesas/phy-rcar-gen3-usb2.c | 57 +++++++++++++++++-------
1 file changed, 42 insertions(+), 15 deletions(-)
diff --git a/drivers/phy/renesas/phy-rcar-gen3-usb2.c b/drivers/phy/renesas/phy-rcar-gen3-usb2.c
index b9d5bb52e02c..3c063e4dea41 100644
--- a/drivers/phy/renesas/phy-rcar-gen3-usb2.c
+++ b/drivers/phy/renesas/phy-rcar-gen3-usb2.c
@@ -132,6 +132,7 @@ struct rcar_gen3_chan {
struct device *dev; /* platform_device's device */
const struct rcar_gen3_phy_drv_data *phy_data;
struct extcon_dev *extcon;
+ struct reset_control *rstc;
struct rcar_gen3_phy rphys[NUM_OF_PHYS];
struct regulator *vbus;
struct work_struct work;
@@ -778,38 +779,24 @@ static void rcar_gen3_reset_assert(void *data)
static int rcar_gen3_phy_usb2_init_bus(struct rcar_gen3_chan *channel)
{
struct device *dev = channel->dev;
- struct reset_control *rstc;
int ret;
u32 val;
if (!channel->phy_data->init_bus)
return 0;
- rstc = devm_reset_control_array_get_shared(dev);
- if (IS_ERR(rstc))
- return PTR_ERR(rstc);
-
ret = pm_runtime_resume_and_get(dev);
if (ret)
return ret;
- ret = reset_control_deassert(rstc);
- if (ret)
- goto rpm_put;
-
- ret = devm_add_action_or_reset(dev, rcar_gen3_reset_assert, rstc);
- if (ret)
- goto rpm_put;
-
val = readl(channel->base + USB2_AHB_BUS_CTR);
val &= ~USB2_AHB_BUS_CTR_MBL_MASK;
val |= USB2_AHB_BUS_CTR_MBL_INCR4;
writel(val, channel->base + USB2_AHB_BUS_CTR);
-rpm_put:
pm_runtime_put(dev);
- return ret;
+ return 0;
}
static int rcar_gen3_phy_usb2_probe(struct platform_device *pdev)
@@ -849,6 +836,18 @@ static int rcar_gen3_phy_usb2_probe(struct platform_device *pdev)
}
}
+ channel->rstc = devm_reset_control_array_get_optional_shared(dev);
+ if (IS_ERR(channel->rstc))
+ return PTR_ERR(channel->rstc);
+
+ ret = reset_control_deassert(channel->rstc);
+ if (ret)
+ return ret;
+
+ ret = devm_add_action_or_reset(dev, rcar_gen3_reset_assert, channel->rstc);
+ if (ret)
+ return ret;
+
/*
* devm_phy_create() will call pm_runtime_enable(&phy->dev);
* And then, phy-core will manage runtime pm for this device.
@@ -937,10 +936,38 @@ static void rcar_gen3_phy_usb2_remove(struct platform_device *pdev)
pm_runtime_disable(&pdev->dev);
};
+static int rcar_gen3_phy_usb2_suspend(struct device *dev)
+{
+ struct rcar_gen3_chan *channel = dev_get_drvdata(dev);
+
+ return reset_control_assert(channel->rstc);
+}
+
+static int rcar_gen3_phy_usb2_resume(struct device *dev)
+{
+ struct rcar_gen3_chan *channel = dev_get_drvdata(dev);
+ int ret;
+
+ ret = reset_control_deassert(channel->rstc);
+ if (ret)
+ return ret;
+
+ ret = rcar_gen3_phy_usb2_init_bus(channel);
+ if (ret)
+ reset_control_assert(channel->rstc);
+
+ return ret;
+}
+
+static DEFINE_SIMPLE_DEV_PM_OPS(rcar_gen3_phy_usb2_pm_ops,
+ rcar_gen3_phy_usb2_suspend,
+ rcar_gen3_phy_usb2_resume);
+
static struct platform_driver rcar_gen3_phy_usb2_driver = {
.driver = {
.name = "phy_rcar_gen3_usb2",
.of_match_table = rcar_gen3_phy_usb2_match_table,
+ .pm = pm_ptr(&rcar_gen3_phy_usb2_pm_ops),
},
.probe = rcar_gen3_phy_usb2_probe,
.remove = rcar_gen3_phy_usb2_remove,
--
2.43.0
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH v2 1/2] phy: renesas: rcar-gen3-usb2: Move phy_data->init_bus check
2025-11-19 12:04 ` [PATCH v2 1/2] phy: renesas: rcar-gen3-usb2: Move phy_data->init_bus check Claudiu
@ 2025-11-19 14:49 ` Neil Armstrong
0 siblings, 0 replies; 6+ messages in thread
From: Neil Armstrong @ 2025-11-19 14:49 UTC (permalink / raw)
To: Claudiu, yoshihiro.shimoda.uh, vkoul, kishon, geert+renesas,
magnus.damm, p.zabel
Cc: linux-renesas-soc, linux-phy, linux-kernel, Claudiu Beznea
On 11/19/25 13:04, Claudiu wrote:
> From: Claudiu Beznea <claudiu.beznea.uj@bp.renesas.com>
>
> Move the check of phy_data->init_bus from rcar_gen3_phy_usb2_init_bus()
> to rcar_gen3_phy_usb2_probe() to avoid having it duplicated in both the
> probe path and the upcoming resume code. This is a preparatory patch.
>
> Signed-off-by: Claudiu Beznea <claudiu.beznea.uj@bp.renesas.com>
> ---
>
> Changes in v2:
> - none; this patch is new
>
> drivers/phy/renesas/phy-rcar-gen3-usb2.c | 11 ++++++-----
> 1 file changed, 6 insertions(+), 5 deletions(-)
>
> diff --git a/drivers/phy/renesas/phy-rcar-gen3-usb2.c b/drivers/phy/renesas/phy-rcar-gen3-usb2.c
> index a38ead7c8055..b9d5bb52e02c 100644
> --- a/drivers/phy/renesas/phy-rcar-gen3-usb2.c
> +++ b/drivers/phy/renesas/phy-rcar-gen3-usb2.c
> @@ -782,6 +782,9 @@ static int rcar_gen3_phy_usb2_init_bus(struct rcar_gen3_chan *channel)
> int ret;
> u32 val;
>
> + if (!channel->phy_data->init_bus)
> + return 0;
> +
> rstc = devm_reset_control_array_get_shared(dev);
> if (IS_ERR(rstc))
> return PTR_ERR(rstc);
> @@ -861,11 +864,9 @@ static int rcar_gen3_phy_usb2_probe(struct platform_device *pdev)
> platform_set_drvdata(pdev, channel);
> channel->dev = dev;
>
> - if (channel->phy_data->init_bus) {
> - ret = rcar_gen3_phy_usb2_init_bus(channel);
> - if (ret)
> - goto error;
> - }
> + ret = rcar_gen3_phy_usb2_init_bus(channel);
> + if (ret)
> + goto error;
>
> spin_lock_init(&channel->lock);
> for (i = 0; i < NUM_OF_PHYS; i++) {
Reviewed-by: Neil Armstrong <neil.armstrong@linaro.org>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH v2 2/2] phy: renesas: rcar-gen3-usb2: Add suspend/resume support
2025-11-19 12:04 ` [PATCH v2 2/2] phy: renesas: rcar-gen3-usb2: Add suspend/resume support Claudiu
@ 2025-11-19 14:49 ` Neil Armstrong
0 siblings, 0 replies; 6+ messages in thread
From: Neil Armstrong @ 2025-11-19 14:49 UTC (permalink / raw)
To: Claudiu, yoshihiro.shimoda.uh, vkoul, kishon, geert+renesas,
magnus.damm, p.zabel
Cc: linux-renesas-soc, linux-phy, linux-kernel, Claudiu Beznea
On 11/19/25 13:04, Claudiu wrote:
> From: Claudiu Beznea <claudiu.beznea.uj@bp.renesas.com>
>
> The Renesas RZ/G3S supports a power saving mode where power to most of the
> SoC components is turned off. The USB PHY is among these components.
> Because of this the settings applied in driver probe need to be executed
> also on resume path. On suspend path only reset signal need to be asserted.
> Add suspend/resume support.
>
> Signed-off-by: Claudiu Beznea <claudiu.beznea.uj@bp.renesas.com>
> ---
>
> Changes in v2:
> - dropped the changes that were integrated in patch 1/2
>
> drivers/phy/renesas/phy-rcar-gen3-usb2.c | 57 +++++++++++++++++-------
> 1 file changed, 42 insertions(+), 15 deletions(-)
>
> diff --git a/drivers/phy/renesas/phy-rcar-gen3-usb2.c b/drivers/phy/renesas/phy-rcar-gen3-usb2.c
> index b9d5bb52e02c..3c063e4dea41 100644
> --- a/drivers/phy/renesas/phy-rcar-gen3-usb2.c
> +++ b/drivers/phy/renesas/phy-rcar-gen3-usb2.c
> @@ -132,6 +132,7 @@ struct rcar_gen3_chan {
> struct device *dev; /* platform_device's device */
> const struct rcar_gen3_phy_drv_data *phy_data;
> struct extcon_dev *extcon;
> + struct reset_control *rstc;
> struct rcar_gen3_phy rphys[NUM_OF_PHYS];
> struct regulator *vbus;
> struct work_struct work;
> @@ -778,38 +779,24 @@ static void rcar_gen3_reset_assert(void *data)
> static int rcar_gen3_phy_usb2_init_bus(struct rcar_gen3_chan *channel)
> {
> struct device *dev = channel->dev;
> - struct reset_control *rstc;
> int ret;
> u32 val;
>
> if (!channel->phy_data->init_bus)
> return 0;
>
> - rstc = devm_reset_control_array_get_shared(dev);
> - if (IS_ERR(rstc))
> - return PTR_ERR(rstc);
> -
> ret = pm_runtime_resume_and_get(dev);
> if (ret)
> return ret;
>
> - ret = reset_control_deassert(rstc);
> - if (ret)
> - goto rpm_put;
> -
> - ret = devm_add_action_or_reset(dev, rcar_gen3_reset_assert, rstc);
> - if (ret)
> - goto rpm_put;
> -
> val = readl(channel->base + USB2_AHB_BUS_CTR);
> val &= ~USB2_AHB_BUS_CTR_MBL_MASK;
> val |= USB2_AHB_BUS_CTR_MBL_INCR4;
> writel(val, channel->base + USB2_AHB_BUS_CTR);
>
> -rpm_put:
> pm_runtime_put(dev);
>
> - return ret;
> + return 0;
> }
>
> static int rcar_gen3_phy_usb2_probe(struct platform_device *pdev)
> @@ -849,6 +836,18 @@ static int rcar_gen3_phy_usb2_probe(struct platform_device *pdev)
> }
> }
>
> + channel->rstc = devm_reset_control_array_get_optional_shared(dev);
> + if (IS_ERR(channel->rstc))
> + return PTR_ERR(channel->rstc);
> +
> + ret = reset_control_deassert(channel->rstc);
> + if (ret)
> + return ret;
> +
> + ret = devm_add_action_or_reset(dev, rcar_gen3_reset_assert, channel->rstc);
> + if (ret)
> + return ret;
> +
> /*
> * devm_phy_create() will call pm_runtime_enable(&phy->dev);
> * And then, phy-core will manage runtime pm for this device.
> @@ -937,10 +936,38 @@ static void rcar_gen3_phy_usb2_remove(struct platform_device *pdev)
> pm_runtime_disable(&pdev->dev);
> };
>
> +static int rcar_gen3_phy_usb2_suspend(struct device *dev)
> +{
> + struct rcar_gen3_chan *channel = dev_get_drvdata(dev);
> +
> + return reset_control_assert(channel->rstc);
> +}
> +
> +static int rcar_gen3_phy_usb2_resume(struct device *dev)
> +{
> + struct rcar_gen3_chan *channel = dev_get_drvdata(dev);
> + int ret;
> +
> + ret = reset_control_deassert(channel->rstc);
> + if (ret)
> + return ret;
> +
> + ret = rcar_gen3_phy_usb2_init_bus(channel);
> + if (ret)
> + reset_control_assert(channel->rstc);
> +
> + return ret;
> +}
> +
> +static DEFINE_SIMPLE_DEV_PM_OPS(rcar_gen3_phy_usb2_pm_ops,
> + rcar_gen3_phy_usb2_suspend,
> + rcar_gen3_phy_usb2_resume);
> +
> static struct platform_driver rcar_gen3_phy_usb2_driver = {
> .driver = {
> .name = "phy_rcar_gen3_usb2",
> .of_match_table = rcar_gen3_phy_usb2_match_table,
> + .pm = pm_ptr(&rcar_gen3_phy_usb2_pm_ops),
> },
> .probe = rcar_gen3_phy_usb2_probe,
> .remove = rcar_gen3_phy_usb2_remove,
Reviewed-by: Neil Armstrong <neil.armstrong@linaro.org>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH v2 0/2] phy: renesas: rcar-gen3-usb2: Add suspend to RAM support
2025-11-19 12:04 [PATCH v2 0/2] phy: renesas: rcar-gen3-usb2: Add suspend to RAM support Claudiu
2025-11-19 12:04 ` [PATCH v2 1/2] phy: renesas: rcar-gen3-usb2: Move phy_data->init_bus check Claudiu
2025-11-19 12:04 ` [PATCH v2 2/2] phy: renesas: rcar-gen3-usb2: Add suspend/resume support Claudiu
@ 2025-11-20 17:11 ` Vinod Koul
2 siblings, 0 replies; 6+ messages in thread
From: Vinod Koul @ 2025-11-20 17:11 UTC (permalink / raw)
To: yoshihiro.shimoda.uh, kishon, geert+renesas, magnus.damm,
p.zabel, Claudiu
Cc: linux-renesas-soc, linux-phy, linux-kernel, Claudiu Beznea
On Wed, 19 Nov 2025 14:04:16 +0200, Claudiu wrote:
> Series adds suspend to RAM support for the Renesas R-Car GEN3 USB2 PHY
> driver. Along with it, a preparatory patch was added (patch 1/2).
>
> Series is built on top of patches 1/7, 2/7 at [1]
>
> Thank you,
> Claudiu
>
> [...]
Applied, thanks!
[1/2] phy: renesas: rcar-gen3-usb2: Move phy_data->init_bus check
commit: 79d9db7f7a0c94b2b505666513879ac470c7e12f
[2/2] phy: renesas: rcar-gen3-usb2: Add suspend/resume support
commit: 942a7a6bf4c6a8661324539f686a34c9448610bd
Best regards,
--
~Vinod
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2025-11-20 17:11 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2025-11-19 12:04 [PATCH v2 0/2] phy: renesas: rcar-gen3-usb2: Add suspend to RAM support Claudiu
2025-11-19 12:04 ` [PATCH v2 1/2] phy: renesas: rcar-gen3-usb2: Move phy_data->init_bus check Claudiu
2025-11-19 14:49 ` Neil Armstrong
2025-11-19 12:04 ` [PATCH v2 2/2] phy: renesas: rcar-gen3-usb2: Add suspend/resume support Claudiu
2025-11-19 14:49 ` Neil Armstrong
2025-11-20 17:11 ` [PATCH v2 0/2] phy: renesas: rcar-gen3-usb2: Add suspend to RAM support Vinod Koul
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®